From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Denis CIOCCA <denis.ciocca@st.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Daniel Palmer <daniel@0x0f.com>, Mario TESI <mario.tesi@st.com>
Subject: Re: [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E
Date: Thu, 20 Aug 2020 11:17:05 +0200 [thread overview]
Message-ID: <20200820091705.GA1122903@kroah.com> (raw)
In-Reply-To: <20200820100100.00000d33@Huawei.com>
On Thu, Aug 20, 2020 at 10:01:00AM +0100, Jonathan Cameron wrote:
>
> +CC: GregKH as this will pass through his tree.
>
> As a quick summary, it seems we have some cloned parts that appear to be compatible
> with certain ST micro parts, but have different whoami address values.
>
> Entirely reasonably, Denis is not happy to have them added to the ST maintained driver
> given the potential for future incompatibilities.
>
> I don't particularly mind a separate driver, though I would ask that we remove
> a lot of the abstractions from the ST driver as they won't be necessary given
> the much more restricted parts being supported,
>
> Greg, I'm guessing this is far from the first time this has happened.
> Any advise?
Yes, this happens all the time. Do not create a whole new driver if at
all possible, that way lies duplicated work and madness. Just add the
new ids or whatever to the existing driver and have everyone work with
it together.
"future incompatibilities" are never something to plan for, we can deal
with that when/if that ever happens.
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-20 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 13:48 [RFC PATCH 0/2] iio: st-accel: Add support for Silan clones Daniel Palmer
2020-08-11 13:48 ` [RFC PATCH 1/2] dt-bindings: vendor-prefixes: Add vendor prefix for Silan Daniel Palmer
2020-08-16 8:50 ` Jonathan Cameron
2020-08-11 13:48 ` [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E Daniel Palmer
2020-08-16 8:52 ` Jonathan Cameron
2020-08-16 9:27 ` Daniel Palmer
2020-08-16 9:40 ` Jonathan Cameron
2020-08-16 9:55 ` Andy Shevchenko
2020-08-16 11:59 ` Daniel Palmer
2020-08-19 18:19 ` Denis CIOCCA
2020-08-20 9:01 ` Jonathan Cameron
2020-08-20 9:17 ` Greg KH [this message]
2020-08-20 12:27 ` Daniel Palmer
2020-08-20 12:56 ` Andy Shevchenko
2020-08-20 12:34 ` Andy Shevchenko
2020-08-12 9:20 ` [RFC PATCH 0/2] iio: st-accel: Add support for Silan clones Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820091705.GA1122903@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel@0x0f.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mario.tesi@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).