[PATCH 1/2] dt-bindings: iio: dac: fix ad354xr output range

[PATCH 1/2] dt-bindings: iio: dac: fix ad354xr output range

[Angelo Dureghello]

From: Angelo Dureghello <adureghello@baylibre.com>

Fix output range, as per datasheet must be -2.5 to 7.5.

Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
---
 Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
index 96340a05754c..8265d709094d 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
@@ -139,7 +139,7 @@ allOf:
                 Voltage output range of the channel as <minimum, maximum>
                 Required connections:
                   Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
-                  Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
+                  Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
               oneOf:
                 - items:
                     - const: 0
-- 
2.44.0

Re: [PATCH 1/2] dt-bindings: iio: dac: fix ad354xr output range

[Angelo Dureghello]

Hi,

sorry, please consider this a s 1/1.

On 24/04/24 12:18 PM, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Fix output range, as per datasheet must be -2.5 to 7.5.
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
>   Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> index 96340a05754c..8265d709094d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> @@ -139,7 +139,7 @@ allOf:
>                   Voltage output range of the channel as <minimum, maximum>
>                   Required connections:
>                     Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
> -                  Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
> +                  Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
>                 oneOf:
>                   - items:
>                       - const: 0

Regards,
angelo

Re: [PATCH 1/2] dt-bindings: iio: dac: fix ad354xr output range

[Krzysztof Kozlowski]

On 24/04/2024 12:18, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Fix output range, as per datasheet must be -2.5 to 7.5.
> 
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

Code looks good though, but why opting out from testing? For that
reason: no acks.

Best regards,
Krzysztof