From: Anson Huang <anson.huang@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name
Date: Wed, 12 Dec 2018 12:49:11 +0000 [thread overview]
Message-ID: <96906A60-5318-46E5-B302-207C1FC7578B@nxp.com> (raw)
In-Reply-To: <CAOMZO5DXNpn18pzngmAt+hyiWNtfwckafxCzbJ17EgndjABwWg@mail.gmail.com>
Hi, Fabio
From Anson's iPhone 6
>
> We should not break existing dtbs, so in this case just keep the
> existing supply name and you could add the new optional vdda supply as
> per the datasheet.
Since the datasheet of isl29018 states the vdda and vddd MUST be shorted externally, and the later chips even remove vdda, ONLY has vdd one supply, so I think adding vdda does NOT make enough sense. Looks like the vcc they added is just for prepare, the driver did NOT support regulator operation at that time. So can we just use vcc in driver accordingly? Do we have to use the name “VDD” in datasheet for regulator name?
Anson.
next prev parent reply other threads:[~2018-12-12 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 7:11 [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name Anson Huang
2018-12-10 7:11 ` [PATCH V3 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support Anson Huang
2018-12-10 20:48 ` Jonathan Cameron
2018-12-10 23:23 ` [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name Rob Herring
2018-12-11 1:38 ` Anson Huang
2018-12-11 15:18 ` Rob Herring
2018-12-12 6:16 ` Anson Huang
2018-12-12 11:19 ` Fabio Estevam
2018-12-12 12:49 ` Anson Huang [this message]
2018-12-12 12:51 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96906A60-5318-46E5-B302-207C1FC7578B@nxp.com \
--to=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).