From: Rob Herring <robh@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name
Date: Tue, 11 Dec 2018 09:18:33 -0600 [thread overview]
Message-ID: <CAL_Jsq+sP_fsQaoT6FpZNRxjhPAhCcE8e-0xffUUxShcC2LuHw@mail.gmail.com> (raw)
In-Reply-To: <DB3PR0402MB3916E1651ABC07F6F788B265F5A60@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On Mon, Dec 10, 2018 at 7:40 PM Anson Huang <anson.huang@nxp.com> wrote:
>
> Hi, Rob
>
> Best Regards!
> Anson Huang
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: 2018年12月11日 7:24
> > To: Anson Huang <anson.huang@nxp.com>
> > Cc: jic23@kernel.org; knaack.h@gmx.de; lars@metafoo.de;
> > pmeerw@pmeerw.net; mark.rutland@arm.com; linux-iio@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> > <linux-imx@nxp.com>
> > Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
> > supply name
> >
> > On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote:
> > > According to datasheet, the isl29018 has "vddd/vdda" power supply, and
> > > isl29023/isl29035 ONLY has "vdd" power supply, update the power supply
> > > name with "vdd" and "vdda" according to datasheet to cover all devices
> > > and avoid confusion.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > index b9bbde3..36f737d 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > @@ -15,7 +15,9 @@ Optional properties:
> > > Refer to interrupt-controller/interrupts.txt for generic interrupt client
> > > node bindings.
> > >
> > > - - vcc-supply: phandle to the regulator that provides power to the sensor.
> > > + - vdd-supply: phandle to the regulator that provides vdd power to the
> > sensor.
> > > +
> > > + - vdda-supply: phandle to the regulator that provides vdda power to the
> > sensor.
> >
> > Is this in use? You can't just change things if it is.
>
> I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is NOT used at all,
> so I take this chance to update it according to datasheet. Thanks.
arch/arm/boot/dts/exynos5420-peach-pit.dts-629- light-sensor@44 {
arch/arm/boot/dts/exynos5420-peach-pit.dts:630: compatible =
"isil,isl29018";
arch/arm/boot/dts/exynos5420-peach-pit.dts-631- reg = <0x44>;
arch/arm/boot/dts/exynos5420-peach-pit.dts-632- vcc-supply =
<&tps65090_fet5>;
arch/arm/boot/dts/exynos5420-peach-pit.dts-633- };
arch/arm/boot/dts/exynos5800-peach-pi.dts-629- light-sensor@44 {
arch/arm/boot/dts/exynos5800-peach-pi.dts:630: compatible =
"isil,isl29018";
arch/arm/boot/dts/exynos5800-peach-pi.dts-631- reg = <0x44>;
arch/arm/boot/dts/exynos5800-peach-pi.dts-632- vcc-supply =
<&tps65090_fet5>;
arch/arm/boot/dts/exynos5800-peach-pi.dts-633- };
The rest of the dts files using this don't have a supply it seems. So
you need permission from the Exynos folks if you want to just drop
this. And also update their dts files.
Rob
next prev parent reply other threads:[~2018-12-11 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 7:11 [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name Anson Huang
2018-12-10 7:11 ` [PATCH V3 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support Anson Huang
2018-12-10 20:48 ` Jonathan Cameron
2018-12-10 23:23 ` [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name Rob Herring
2018-12-11 1:38 ` Anson Huang
2018-12-11 15:18 ` Rob Herring [this message]
2018-12-12 6:16 ` Anson Huang
2018-12-12 11:19 ` Fabio Estevam
2018-12-12 12:49 ` Anson Huang
2018-12-12 12:51 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+sP_fsQaoT6FpZNRxjhPAhCcE8e-0xffUUxShcC2LuHw@mail.gmail.com \
--to=robh@kernel.org \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).