From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"kartik.koolks@gmail.com" <kartik.koolks@gmail.com>
Subject: Re: problem with driver with driver name and version
Date: Mon, 22 Jul 2019 08:20:03 +0000 [thread overview]
Message-ID: <e90e62aac3db9cb1d9a9da473976f20f40ad49ee.camel@analog.com> (raw)
In-Reply-To: <CAMz8oh3q9OsyZN5F5SxWFttCgGfjW2jaszT1EN8TTtO-NHuO1w@mail.gmail.com>
On Sat, 2019-07-20 at 02:20 +0530, Kartik Kulkarni wrote:
> [External]
>
> Hello there,
> I wanted to patch the driver for ad7280a found at
> /opt/linux-kernel-dev/iio/drivers/staging/iio/adc and found a few
> anomalies which I felt needed to be asked before the patch was
> submitted.
>
> 1.
> ```
> tatic struct spi_driver ad7280_driver = {
> .driver = {
> .name = "ad7280",
Makes sense to rename this to "ad7280a", so feel free to send a patch just for this.
>
> ...
>
> ```
> the part of the device id says ad7280 instead of ad7280a which is the
> name of the driver file and looking at the Datasheet there's different
> datasheet for ad7280 and ad7280A and does not mention compatibility
> with each other.(I might be wrong but one had spi interface for 48
> channels and the other has spi interface for 300 channels so I think
> it might not be compatible)
>
> Note: The spi device id contains "ad7280a" and not "ad7280"
> QUESTION:
> Should I send a patch to correct the .compatible with ad7280a instead?
> as a different patch and send another patch which I am working on
> (about of_match which is not present) and add the of_match_array to
> contain the device "ad7280a"
The `of_match_table` patch should be it's own patch.
If you want a send a patch for this, the .compatible string should be "adi,ad7280a".
The `ad7280_id` table is correct.
>
> or is the file correct and I just send a patch about of_match_devices
> with "ad7280"
>
> Regards,
> Kartik Kulkarni
prev parent reply other threads:[~2019-07-22 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 20:50 problem with driver with driver name and version Kartik Kulkarni
2019-07-22 8:20 ` Ardelean, Alexandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e90e62aac3db9cb1d9a9da473976f20f40ad49ee.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=kartik.koolks@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).