Re: UPD: hid-multitouch: goodix: hovering works as touch

[Hans de Goede <hdegoede@redhat.com>]

Hi Dmitry,

On 4/16/21 9:16 AM, Dmitry Mastykin wrote:
> Hi Hans,
> 
> Of course I would like to put a pen patch to upstream, and ready to work for that.
> Have you taken a look to it? It's seems to be like a workaround. And it's difficult to say if pen button part of the patch will work fine with all gt7385p firmwares (sequence of tip, barrel and eraser is very tricky, but is it stable from version to version?)
> Should I rebase my patch, provide with comments and send the series to linux-input? Do you have any wishes how I could improve it before?

I'm not sure I'm the best person to answer that. Benjamin Tissoires knows the
HID multi-touch code much better then I do.

Benjamin can you please take a look at the 2 out of tree patches for this
and give some hints what needs to be done to make these suitable for
the mainline kernel?

The patches where attached to another email in this thread, for your
convenience I've put them here:

Pen support (patch 1/2):
https://fedorapeople.org/~jwrdegoede/commit-b7ee3d7

Buttons on pen support (patch 2/2)
https://fedorapeople.org/~jwrdegoede/commit-530201a

Regards,

Hans



> On 4/15/21 7:02 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 4/15/21 3:33 PM, Vitaly Minko wrote:
>>> Hello Dmitry,
>>>
>>>
>>> I have tested your patches on the kernel version 5.10.27. I had to add one define for I2C_DEVICE_ID_GOODIX_0113. Everything else was applied successfully.
>>>
>>> The digitizer works fine now. So the original issue is solved. Both pen buttons also work as expected (right and middle mouse buttons).
>>>
>>> All tests performed on One-Netbook A1.
>>>
>>> Thanks a lot for your efforts. Could you please send me a private email with your credentials for sending a tip (I would like to buy you a coffee).
>>
>> Although it is nice that these patches fix things for you, I wonder if there
>> is any plan to get the fixes for this upstream, so that once distros jump
>> to a newer kernel this will just work out of the box for all Linux users ?
>>
>> Regards,
>>
>> Hans
>>
>>
>>
>>
>>> 15.04.2021 10:13, Dmitry Mastykin wrote:
>>>> Hi Vitaly,
>>>>
>>>> Yes, we made a quirk for separate non-multitouch processing of the HID_DG_PEN application for Goodix gt7385p (I2C_DEVICE_ID_GOODIX_0113 == 0x0113). It works well, BTN_TOOL_PEN and BTN_TOUCH events have right order.
>>>> I attach patches for kernel 5.4
>>>> Buttons support was very tricky, because the panel tries to imitate eraser usage with combination of tip's and eraser's bits off and on, seems that Windows driver needs this. In second patch we add state-machines for pen buttons to simulate right and middle click. It works also well with this panel/pen, but I'm not sure if it works with other devices.
>>>>
>>>> Kind regards,
>>>> Dmitry Mastykin
>>>>
>>>>
>>>> On 4/14/21 6:35 PM, Vitaly Minko wrote:
>>>>> Hello Dmitry,
>>>>>
>>>>>
>>>>> I have faced with exactly the same problem. Have you managed to solve the issue?
>>>>>
>>>>> If yes, could you please share the patch?
>>>>>
>>>>> Thanks in advance!
>>>>>
>>>>>
>>>>> Best regards,
>>>>>
>>>>> Vitaly
>>>>>
>>>
>>
>