From: Alexander Sosedkin <monk@unboiled.info>
To: Dmitry Mastykin <dmastykin@astralinux.ru>,
linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Daniele Gobbetti <daniele@gobbetti.name>,
Vitaly Minko <vitaly@minko.me>
Subject: Re: UPD: hid-multitouch: goodix: hovering works as touch
Date: Thu, 10 Jun 2021 02:59:03 +0200 [thread overview]
Message-ID: <a84aa67c-16b8-27c2-e1a2-e497314efc4b@unboiled.info> (raw)
In-Reply-To: <7b7af64e-8e70-3a9c-eee9-010574adc241@astralinux.ru>
On 4/15/21 9:13 AM, Dmitry Mastykin wrote:
> Hi Vitaly,
>
> Yes, we made a quirk for separate non-multitouch processing of the
> HID_DG_PEN application for Goodix gt7385p (I2C_DEVICE_ID_GOODIX_0113 ==
> 0x0113). It works well, BTN_TOOL_PEN and BTN_TOUCH events have right order.
> I attach patches for kernel 5.4
> Buttons support was very tricky, because the panel tries to imitate
> eraser usage with combination of tip's and eraser's bits off and on,
> seems that Windows driver needs this. In second patch we add
> state-machines for pen buttons to simulate right and middle click. It
> works also well with this panel/pen, but I'm not sure if it works with
> other devices.
>
> Kind regards,
> Dmitry Mastykin
These patches have solved the same problem for my OneNetbook 4's
"GXTP7386:00 27C6:011A Stylus" manifesting the same symptoms.
I just had to replace the device ID from 0x0113 to 0x011A.
Tested on 5.12.4 and 5.12.7.
It'd be nice to see these fixes extended and upstreamed one day.
Dmitry, thanks for putting work into this.
Benjamin, would you kindly take a look at this submission?
prev parent reply other threads:[~2021-06-10 1:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 16:23 hid-multitouch: goodix: hovering works as touch Dmitry Mastykin
2020-07-31 13:07 ` UPD: " Dmitry Mastykin
2021-04-14 15:35 ` Vitaly Minko
2021-04-15 7:13 ` Dmitry Mastykin
2021-04-15 13:33 ` Vitaly Minko
2021-04-15 16:02 ` Hans de Goede
2021-04-16 7:16 ` Dmitry Mastykin
2021-04-16 14:43 ` Hans de Goede
2021-06-10 0:59 ` Alexander Sosedkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84aa67c-16b8-27c2-e1a2-e497314efc4b@unboiled.info \
--to=monk@unboiled.info \
--cc=benjamin.tissoires@redhat.com \
--cc=daniele@gobbetti.name \
--cc=dmastykin@astralinux.ru \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=vitaly@minko.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).