* [PATCH 1/2] Input: Add keycodes for keyboard backlight control
@ 2020-03-03 0:56 Rajat Jain
2020-03-03 0:56 ` [PATCH 2/2] Input: Allocate keycode for SNIP key Rajat Jain
2020-03-03 8:15 ` [PATCH 1/2] Input: Add keycodes for keyboard backlight control Bastien Nocera
0 siblings, 2 replies; 4+ messages in thread
From: Rajat Jain @ 2020-03-03 0:56 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input, linux-kernel, dtor; +Cc: Rajat Jain, rajatxjain
New keyboards can have backlight control keys. Allocating keycodes
for them. Such keyboards are already available in ChromeOS.
Signed-off-by: Rajat Jain <rajatja@google.com>
---
include/uapi/linux/input-event-codes.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 0f1db1cccc3fd..e12a19dc30262 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -652,6 +652,10 @@
/* Electronic privacy screen control */
#define KEY_PRIVACY_SCREEN_TOGGLE 0x279
+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP 0x280
+#define KEY_KBD_BKLIGHT_DOWN 0x281
+
/*
* Some keyboards have keys which do not have a defined meaning, these keys
* are intended to be programmed / bound to macros by the user. For most
--
2.25.0.265.gbab2e86ba0-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] Input: Allocate keycode for SNIP key
2020-03-03 0:56 [PATCH 1/2] Input: Add keycodes for keyboard backlight control Rajat Jain
@ 2020-03-03 0:56 ` Rajat Jain
2020-03-03 8:15 ` [PATCH 1/2] Input: Add keycodes for keyboard backlight control Bastien Nocera
1 sibling, 0 replies; 4+ messages in thread
From: Rajat Jain @ 2020-03-03 0:56 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input, linux-kernel, dtor; +Cc: Rajat Jain, rajatxjain
New chromeos keyboards have a "snip" key that is basically a selective
screenshot (allows a user to select an area of screen to be copied).
Allocate a keyvode for it.
Signed-off-by: Rajat Jain <rajatja@google.com>
---
include/uapi/linux/input-event-codes.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index e12a19dc30262..51f419657d044 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -656,6 +656,9 @@
#define KEY_KBD_BKLIGHT_UP 0x280
#define KEY_KBD_BKLIGHT_DOWN 0x281
+/* Selective Screenshot */
+#define KEY_SNIP 0x282
+
/*
* Some keyboards have keys which do not have a defined meaning, these keys
* are intended to be programmed / bound to macros by the user. For most
--
2.25.0.265.gbab2e86ba0-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Input: Add keycodes for keyboard backlight control
2020-03-03 0:56 [PATCH 1/2] Input: Add keycodes for keyboard backlight control Rajat Jain
2020-03-03 0:56 ` [PATCH 2/2] Input: Allocate keycode for SNIP key Rajat Jain
@ 2020-03-03 8:15 ` Bastien Nocera
2020-03-03 23:59 ` Rajat Jain
1 sibling, 1 reply; 4+ messages in thread
From: Bastien Nocera @ 2020-03-03 8:15 UTC (permalink / raw)
To: Rajat Jain, Dmitry Torokhov, linux-input, linux-kernel, dtor; +Cc: rajatxjain
On Mon, 2020-03-02 at 16:56 -0800, Rajat Jain wrote:
> New keyboards can have backlight control keys. Allocating keycodes
> for them. Such keyboards are already available in ChromeOS.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> include/uapi/linux/input-event-codes.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h
> b/include/uapi/linux/input-event-codes.h
> index 0f1db1cccc3fd..e12a19dc30262 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -652,6 +652,10 @@
> /* Electronic privacy screen control */
> #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
>
> +/* Keyboard Backlight control */
> +#define KEY_KBD_BKLIGHT_UP 0x280
> +#define KEY_KBD_BKLIGHT_DOWN 0x281
There's already KEY_KBDILLUMDOWN and KEY_KBDILLUMUP, used since the
aluminium PowerBook G4 in 2005 (commit
146a4b3bdfb5641bfbf975e29680b482b8b343ba)
> +
> /*
> * Some keyboards have keys which do not have a defined meaning,
> these keys
> * are intended to be programmed / bound to macros by the user. For
> most
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Input: Add keycodes for keyboard backlight control
2020-03-03 8:15 ` [PATCH 1/2] Input: Add keycodes for keyboard backlight control Bastien Nocera
@ 2020-03-03 23:59 ` Rajat Jain
0 siblings, 0 replies; 4+ messages in thread
From: Rajat Jain @ 2020-03-03 23:59 UTC (permalink / raw)
To: Bastien Nocera
Cc: Dmitry Torokhov, linux-input, Linux Kernel Mailing List,
Dmitry Torokhov, Rajat Jain
On Tue, Mar 3, 2020 at 12:15 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Mon, 2020-03-02 at 16:56 -0800, Rajat Jain wrote:
> > New keyboards can have backlight control keys. Allocating keycodes
> > for them. Such keyboards are already available in ChromeOS.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
> > ---
> > include/uapi/linux/input-event-codes.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/include/uapi/linux/input-event-codes.h
> > b/include/uapi/linux/input-event-codes.h
> > index 0f1db1cccc3fd..e12a19dc30262 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -652,6 +652,10 @@
> > /* Electronic privacy screen control */
> > #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
> >
> > +/* Keyboard Backlight control */
> > +#define KEY_KBD_BKLIGHT_UP 0x280
> > +#define KEY_KBD_BKLIGHT_DOWN 0x281
>
> There's already KEY_KBDILLUMDOWN and KEY_KBDILLUMUP, used since the
> aluminium PowerBook G4 in 2005 (commit
> 146a4b3bdfb5641bfbf975e29680b482b8b343ba)
Thank you for pointing out. Yes, I think those key codes will work for
me. I will use those instead.
Please consider this patch withdrawn.
Thanks & Best Regards,
Rajat Jain
>
> > +
> > /*
> > * Some keyboards have keys which do not have a defined meaning,
> > these keys
> > * are intended to be programmed / bound to macros by the user. For
> > most
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-03 23:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 0:56 [PATCH 1/2] Input: Add keycodes for keyboard backlight control Rajat Jain
2020-03-03 0:56 ` [PATCH 2/2] Input: Allocate keycode for SNIP key Rajat Jain
2020-03-03 8:15 ` [PATCH 1/2] Input: Add keycodes for keyboard backlight control Bastien Nocera
2020-03-03 23:59 ` Rajat Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).