From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Johnny Chuang <johnny.chuang.emc@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624
Date: Fri, 11 Dec 2020 17:38:01 +0100 [thread overview]
Message-ID: <20201211163801.GB23095@qmqm.qmqm.pl> (raw)
In-Reply-To: <X9MeISZqBcvcnYXe@google.com>
On Thu, Dec 10, 2020 at 11:22:09PM -0800, Dmitry Torokhov wrote:
> Hi Michał,
>
> On Fri, Dec 11, 2020 at 07:53:56AM +0100, Michał Mirosław wrote:
> > +
> > + if (!phy_x || !phy_y) {
> > + dev_warn(&client->dev,
> > + "invalid size data: %d x %d mm\n",
> > + phy_x, phy_y);
> > + return 0;
>
> Given we are not treating this as hard error mind dropping this "return"
> and making the below an "else" branch?
It is an error, still, and saves a bit of indentation in the following
normal-path code. But I see that there is already a similar code with
an 'else' branch.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2020-12-11 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 6:53 [PATCH RESEND v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens Michał Mirosław
2020-12-11 6:53 ` [PATCH RESEND v8 2/4] input: elants: support old touch report format Michał Mirosław
2020-12-11 7:29 ` Dmitry Torokhov
2020-12-11 16:09 ` Michał Mirosław
2020-12-11 16:39 ` Dmitry Osipenko
2020-12-11 17:04 ` Michał Mirosław
2020-12-11 18:48 ` Dmitry Torokhov
2021-01-07 22:06 ` Dmitry Osipenko
2021-01-22 20:10 ` Dmitry Osipenko
2021-01-22 22:37 ` Michał Mirosław
2021-01-23 14:07 ` Dmitry Osipenko
2020-12-11 6:53 ` [PATCH RESEND v8 1/4] input: elants: document some registers and values Michał Mirosław
2020-12-11 7:11 ` Dmitry Torokhov
2020-12-11 6:53 ` [PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624 Michał Mirosław
2020-12-11 7:22 ` Dmitry Torokhov
2020-12-11 16:38 ` Michał Mirosław [this message]
2020-12-11 6:53 ` [PATCH RESEND v8 4/4] input: elants: support 0x66 reply opcode for reporting touches Michał Mirosław
2020-12-11 7:36 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2020-11-09 17:28 [PATCH RESEND v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens Michał Mirosław
2020-11-09 17:28 ` [PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624 Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211163801.GB23095@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=digetx@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=johnny.chuang.emc@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).