From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Johnny Chuang <johnny.chuang.emc@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v8 2/4] input: elants: support old touch report format
Date: Thu, 10 Dec 2020 23:29:40 -0800 [thread overview]
Message-ID: <X9Mf5G6yvIEAoh2C@google.com> (raw)
In-Reply-To: <a5c0b6b300fadf9425781285351b46c6dbb4f618.1607669375.git.mirq-linux@rere.qmqm.pl>
Hi Michał,
On Fri, Dec 11, 2020 at 07:53:56AM +0100, Michał Mirosław wrote:
> @@ -998,17 +1011,18 @@ static irqreturn_t elants_i2c_irq(int irq, void *_dev)
> }
>
> report_len = ts->buf[FW_HDR_LENGTH] / report_count;
> - if (report_len != PACKET_SIZE) {
> + if (report_len != PACKET_SIZE &&
> + report_len != PACKET_SIZE_OLD) {
> dev_err(&client->dev,
> - "mismatching report length: %*ph\n",
> + "unsupported report length: %*ph\n",
> HEADER_SIZE, ts->buf);
Do I understand this correctly that the old packets are only observed on
EKTF3624? If so can we expand the check so that we only accept packets
with "old" size when we know we are dealing with this device?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-12-11 7:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 6:53 [PATCH RESEND v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens Michał Mirosław
2020-12-11 6:53 ` [PATCH RESEND v8 2/4] input: elants: support old touch report format Michał Mirosław
2020-12-11 7:29 ` Dmitry Torokhov [this message]
2020-12-11 16:09 ` Michał Mirosław
2020-12-11 16:39 ` Dmitry Osipenko
2020-12-11 17:04 ` Michał Mirosław
2020-12-11 18:48 ` Dmitry Torokhov
2021-01-07 22:06 ` Dmitry Osipenko
2021-01-22 20:10 ` Dmitry Osipenko
2021-01-22 22:37 ` Michał Mirosław
2021-01-23 14:07 ` Dmitry Osipenko
2020-12-11 6:53 ` [PATCH RESEND v8 1/4] input: elants: document some registers and values Michał Mirosław
2020-12-11 7:11 ` Dmitry Torokhov
2020-12-11 6:53 ` [PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624 Michał Mirosław
2020-12-11 7:22 ` Dmitry Torokhov
2020-12-11 16:38 ` Michał Mirosław
2020-12-11 6:53 ` [PATCH RESEND v8 4/4] input: elants: support 0x66 reply opcode for reporting touches Michał Mirosław
2020-12-11 7:36 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2020-11-09 17:28 [PATCH RESEND v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens Michał Mirosław
2020-11-09 17:28 ` [PATCH RESEND v8 2/4] input: elants: support old touch report format Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9Mf5G6yvIEAoh2C@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=digetx@gmail.com \
--cc=johnny.chuang.emc@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).