From: "Wang, Jiada" <jiada_wang@mentor.com>
To: Dmitry Osipenko <digetx@gmail.com>, <jikos@kernel.org>,
<benjamin.tissoires@redhat.com>, <rydberg@bitmath.org>,
<dmitry.torokhov@gmail.com>, <nick@shmanahar.org>,
<bsz@semihalf.com>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<erosca@de.adit-jv.com>, <Andrew_Gabbasov@mentor.com>
Subject: Re: [PATCH v7 00/48] atmel_mxt_ts misc
Date: Mon, 16 Mar 2020 15:50:30 +0900 [thread overview]
Message-ID: <caf51d41-07d0-37db-e19c-d8e2594349ae@mentor.com> (raw)
In-Reply-To: <c583d151-9243-cbde-a04b-bc0389d9be5a@gmail.com>
Hello Dmitry
On 2020/03/13 0:21, Dmitry Osipenko wrote:
> 12.02.2020 11:41, Jiada Wang пишет:
>> This patch-set forward ports Nick Dyer's work in ndyer/linux github repository
>> as long as some other features and fixes
>>
>> Balasubramani Vivekanandan (2):
>> Input: atmel_mxt_ts: Limit the max bytes transferred in an i2c
>> transaction
>> Input: atmel_mxt_ts: use gpiod_set_value_cansleep for reset pin
>>
>> Dean Jenkins (1):
>> Input: atmel_mxt_ts: return error from
>> mxt_process_messages_until_invalid()
>>
>> Deepak Das (6):
>> Input: Atmel: improve error handling in mxt_start()
>> Input: Atmel: improve error handling in mxt_initialize()
>> Input: Atmel: improve error handling in mxt_update_cfg()
>> Input: Atmel: Improve error handling in mxt_initialize_input_device()
>> Input: Atmel: handle ReportID "0x00" while processing T5 messages
>> Input: Atmel: use T44 object to process T5 messages
>>
>> George G. Davis (1):
>> input: atmel_mxt_ts: export GPIO reset line via sysfs
>>
>> Jiada Wang (3):
>> Input: introduce input_mt_report_slot_inactive
>> Input: atmel_mxt_ts - eliminate data->raw_info_block
>> Input: atmel_mxt_ts - Fix compilation warning
>>
>> Karl Tsou (1):
>> Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msgs
>>
>> Kautuk Consul (2):
>> Input: atmel_mxt_ts - Change call-points of mxt_free_* functions
>> Input: atmel_mxt_ts - rely on calculated_crc rather than file
>> config_crc
>>
>> Naveen Chakka (2):
>> input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen
>> status
>> input: atmel_mxt_ts: added sysfs interface to update atmel T38 data
>>
>> Nick Dyer (26):
>> Input: atmel_mxt_ts - rework sysfs init/remove
>> Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when
>> necessary
>> Input: atmel_mxt_ts - split large i2c transfers into blocks
>> Input: atmel_mxt_ts - output status from T48 Noise Supression
>> Input: atmel_mxt_ts - output status from T42 Touch Suppression
>> Input: atmel_mxt_ts - implement T9 vector/orientation support
>> Input: atmel_mxt_ts - implement T15 Key Array support
>> Input: atmel_mxt_ts - handle reports from T47 Stylus object
>> Input: atmel_mxt_ts - implement support for T107 active stylus
>> Input: atmel_mxt_ts - release touch state during suspend
>> Input: atmel_mxt_ts - add regulator control support
>> Input: atmel_mxt_ts - report failures in suspend/resume
>> Input: atmel_mxt_ts - allow specification of firmware file name
>> Input: atmel_mxt_ts - handle cfg filename via pdata/sysfs
>> Input: atmel_mxt_ts - allow input name to be specified in platform
>> data
>> Input: atmel_mxt_ts - refactor firmware flash to extract context into
>> struct
>> Input: atmel_mxt_ts - refactor code to enter bootloader into separate
>> func
>> Input: atmel_mxt_ts - combine bootloader version query with probe
>> Input: atmel_mxt_ts - improve bootloader state machine handling
>> Input: atmel_mxt_ts - rename bl_completion to chg_completion
>> Input: atmel_mxt_ts - make bootloader interrupt driven
>> Input: atmel_mxt_ts - delay enabling IRQ when not using regulators
>> Input: atmel_mxt_ts - implement I2C retries
>> Input: atmel_mxt_ts - orientation is not present in hover
>> Input: atmel_mxt_ts - implement debug output for messages
>> Input: atmel_mxt_ts - implement improved debug message interface
>>
>> Nikhil Ravindran (1):
>> Input: atmel_mxt_ts: Add support for run self-test routine.
>>
>> Sanjeev Chugh (1):
>> Input: atmel_mxt_ts: Implement synchronization during various
>> operation
>>
>> karl tsou (1):
>> Input: atmel_mxt_ts - add config checksum attribute to sysfs
>>
>> keerthikumarp (1):
>> input: atmel_mxt_ts: Add Missing Delay for reset handling of Atmel
>> touch panel controller in detachable displays.
>>
>> ---
>> v7:
>> Fix regression found when updating firmware
>> Following commits have been updated to fix regression found when
>> updating firmware
>> Input: atmel_mxt_ts - improve bootloader state machine handling
>> Input: atmel_mxt_ts - make bootloader interrupt driven
>> input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen status
>> Input: atmel_mxt_ts: Implement synchronization during various operation
>>
>> v6:
>> Fix issue in commit ("Input: introduce input_mt_report_slot_inactive")
>> reported by kernel test robot
>>
>> v5:
>> Following commits have been updated to address warnings & errors
>> reported by kbuild test robot
>> Input: atmel_mxt_ts - make bootloader interrupt driven
>> Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msgs
>>
>> Following commit has been updated
>> Input: introduce input_mt_report_slot_inactive
>>
>> v4:
>> Following commit in v3 patch-set has been removed
>> Input: switch to use return value of input_mt_report_slot_state
>>
>> Following commit has been updated to address checkpatch warning
>> Input: atmel_mxt_ts: Implement synchronization during various operation
>>
>> v3:
>> Following commits have been updated compared to v2 patchset
>> Input: atmel_mxt_ts - implement debug output for messages
>> - added inline comment
>> Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msg
>> - changed dev_info() to dev_dbg()
>>
>> v2:
>> Following commit in v1 patchset has been split into two commits
>> Input: introduce input_mt_report_slot_inactive
>>
>> Following commits have been updated compared to v1 patchset
>> Input: atmel_mxt_ts - split large i2c transfers into blocks
>> Input: atmel_mxt_ts - output status from T42 Touch Suppression
>>
>> Following commits in v1 patchset have been squashed
>> Input: touchscreen: Atmel: Add device tree support for T15 key array
>> objects
>> Input: atmel_mxt_ts - check data->input_dev is not null in
>> mxt_input_sync()
>> Input: atmel_mxt_ts - check firmware format before entering bootloader
>> Input: atmel_mxt_ts: update stale use_retrigen_workaround flag
>> input: atmel_mxt_ts: move bootloader probe from mxt_initialize()
>> input: Atmel: limit the max bytes transferred while reading T5 messages
>> Input: atmel_mxt_ts: Use msecs_to_jiffies() instead of HZ
>> Input: atmel_mxt_ts: Use complete when in_bootloader true
>> Input: atmel_mxt_ts: Prevent crash due to freeing of input device
>> input: atmel_mxt_ts: Add NULL check for sysfs attribute debug_msg_attr
>>
>> Following commits in v1 patchset have been dropped:
>> Input: atmel_mxt_ts - configure and use gpios as real gpios
>> Input: touchscreen: Atmel: Enable IRQ_DISABLE_UNLAZY flag for interrupt
>> Input: atmel_mxt_ts - add memory access interface via sysfs
>> Input: atmel_mxt_ts: Remove sysfs attributes during driver detach
>> Input: atmel_mxt_ts: Avoid race condition in freeing of input device
>>
>>
>> v1: initial version
>> ---
>> .../bindings/input/atmel,maxtouch.txt | 14 +
>> MAINTAINERS | 1 +
>> drivers/hid/hid-alps.c | 3 +-
>> drivers/hid/hid-multitouch.c | 6 +-
>> drivers/input/misc/xen-kbdfront.c | 2 +-
>> drivers/input/mouse/elan_i2c_core.c | 2 +-
>> drivers/input/touchscreen/atmel_mxt_ts.c | 2270 ++++++++++++++---
>> drivers/input/touchscreen/cyttsp4_core.c | 5 +-
>> drivers/input/touchscreen/cyttsp_core.c | 2 +-
>> drivers/input/touchscreen/melfas_mip4.c | 4 +-
>> drivers/input/touchscreen/mms114.c | 2 +-
>> drivers/input/touchscreen/raspberrypi-ts.c | 2 +-
>> drivers/input/touchscreen/stmfts.c | 2 +-
>> include/dt-bindings/input/atmel_mxt_ts.h | 22 +
>> include/linux/input/mt.h | 5 +
>> 15 files changed, 1985 insertions(+), 357 deletions(-)
>> create mode 100644 include/dt-bindings/input/atmel_mxt_ts.h
>>
>
> Hello Jiada,
>
> Please run all the patches through `scripts/checkpatch.pl --strict` and
> fix all the reported problems.
>
Thanks, I will try to address checkpatch issues in v8 patch-set
Thanks,
Jiada
> Otherwise this is a very good series, it makes MXT1386 to work because
> I2C retying is indeed required for that controller.
>
next prev parent reply other threads:[~2020-03-16 6:50 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:41 [PATCH v7 00/48] atmel_mxt_ts misc Jiada Wang
2020-02-12 8:41 ` [PATCH v7 01/48] Input: introduce input_mt_report_slot_inactive Jiada Wang
2020-02-12 8:41 ` [PATCH v7 02/48] Input: atmel_mxt_ts - rework sysfs init/remove Jiada Wang
2020-02-12 8:41 ` [PATCH v7 03/48] Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when necessary Jiada Wang
2020-03-17 22:44 ` Dmitry Osipenko
2020-03-18 13:02 ` Wang, Jiada
2020-02-12 8:41 ` [PATCH v7 04/48] Input: atmel_mxt_ts - split large i2c transfers into blocks Jiada Wang
2020-02-12 8:41 ` [PATCH v7 05/48] Input: atmel_mxt_ts - output status from T48 Noise Supression Jiada Wang
2020-02-12 8:41 ` [PATCH v7 06/48] Input: atmel_mxt_ts - output status from T42 Touch Suppression Jiada Wang
2020-02-12 8:41 ` [PATCH v7 07/48] Input: atmel_mxt_ts - implement T9 vector/orientation support Jiada Wang
2020-02-12 8:41 ` [PATCH v7 08/48] Input: atmel_mxt_ts - implement T15 Key Array support Jiada Wang
2020-02-12 8:41 ` [PATCH v7 09/48] Input: atmel_mxt_ts - handle reports from T47 Stylus object Jiada Wang
2020-02-12 8:41 ` [PATCH v7 10/48] Input: atmel_mxt_ts - implement support for T107 active stylus Jiada Wang
2020-02-12 8:41 ` [PATCH v7 11/48] Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msgs Jiada Wang
2020-02-12 8:41 ` [PATCH v7 12/48] Input: atmel_mxt_ts - release touch state during suspend Jiada Wang
2020-02-12 8:41 ` [PATCH v7 13/48] Input: atmel_mxt_ts - add regulator control support Jiada Wang
2020-03-12 15:26 ` Dmitry Osipenko
2020-02-12 8:41 ` [PATCH v7 14/48] Input: atmel_mxt_ts - report failures in suspend/resume Jiada Wang
2020-02-12 8:41 ` [PATCH v7 15/48] Input: atmel_mxt_ts - allow specification of firmware file name Jiada Wang
2020-02-12 8:41 ` [PATCH v7 16/48] Input: atmel_mxt_ts - handle cfg filename via pdata/sysfs Jiada Wang
2020-02-12 8:41 ` [PATCH v7 17/48] Input: atmel_mxt_ts - allow input name to be specified in platform data Jiada Wang
2020-02-12 8:41 ` [PATCH v7 18/48] Input: atmel_mxt_ts - add config checksum attribute to sysfs Jiada Wang
2020-02-12 8:41 ` [PATCH v7 19/48] Input: atmel_mxt_ts - refactor firmware flash to extract context into struct Jiada Wang
2020-02-12 8:41 ` [PATCH v7 20/48] Input: atmel_mxt_ts - refactor code to enter bootloader into separate func Jiada Wang
2020-02-12 8:41 ` [PATCH v7 21/48] Input: atmel_mxt_ts - combine bootloader version query with probe Jiada Wang
2020-02-12 8:41 ` [PATCH v7 22/48] Input: atmel_mxt_ts - improve bootloader state machine handling Jiada Wang
2020-03-12 15:28 ` Dmitry Osipenko
2020-02-12 8:41 ` [PATCH v7 23/48] Input: atmel_mxt_ts - rename bl_completion to chg_completion Jiada Wang
2020-02-12 8:41 ` [PATCH v7 24/48] Input: atmel_mxt_ts - make bootloader interrupt driven Jiada Wang
2020-02-12 8:41 ` [PATCH v7 25/48] Input: atmel_mxt_ts - delay enabling IRQ when not using regulators Jiada Wang
2020-02-12 8:41 ` [PATCH v7 26/48] Input: atmel_mxt_ts - implement I2C retries Jiada Wang
2020-02-12 8:41 ` [PATCH v7 27/48] Input: atmel_mxt_ts - orientation is not present in hover Jiada Wang
2020-02-12 8:41 ` [PATCH v7 28/48] Input: atmel_mxt_ts - implement debug output for messages Jiada Wang
2020-02-12 8:41 ` [PATCH v7 29/48] Input: atmel_mxt_ts - implement improved debug message interface Jiada Wang
2020-02-12 8:42 ` [PATCH v7 30/48] Input: atmel_mxt_ts - eliminate data->raw_info_block Jiada Wang
2020-02-12 8:42 ` [PATCH v7 31/48] Input: atmel_mxt_ts - Change call-points of mxt_free_* functions Jiada Wang
2020-02-12 8:42 ` [PATCH v7 32/48] Input: atmel_mxt_ts - rely on calculated_crc rather than file config_crc Jiada Wang
2020-02-12 8:42 ` [PATCH v7 33/48] input: atmel_mxt_ts: export GPIO reset line via sysfs Jiada Wang
2020-02-12 8:42 ` [PATCH v7 34/48] input: atmel_mxt_ts: Add Missing Delay for reset handling of Atmel touch panel controller in detachable displays Jiada Wang
2020-02-12 8:42 ` [PATCH v7 35/48] Input: atmel_mxt_ts: Add support for run self-test routine Jiada Wang
2020-02-12 8:42 ` [PATCH v7 36/48] Input: atmel_mxt_ts: Limit the max bytes transferred in an i2c transaction Jiada Wang
2020-02-12 8:42 ` [PATCH v7 37/48] Input: atmel_mxt_ts: return error from mxt_process_messages_until_invalid() Jiada Wang
2020-02-12 8:42 ` [PATCH v7 38/48] Input: Atmel: improve error handling in mxt_start() Jiada Wang
2020-02-12 8:42 ` [PATCH v7 39/48] Input: Atmel: improve error handling in mxt_initialize() Jiada Wang
2020-02-12 8:42 ` [PATCH v7 40/48] Input: Atmel: improve error handling in mxt_update_cfg() Jiada Wang
2020-02-12 8:42 ` [PATCH v7 41/48] Input: Atmel: Improve error handling in mxt_initialize_input_device() Jiada Wang
2020-02-12 8:42 ` [PATCH v7 42/48] Input: Atmel: handle ReportID "0x00" while processing T5 messages Jiada Wang
2020-02-12 8:42 ` [PATCH v7 43/48] Input: Atmel: use T44 object to process " Jiada Wang
2020-02-12 8:42 ` [PATCH v7 44/48] Input: atmel_mxt_ts: use gpiod_set_value_cansleep for reset pin Jiada Wang
2020-02-12 8:42 ` [PATCH v7 45/48] input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen status Jiada Wang
2020-02-12 8:42 ` [PATCH v7 46/48] input: atmel_mxt_ts: added sysfs interface to update atmel T38 data Jiada Wang
2020-02-12 8:42 ` [PATCH v7 47/48] Input: atmel_mxt_ts: Implement synchronization during various operation Jiada Wang
2020-02-12 8:42 ` [PATCH v7 48/48] Input: atmel_mxt_ts - Fix compilation warning Jiada Wang
2020-03-11 1:09 ` [PATCH v7 00/48] atmel_mxt_ts misc Wang, Jiada
2020-03-12 15:21 ` Dmitry Osipenko
2020-03-16 6:50 ` Wang, Jiada [this message]
2020-03-20 3:37 ` Wang, Jiada
2020-03-20 15:53 ` Dmitry Osipenko
2020-03-23 2:25 ` Wang, Jiada
2020-03-24 14:54 ` Dmitry Osipenko
2020-03-24 15:03 ` Dmitry Osipenko
2020-03-25 12:13 ` Wang, Jiada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf51d41-07d0-37db-e19c-d8e2594349ae@mentor.com \
--to=jiada_wang@mentor.com \
--cc=Andrew_Gabbasov@mentor.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bsz@semihalf.com \
--cc=digetx@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).