From: "Filipe Laíns" <lains@archlinux.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Peter Hutterer <peter.hutterer@who-t.net>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Harry Cutts <hcutts@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages
Date: Mon, 06 Jul 2020 14:03:31 +0100 [thread overview]
Message-ID: <d462f3dc038548b09ced1a42973d767390e29635.camel@archlinux.org> (raw)
In-Reply-To: <6202799b-f887-a867-94b3-915607956ceb@maciej.szmigiero.name>
[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]
On Mon, 2020-07-06 at 14:41 +0200, Maciej S. Szmigiero wrote:
> On 06.07.2020 14:38, Filipe Laíns wrote:
> > On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
> > > These messages appear each time the mouse wakes from sleep, in my
> > > case
> > > (Logitech M705), every minute or so.
> > > Let's downgrade them to the "debug" level so they don't fill the
> > > kernel log
> > > by default.
> > >
> > > While we are at it, let's make clear that this is a wheel multiplier
> > > (and
> > > not, for example, XY movement multiplier).
> > >
> > > Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling
> > > on Logitech mice")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> > > ---
> > > Sending again since the previous message bounced for most recipients.
> > >
> > > drivers/hid/hid-logitech-hidpp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> > > logitech-hidpp.c
> > > index 1e1cf8eae649..b8b53dc95e86 100644
> > > --- a/drivers/hid/hid-logitech-hidpp.c
> > > +++ b/drivers/hid/hid-logitech-hidpp.c
> > > @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct
> > > hidpp_device *hidpp)
> > > multiplier = 1;
> > >
> > > hidpp->vertical_wheel_counter.wheel_multiplier = multiplier;
> > > - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier);
> > > + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);
> > > return 0;
> > > }
> > >
> >
> > I have seen this being useful in some cases, however I do not have a
> > strong opinion on it. Peter would know better.
>
> Well, the message is not being removed, only hidden by default, so
> it doesn't fill the kernel log.
>
> One can still enable it at runtime if wanted.
Of course, but instructing users to do that can be annoying, especially
when you're handling a considerable volume of reports.
Anyway, I am fine with this patch, I just thought it was pertinent to
raise this point and maybe get Peter's input on this, as he will likely
be one most affected by it :)
Filipe Laíns
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-06 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 17:34 [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages Maciej S. Szmigiero
2020-07-06 12:38 ` Filipe Laíns
2020-07-06 12:41 ` Maciej S. Szmigiero
2020-07-06 13:03 ` Filipe Laíns [this message]
2020-07-07 10:40 ` Jiri Kosina
[not found] <7d2c980f071487cecfd1534adb7561b33d922af3.1593968925.git.mail@maciej.szmigiero.name>
2020-07-06 18:35 ` Harry Cutts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d462f3dc038548b09ced1a42973d767390e29635.camel@archlinux.org \
--to=lains@archlinux.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hcutts@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).