* [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages @ 2020-07-05 17:34 Maciej S. Szmigiero 2020-07-06 12:38 ` Filipe Laíns 2020-07-07 10:40 ` Jiri Kosina 0 siblings, 2 replies; 6+ messages in thread From: Maciej S. Szmigiero @ 2020-07-05 17:34 UTC (permalink / raw) To: Jiri Kosina, Benjamin Tissoires Cc: Harry Cutts, Peter Hutterer, linux-input, linux-kernel These messages appear each time the mouse wakes from sleep, in my case (Logitech M705), every minute or so. Let's downgrade them to the "debug" level so they don't fill the kernel log by default. While we are at it, let's make clear that this is a wheel multiplier (and not, for example, XY movement multiplier). Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice") Cc: stable@vger.kernel.org Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> --- Sending again since the previous message bounced for most recipients. drivers/hid/hid-logitech-hidpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 1e1cf8eae649..b8b53dc95e86 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp) multiplier = 1; hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier); + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier); return 0; } ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages 2020-07-05 17:34 [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages Maciej S. Szmigiero @ 2020-07-06 12:38 ` Filipe Laíns 2020-07-06 12:41 ` Maciej S. Szmigiero 2020-07-07 10:40 ` Jiri Kosina 1 sibling, 1 reply; 6+ messages in thread From: Filipe Laíns @ 2020-07-06 12:38 UTC (permalink / raw) To: Maciej S. Szmigiero, Jiri Kosina, Benjamin Tissoires Cc: Harry Cutts, Peter Hutterer, linux-input, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1486 bytes --] On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote: > These messages appear each time the mouse wakes from sleep, in my > case > (Logitech M705), every minute or so. > Let's downgrade them to the "debug" level so they don't fill the > kernel log > by default. > > While we are at it, let's make clear that this is a wheel multiplier > (and > not, for example, XY movement multiplier). > > Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling > on Logitech mice") > Cc: stable@vger.kernel.org > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> > --- > Sending again since the previous message bounced for most recipients. > > drivers/hid/hid-logitech-hidpp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > logitech-hidpp.c > index 1e1cf8eae649..b8b53dc95e86 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct > hidpp_device *hidpp) > multiplier = 1; > > hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; > - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier); > + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier); > return 0; > } > I have seen this being useful in some cases, however I do not have a strong opinion on it. Peter would know better. Cheers, Filipe Laíns [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages 2020-07-06 12:38 ` Filipe Laíns @ 2020-07-06 12:41 ` Maciej S. Szmigiero 2020-07-06 13:03 ` Filipe Laíns 0 siblings, 1 reply; 6+ messages in thread From: Maciej S. Szmigiero @ 2020-07-06 12:41 UTC (permalink / raw) To: Filipe Laíns Cc: Jiri Kosina, Benjamin Tissoires, Harry Cutts, Peter Hutterer, linux-input, linux-kernel On 06.07.2020 14:38, Filipe Laíns wrote: > On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote: >> These messages appear each time the mouse wakes from sleep, in my >> case >> (Logitech M705), every minute or so. >> Let's downgrade them to the "debug" level so they don't fill the >> kernel log >> by default. >> >> While we are at it, let's make clear that this is a wheel multiplier >> (and >> not, for example, XY movement multiplier). >> >> Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling >> on Logitech mice") >> Cc: stable@vger.kernel.org >> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> >> --- >> Sending again since the previous message bounced for most recipients. >> >> drivers/hid/hid-logitech-hidpp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- >> logitech-hidpp.c >> index 1e1cf8eae649..b8b53dc95e86 100644 >> --- a/drivers/hid/hid-logitech-hidpp.c >> +++ b/drivers/hid/hid-logitech-hidpp.c >> @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct >> hidpp_device *hidpp) >> multiplier = 1; >> >> hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; >> - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier); >> + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier); >> return 0; >> } >> > > I have seen this being useful in some cases, however I do not have a > strong opinion on it. Peter would know better. Well, the message is not being removed, only hidden by default, so it doesn't fill the kernel log. One can still enable it at runtime if wanted. > Cheers, > Filipe Laíns > Thanks, Maciej ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages 2020-07-06 12:41 ` Maciej S. Szmigiero @ 2020-07-06 13:03 ` Filipe Laíns 0 siblings, 0 replies; 6+ messages in thread From: Filipe Laíns @ 2020-07-06 13:03 UTC (permalink / raw) To: Maciej S. Szmigiero, Peter Hutterer Cc: Jiri Kosina, Benjamin Tissoires, Harry Cutts, linux-input, linux-kernel [-- Attachment #1: Type: text/plain, Size: 2215 bytes --] On Mon, 2020-07-06 at 14:41 +0200, Maciej S. Szmigiero wrote: > On 06.07.2020 14:38, Filipe Laíns wrote: > > On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote: > > > These messages appear each time the mouse wakes from sleep, in my > > > case > > > (Logitech M705), every minute or so. > > > Let's downgrade them to the "debug" level so they don't fill the > > > kernel log > > > by default. > > > > > > While we are at it, let's make clear that this is a wheel multiplier > > > (and > > > not, for example, XY movement multiplier). > > > > > > Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling > > > on Logitech mice") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> > > > --- > > > Sending again since the previous message bounced for most recipients. > > > > > > drivers/hid/hid-logitech-hidpp.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > > > logitech-hidpp.c > > > index 1e1cf8eae649..b8b53dc95e86 100644 > > > --- a/drivers/hid/hid-logitech-hidpp.c > > > +++ b/drivers/hid/hid-logitech-hidpp.c > > > @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct > > > hidpp_device *hidpp) > > > multiplier = 1; > > > > > > hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; > > > - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier); > > > + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier); > > > return 0; > > > } > > > > > > > I have seen this being useful in some cases, however I do not have a > > strong opinion on it. Peter would know better. > > Well, the message is not being removed, only hidden by default, so > it doesn't fill the kernel log. > > One can still enable it at runtime if wanted. Of course, but instructing users to do that can be annoying, especially when you're handling a considerable volume of reports. Anyway, I am fine with this patch, I just thought it was pertinent to raise this point and maybe get Peter's input on this, as he will likely be one most affected by it :) Filipe Laíns [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages 2020-07-05 17:34 [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages Maciej S. Szmigiero 2020-07-06 12:38 ` Filipe Laíns @ 2020-07-07 10:40 ` Jiri Kosina 1 sibling, 0 replies; 6+ messages in thread From: Jiri Kosina @ 2020-07-07 10:40 UTC (permalink / raw) To: Maciej S. Szmigiero Cc: Benjamin Tissoires, Harry Cutts, Peter Hutterer, linux-input, linux-kernel On Sun, 5 Jul 2020, Maciej S. Szmigiero wrote: > These messages appear each time the mouse wakes from sleep, in my case > (Logitech M705), every minute or so. > Let's downgrade them to the "debug" level so they don't fill the kernel log > by default. > > While we are at it, let's make clear that this is a wheel multiplier (and > not, for example, XY movement multiplier). > > Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice") > Cc: stable@vger.kernel.org > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Applied, thank you Maciej. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <7d2c980f071487cecfd1534adb7561b33d922af3.1593968925.git.mail@maciej.szmigiero.name>]
* Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages [not found] <7d2c980f071487cecfd1534adb7561b33d922af3.1593968925.git.mail@maciej.szmigiero.name> @ 2020-07-06 18:35 ` Harry Cutts 0 siblings, 0 replies; 6+ messages in thread From: Harry Cutts @ 2020-07-06 18:35 UTC (permalink / raw) To: Maciej S. Szmigiero Cc: Jiri Kosina, Benjamin Tissoires, Peter Hutterer, linux-input, lkml On Sun, 5 Jul 2020 at 10:09, Maciej S. Szmigiero <mail@maciej.szmigiero.name> wrote: > > These messages appear each time the mouse wakes from sleep, in my case > (Logitech M705), every minute or so. > Let's downgrade them to the "debug" level so they don't fill the kernel log > by default. > > While we are at it, let's make clear that this is a wheel multiplier (and > not, for example, XY movement multiplier). Looks good to me, thanks! Reviewed-by: Harry Cutts <hcutts@chromium.org> Harry Cutts Chrome OS Touch/Input team > > Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice") > Cc: stable@vger.kernel.org > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> > --- > drivers/hid/hid-logitech-hidpp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 1e1cf8eae649..b8b53dc95e86 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp) > multiplier = 1; > > hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; > - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier); > + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier); > return 0; > } > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-07 10:41 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-05 17:34 [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages Maciej S. Szmigiero 2020-07-06 12:38 ` Filipe Laíns 2020-07-06 12:41 ` Maciej S. Szmigiero 2020-07-06 13:03 ` Filipe Laíns 2020-07-07 10:40 ` Jiri Kosina [not found] <7d2c980f071487cecfd1534adb7561b33d922af3.1593968925.git.mail@maciej.szmigiero.name> 2020-07-06 18:35 ` Harry Cutts
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).