From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Nayna Jain <nayna@linux.ibm.com>,
linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-efi@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Philipp Rudo <prudo@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ima: add a new CONFIG for loading arch-specific policies
Date: Thu, 27 Feb 2020 14:38:09 -0500 [thread overview]
Message-ID: <1582832289.10443.298.camel@linux.ibm.com> (raw)
In-Reply-To: <1582749379.10443.246.camel@linux.ibm.com>
On Wed, 2020-02-26 at 15:36 -0500, Mimi Zohar wrote:
> On Wed, 2020-02-26 at 11:21 -0800, Lakshmi Ramasubramanian wrote:
> > Hi Nayna,
> >
> > > +
> > > +config IMA_SECURE_AND_OR_TRUSTED_BOOT
> > > + bool
> > > + depends on IMA
> > > + depends on IMA_ARCH_POLICY
> > > + default n
> > > + help
> > > + This option is selected by architectures to enable secure and/or
> > > + trusted boot based on IMA runtime policies.
> > >
> >
> > Why is the default for this new config "n"?
> > Is there any reason to not turn on this config if both IMA and
> > IMA_ARCH_POLICY are set to y?
>
> Good catch. Having "IMA_SECURE_AND_OR_TRUSTED_BOOT" depend on
> "IMA_ARCH_POLICY" doesn't make sense. "IMA_ARCH_POLICY" needs to be
> selected.
After discussing this some more with Nayna, the new Kconfig indicates
that the architecture defines the arch_ima_get_secureboot() and
arch_get_ima_policy() functions, but doesn't automatically enable
IMA_ARCH_POLICY. The decision to enable IMA_ARCH_POLICY is left up to
whoever is building the kernel. The patch, at least this aspect of
it, is correct.
Mimi
next prev parent reply other threads:[~2020-02-27 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 19:10 [PATCH] ima: add a new CONFIG for loading arch-specific policies Nayna Jain
2020-02-26 19:21 ` Lakshmi Ramasubramanian
2020-02-26 20:36 ` Mimi Zohar
2020-02-27 19:38 ` Mimi Zohar [this message]
2020-03-02 14:48 ` Mimi Zohar
2020-03-02 14:52 ` Ard Biesheuvel
2020-03-02 14:56 ` Mimi Zohar
2020-03-02 21:21 ` Heiko Carstens
2020-03-02 23:23 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582832289.10443.298.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=nramas@linux.microsoft.com \
--cc=prudo@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).