From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: gor@linux.ibm.com, linux-s390@vger.kernel.org,
walling@linux.ibm.com, kvm@vger.kernel.org, sebott@linux.ibm.com,
pmorel@linux.ibm.com, Cornelia Huck <cohuck@redhat.com>,
heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
iommu@lists.linux-foundation.org, robin.murphy@arm.com,
gerald.schaefer@de.ibm.com
Subject: Re: [PATCH v4 3/4] vfio: zpci: defining the VFIO headers
Date: Fri, 20 Sep 2019 10:46:25 -0400 [thread overview]
Message-ID: <8d1adef2-a202-1143-8899-92c03b973d41@linux.ibm.com> (raw)
In-Reply-To: <20190919164904.579f9e9e@x1.home>
On 9/19/19 6:49 PM, Alex Williamson wrote:
> On Thu, 19 Sep 2019 16:27:08 -0600
> Alex Williamson <alex.williamson@redhat.com> wrote:
>
>> On Thu, 19 Sep 2019 16:55:57 -0400
>> Matthew Rosato <mjrosato@linux.ibm.com> wrote:
>>
>>> On 9/19/19 11:20 AM, Cornelia Huck wrote:
>>>> On Fri, 6 Sep 2019 20:13:50 -0400
>>>> Matthew Rosato <mjrosato@linux.ibm.com> wrote:
>>>>
>>>>> From: Pierre Morel <pmorel@linux.ibm.com>
>>>>>
>>>>> We define a new device region in vfio.h to be able to
>>>>> get the ZPCI CLP information by reading this region from
>>>>> userland.
>>>>>
>>>>> We create a new file, vfio_zdev.h to define the structure
>>>>> of the new region we defined in vfio.h
>>>>>
>>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
>>>>> ---
>>>>> include/uapi/linux/vfio.h | 1 +
>>>>> include/uapi/linux/vfio_zdev.h | 35 +++++++++++++++++++++++++++++++++++
>>>>> 2 files changed, 36 insertions(+)
>>>>> create mode 100644 include/uapi/linux/vfio_zdev.h
>>>>>
>>>>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
>>>>> index 8f10748..8328c87 100644
>>>>> --- a/include/uapi/linux/vfio.h
>>>>> +++ b/include/uapi/linux/vfio.h
>>>>> @@ -371,6 +371,7 @@ struct vfio_region_gfx_edid {
>>>>> * to do TLB invalidation on a GPU.
>>>>> */
>>>>> #define VFIO_REGION_SUBTYPE_IBM_NVLINK2_ATSD (1)
>>>>> +#define VFIO_REGION_SUBTYPE_ZDEV_CLP (2)
>>>>
>>>> Using a subtype is fine, but maybe add a comment what this is for?
>>>>
>>>
>>> Fair point. Maybe something like "IBM ZDEV CLP is used to pass zPCI
>>> device features to guest"
>>
>> And if you're going to use a PCI vendor ID subtype, maintain consistent
>> naming, VFIO_REGION_SUBTYPE_IBM_ZPCI_CLP or something. Ideally there'd
>> also be a reference to the struct provided through this region
>> otherwise it's rather obscure to find by looking for the call to
>> vfio_pci_register_dev_region() and ops defined for the region. I
Sure, will rename and add reference
>> wouldn't be opposed to defining the region structure here too rather
>> than a separate file, but I guess you're following the example set by
>> ccw.
>>
Indeed.
>>>>>
>>>>> /*
>>>>> * The MSIX mappable capability informs that MSIX data of a BAR can be mmapped
>>>>> diff --git a/include/uapi/linux/vfio_zdev.h b/include/uapi/linux/vfio_zdev.h
>>>>> new file mode 100644
>>>>> index 0000000..55e0d6d
>>>>> --- /dev/null
>>>>> +++ b/include/uapi/linux/vfio_zdev.h
>>>>> @@ -0,0 +1,35 @@
>>>>> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>>>>> +/*
>>>>> + * Region definition for ZPCI devices
>>>>> + *
>>>>> + * Copyright IBM Corp. 2019
>>>>> + *
>>>>> + * Author(s): Pierre Morel <pmorel@linux.ibm.com>
>>>>> + */
>>>>> +
>>>>> +#ifndef _VFIO_ZDEV_H_
>>>>> +#define _VFIO_ZDEV_H_
>>>>> +
>>>>> +#include <linux/types.h>
>>>>> +
>>>>> +/**
>>>>> + * struct vfio_region_zpci_info - ZPCI information.
>>>>
>>>> Hm... probably should also get some more explanation. E.g. is that
>>>> derived from a hardware structure?
>>>>
>>>
>>> The structure itself is not mapped 1:1 to a hardware structure, but it
>>> does serve as a collection of information that was derived from other
>>> hardware structures.
>>>
>>> "Used for passing hardware feature information about a zpci device
>>> between the host and guest" ?
>>>
>>>>> + *
>>>>> + */
>>>>> +struct vfio_region_zpci_info {
>>>>> + __u64 dasm;
>>>>> + __u64 start_dma;
>>>>> + __u64 end_dma;
>>>>> + __u64 msi_addr;
>>>>> + __u64 flags;
>>>>> + __u16 pchid;
>>>>> + __u16 mui;
>>>>> + __u16 noi;
>>>>> + __u16 maxstbl;
>>>>> + __u8 version;
>>>>> + __u8 gid;
>>>>> +#define VFIO_PCI_ZDEV_FLAGS_REFRESH 1
>
> Why is this defined so far away from the flags field? I thought it was
> lost at first. I also wonder what it means... brief descriptions?
> Thanks,
>
Not sure why Pierre chose to put it here, but I have no issues moving it
up beneath flags.
Otherwise, I am getting the general gist of the feedback: more comments
to explain what this is doing.
> Alex
>
>>>>> + __u8 util_str[];
>>>>> +} __packed;
>>>>> +
>>>>> +#endif
>>
>> I'm half tempted to suggest that this struct could be exposed directly
>> through an info capability, the trouble is where. It would be somewhat
>> awkward to pick an arbitrary BAR or config space region to expose this
>> info. The VFIO_DEVICE_GET_INFO ioctl could include it, but we don't
>> support capabilities on that return structure and I'm not sure it's
>> worth implementing versus the solution here. Just a thought. Thanks,
>>
>> Alex
>
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-20 14:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 0:13 [PATCH v4 0/4] Retrieving zPCI specific info with VFIO Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 1/4] s390: pci: Exporting access to CLP PCI function and PCI group Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 2/4] s390: pci: Define the maxstbl CLP response entry Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 3/4] vfio: zpci: defining the VFIO headers Matthew Rosato
2019-09-19 15:20 ` Cornelia Huck
2019-09-19 20:55 ` Matthew Rosato
2019-09-19 22:27 ` Alex Williamson
2019-09-19 22:49 ` Alex Williamson
2019-09-20 14:46 ` Matthew Rosato [this message]
2019-09-20 14:02 ` Cornelia Huck
2019-09-20 15:14 ` Matthew Rosato
2019-10-08 13:30 ` Cornelia Huck
2019-09-07 0:13 ` [PATCH v4 4/4] vfio: pci: Using a device region to retrieve zPCI information Matthew Rosato
2019-09-19 15:25 ` Cornelia Huck
2019-09-19 20:57 ` Matthew Rosato
2019-09-20 14:26 ` Cornelia Huck
2019-09-20 15:53 ` Matthew Rosato
2019-09-19 22:57 ` Alex Williamson
2019-09-20 14:57 ` Matthew Rosato
2019-09-19 1:36 ` [PATCH v4 0/4] Retrieving zPCI specific info with VFIO Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d1adef2-a202-1143-8899-92c03b973d41@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=sebott@linux.ibm.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).