From: Matthew Rosato <mjrosato@linux.ibm.com>
To: sebott@linux.ibm.com
Cc: linux-s390@vger.kernel.org, walling@linux.ibm.com,
alex.williamson@redhat.com, gor@linux.ibm.com,
kvm@vger.kernel.org, pmorel@linux.ibm.com, cohuck@redhat.com,
heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
iommu@lists.linux-foundation.org, robin.murphy@arm.com,
gerald.schaefer@de.ibm.com
Subject: Re: [PATCH v4 0/4] Retrieving zPCI specific info with VFIO
Date: Wed, 18 Sep 2019 21:36:12 -0400 [thread overview]
Message-ID: <b4af47c1-0dc1-938d-20e4-0eeca095a7d5@linux.ibm.com> (raw)
In-Reply-To: <1567815231-17940-1-git-send-email-mjrosato@linux.ibm.com>
ping
On 9/6/19 8:13 PM, Matthew Rosato wrote:
> Note: These patches by Pierre got lost in the ether a few months back
> as he has been unavailable to carry them forward. I've made changes
> based upon comments received on his last version.
>
> We define a new configuration entry for VFIO/PCI, VFIO_PCI_ZDEV
> to configure access to a zPCI region dedicated for retrieving
> zPCI features.
>
> When the VFIO_PCI_ZDEV feature is configured we initialize
> a new device region, VFIO_REGION_SUBTYPE_ZDEV_CLP, to hold
> the information from the ZPCI device the userland needs to
> give to a guest driving the zPCI function.
>
>
> Note that in the current state we do not use the CLP instructions
> to access the firmware but get the information directly from
> the zdev device.
>
> -This means that the patch 1, "s390: pci: Exporting access to CLP PCI
> function and PCI group" is not used and can be let out of this series
> without denying the good working of the other patches.
> - But we will need this later, eventually in the next iteration
> to retrieve values not being saved inside the zdev structure.
> like maxstbl and the PCI supported version
>
> To share the code with arch/s390/pci/pci_clp.c the original functions
> in pci_clp.c to query PCI functions and PCI functions group are
> modified so that they can be exported.
>
> A new function clp_query_pci() replaces clp_query_pci_fn() and
> the previous calls to clp_query_pci_fn() and clp_query_pci_fngrp()
> are replaced with calls to zdev_query_pci_fn() and zdev_query_pci_fngrp()
> using a zdev pointer as argument.
>
> Changes since v3:
> - New patch: define maxstbl
> - Remove CLP_UTIL_STR_LEN references from uapi header
> - Fix broken ifdef CONFIG_VFIO_PCI_ZDEV
> - Change Kconfig option from tristate to bool
> - Remove VFIO_REGION_TYPE_IBM_ZDEV, move VFIO_REGION_SUBTYPE_ZDEV_CLP to a 1014 subtype
> - reject iswrite in .rw callback
> - Remove rw restriction on identical buffer sizes
> - Allow arbitrary sized read
>
> Pierre Morel (4):
> s390: pci: Exporting access to CLP PCI function and PCI group
> s390: pci: Define the maxstbl CLP response entry
> vfio: zpci: defining the VFIO headers
> vfio: pci: Using a device region to retrieve zPCI information
>
> arch/s390/include/asm/pci.h | 3 ++
> arch/s390/include/asm/pci_clp.h | 2 +-
> arch/s390/pci/pci_clp.c | 71 ++++++++++++++++---------------
> drivers/vfio/pci/Kconfig | 7 +++
> drivers/vfio/pci/Makefile | 1 +
> drivers/vfio/pci/vfio_pci.c | 9 ++++
> drivers/vfio/pci/vfio_pci_private.h | 10 +++++
> drivers/vfio/pci/vfio_pci_zdev.c | 85 +++++++++++++++++++++++++++++++++++++
> include/uapi/linux/vfio.h | 1 +
> include/uapi/linux/vfio_zdev.h | 35 +++++++++++++++
> 10 files changed, 189 insertions(+), 35 deletions(-)
> create mode 100644 drivers/vfio/pci/vfio_pci_zdev.c
> create mode 100644 include/uapi/linux/vfio_zdev.h
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2019-09-19 1:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 0:13 [PATCH v4 0/4] Retrieving zPCI specific info with VFIO Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 1/4] s390: pci: Exporting access to CLP PCI function and PCI group Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 2/4] s390: pci: Define the maxstbl CLP response entry Matthew Rosato
2019-09-07 0:13 ` [PATCH v4 3/4] vfio: zpci: defining the VFIO headers Matthew Rosato
2019-09-19 15:20 ` Cornelia Huck
2019-09-19 20:55 ` Matthew Rosato
2019-09-19 22:27 ` Alex Williamson
2019-09-19 22:49 ` Alex Williamson
2019-09-20 14:46 ` Matthew Rosato
2019-09-20 14:02 ` Cornelia Huck
2019-09-20 15:14 ` Matthew Rosato
2019-10-08 13:30 ` Cornelia Huck
2019-09-07 0:13 ` [PATCH v4 4/4] vfio: pci: Using a device region to retrieve zPCI information Matthew Rosato
2019-09-19 15:25 ` Cornelia Huck
2019-09-19 20:57 ` Matthew Rosato
2019-09-20 14:26 ` Cornelia Huck
2019-09-20 15:53 ` Matthew Rosato
2019-09-19 22:57 ` Alex Williamson
2019-09-20 14:57 ` Matthew Rosato
2019-09-19 1:36 ` Matthew Rosato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4af47c1-0dc1-938d-20e4-0eeca095a7d5@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=sebott@linux.ibm.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).