From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: devicetree@vger.kernel.org, linux-acpi@vger.kernel.org,
robin.murphy@arm.com, guohanjun@huawei.com, rjw@rjwysocki.net,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
linux-accelerators@lists.ozlabs.org, sudeep.holla@arm.com,
vivek.gautam@arm.com, zhangfei.gao@linaro.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v9 01/10] iommu: Remove obsolete comment
Date: Wed, 20 Jan 2021 18:41:56 +0100 [thread overview]
Message-ID: <YAhrZFCog5FiIupd@myrica> (raw)
In-Reply-To: <20210119111144.00002130@Huawei.com>
On Tue, Jan 19, 2021 at 11:11:44AM +0000, Jonathan Cameron wrote:
> On Fri, 8 Jan 2021 15:52:09 +0100
> Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
>
> > Commit 986d5ecc5699 ("iommu: Move fwspec->iommu_priv to struct
> > dev_iommu") removed iommu_priv from fwspec. Update the struct doc.
> >
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org
>
> Hi Jean-Philippe,
>
> Flags parameter doesn't have any docs in this structure and should
> do given kernel-doc should be complete. It probably spits out a warning
> for this if you build with W=1
Ah right, I had a patch removing the flags field locally, but I'm not
planning to upstream that one anymore. I don't mind fixing up the comment
in next version.
Thanks,
Jean
>
> Not sure if it makes sense to fix that in this same patch, or as a different
> one as the responsible patch is a different one.
> Looks like that came in:
> Commit 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes")
>
> Also, good to get this patch merged asap so we cut down on the noise in the
> interesting part of this series!
>
> FWIW
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Jonathan
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-01-20 17:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 14:52 [PATCH v9 00/10] iommu: I/O page faults for SMMUv3 Jean-Philippe Brucker
2021-01-08 14:52 ` [PATCH v9 01/10] iommu: Remove obsolete comment Jean-Philippe Brucker
2021-01-19 11:11 ` Jonathan Cameron
2021-01-20 17:41 ` Jean-Philippe Brucker [this message]
2021-01-08 14:52 ` [PATCH v9 02/10] iommu/arm-smmu-v3: Use device properties for pasid-num-bits Jean-Philippe Brucker
2021-01-19 11:22 ` Jonathan Cameron
2021-01-08 14:52 ` [PATCH v9 03/10] iommu: Separate IOMMU_DEV_FEAT_IOPF from IOMMU_DEV_FEAT_SVA Jean-Philippe Brucker
2021-01-12 4:31 ` Lu Baolu
2021-01-12 9:16 ` Jean-Philippe Brucker
2021-01-13 2:49 ` Lu Baolu
2021-01-13 8:10 ` Tian, Kevin
2021-01-14 16:41 ` Jean-Philippe Brucker
2021-01-16 3:54 ` Lu Baolu
2021-01-18 6:54 ` Tian, Kevin
2021-01-19 10:16 ` Jean-Philippe Brucker
2021-01-20 1:57 ` Lu Baolu
2021-01-08 14:52 ` [PATCH v9 04/10] iommu/vt-d: Support IOMMU_DEV_FEAT_IOPF Jean-Philippe Brucker
2021-01-08 14:52 ` [PATCH v9 05/10] uacce: Enable IOMMU_DEV_FEAT_IOPF Jean-Philippe Brucker
2021-01-11 3:29 ` Zhangfei Gao
2021-01-19 12:27 ` Jonathan Cameron
2021-01-20 17:42 ` Jean-Philippe Brucker
2021-01-20 20:47 ` Dave Jiang
2021-01-22 11:53 ` Zhou Wang
2021-01-22 15:43 ` Dave Jiang
2021-01-08 14:52 ` [PATCH v9 06/10] iommu: Add a page fault handler Jean-Philippe Brucker
2021-01-19 13:38 ` Jonathan Cameron
2021-01-20 17:43 ` Jean-Philippe Brucker
2021-01-08 14:52 ` [PATCH v9 07/10] iommu/arm-smmu-v3: Maintain a SID->device structure Jean-Philippe Brucker
2021-01-19 13:51 ` Jonathan Cameron
2021-01-08 14:52 ` [PATCH v9 08/10] dt-bindings: document stall property for IOMMU masters Jean-Philippe Brucker
2021-01-08 14:52 ` [PATCH v9 09/10] ACPI/IORT: Enable stall support for platform devices Jean-Philippe Brucker
2021-01-08 14:52 ` [PATCH v9 10/10] iommu/arm-smmu-v3: Add " Jean-Philippe Brucker
2021-01-19 17:28 ` Robin Murphy
2021-01-20 17:55 ` Jean-Philippe Brucker
2021-01-11 3:26 ` [PATCH v9 00/10] iommu: I/O page faults for SMMUv3 Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAhrZFCog5FiIupd@myrica \
--to=jean-philippe@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vivek.gautam@arm.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).