From: gregkh at linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH 4/4] Driver: Power: Supply: abx500_chargalg: Fixed a few coding style errors
Date: Mon, 30 Sep 2019 10:23:03 +0200 [thread overview]
Message-ID: <20190930082303.GC2036553@kroah.com> (raw)
In-Reply-To: <20190929181906.GA21828@madhuparna-HP-Notebook>
On Sun, Sep 29, 2019 at 11:49:10PM +0530, Madhuparna Bhowmik wrote:
> This patch fixes a few coding style errors and warnings
> detected by checkpatch.pl:
>
> WARNING: please, no space before tabs
> ERROR: code indent should use tabs where possible
> WARNING: please, no spaces at the start of a line
> WARNING: Unnecessary parentheses
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Prefer 'long' over 'long int' as the int is unnecessary
I know for the subsystems I maintain, I would require this to be broken
up into "one logical change per patch" so be aware that this might also
need to be done here too.
good luck!
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH 4/4] Driver: Power: Supply: abx500_chargalg: Fixed a few coding style errors
Date: Mon, 30 Sep 2019 10:23:03 +0200 [thread overview]
Message-ID: <20190930082303.GC2036553@kroah.com> (raw)
Message-ID: <20190930082303.WypcIgONUVhHYSnqQiMb5p5wAB_PhafLxbju1MQZxgY@z> (raw)
In-Reply-To: <20190929181906.GA21828@madhuparna-HP-Notebook>
On Sun, Sep 29, 2019 at 11:49:10PM +0530, Madhuparna Bhowmik wrote:
> This patch fixes a few coding style errors and warnings
> detected by checkpatch.pl:
>
> WARNING: please, no space before tabs
> ERROR: code indent should use tabs where possible
> WARNING: please, no spaces at the start of a line
> WARNING: Unnecessary parentheses
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Prefer 'long' over 'long int' as the int is unnecessary
I know for the subsystems I maintain, I would require this to be broken
up into "one logical change per patch" so be aware that this might also
need to be done here too.
good luck!
greg k-h
next prev parent reply other threads:[~2019-09-30 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 18:19 [Linux-kernel-mentees] [PATCH 4/4] Driver: Power: Supply: abx500_chargalg: Fixed a few coding style errors madhuparnabhowmik04
2019-09-29 18:19 ` Madhuparna Bhowmik
2019-09-30 8:23 ` gregkh [this message]
2019-09-30 8:23 ` Greg KH
2019-10-14 6:58 ` sre
2019-10-14 6:58 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930082303.GC2036553@kroah.com \
--to=linux-kernel-mentees@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).