* [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c
@ 2024-03-29 20:32 Shresth Prasad
0 siblings, 0 replies; 4+ messages in thread
From: Shresth Prasad @ 2024-03-29 20:32 UTC (permalink / raw)
To: gregkh, hverkuil-cisco, christophe.jaillet, prathubaronia2011,
luca.ceresoli, robh, u.kleine-koenig, frank.li
Cc: linux-staging, linux-kernel, linux-kernel-mentees, skhan, Shresth Prasad
Align some function arguments to the opening parenthesis of the
function as reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index c51818c56dd2..a70af76be7fb 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -376,8 +376,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
*/
mutex_lock(&fifo->read_lock);
ret = wait_event_interruptible_timeout(fifo->read_queue,
- ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
- read_timeout);
+ ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+ read_timeout);
if (ret <= 0) {
if (ret == 0) {
@@ -517,9 +517,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
*/
mutex_lock(&fifo->write_lock);
ret = wait_event_interruptible_timeout(fifo->write_queue,
- ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
- >= words_to_write,
- write_timeout);
+ ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+ >= words_to_write,
+ write_timeout);
if (ret <= 0) {
if (ret == 0) {
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c
2024-04-02 7:15 ` Dan Carpenter
@ 2024-04-02 13:59 ` eretmochelys imbricata
0 siblings, 0 replies; 4+ messages in thread
From: eretmochelys imbricata @ 2024-04-02 13:59 UTC (permalink / raw)
To: dan.carpenter
Cc: christophe.jaillet, frank.li, gregkh, hverkuil-cisco,
linux-kernel-mentees, linux-kernel, linux-staging, luca.ceresoli,
me, prathubaronia2011, robh, shresthprasad7, skhan,
u.kleine-koenig
>No, we're always taking patches. You just had bad luck/timing where you
>sent the patch 2 days before Greg went on vacation.
>Greg is back now, but I imagine he has a long list of stuff to catch up
>with. It's possible that he also accidentally dropped your patch
>because of the vacation... I could imagine a situation where that
>happened.
That's quite unfortunate. It's good to know that you guys are still
taking patches tho!
Regards,
Shresth Prasad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c
[not found] ` <qnljnwccqvqzilxuoat2s6md2zwcuhfruzbpepxebk65k34t3g@cyl67lk5lsoe>
@ 2024-04-02 7:15 ` Dan Carpenter
2024-04-02 13:59 ` eretmochelys imbricata
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2024-04-02 7:15 UTC (permalink / raw)
To: Uri Arev
Cc: Shresth Prasad, christophe.jaillet, frank.li, gregkh,
hverkuil-cisco, linux-kernel-mentees, linux-kernel,
linux-staging, luca.ceresoli, prathubaronia2011, robh, skhan,
u.kleine-koenig
On Sun, Mar 31, 2024 at 09:33:55PM +0300, Uri Arev wrote:
> > Oh, that's too bad. Thanks for the heads up!
> No worries, I wouldn't mind it if your patch got accepted and not mine
> :p
> I just don't think they accept patches to axis-fifo anymore, especially
> not basic syntax and checkpatch patches which are not as important as
> actual bug-fixes.
No, we're always taking patches. You just had bad luck/timing where you
sent the patch 2 days before Greg went on vacation.
Greg is back now, but I imagine he has a long list of stuff to catch up
with. It's possible that he also accidentally dropped your patch
because of the vacation... I could imagine a situation where that
happened.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c
[not found] <z2ewk44rjutv24i6lqau3adrmlprj524ulqtqbncvfaj44dwcg@2dnnbm75abbp>
@ 2024-03-31 2:19 ` Shresth Prasad
[not found] ` <qnljnwccqvqzilxuoat2s6md2zwcuhfruzbpepxebk65k34t3g@cyl67lk5lsoe>
0 siblings, 1 reply; 4+ messages in thread
From: Shresth Prasad @ 2024-03-31 2:19 UTC (permalink / raw)
To: me
Cc: christophe.jaillet, frank.li, gregkh, hverkuil-cisco,
linux-kernel-mentees, linux-kernel, linux-staging, luca.ceresoli,
prathubaronia2011, robh, shresthprasad7, skhan, u.kleine-koenig
Oh, that's too bad. Thanks for the heads up!
Regards,
Shresth Prasad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-02 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-29 20:32 [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c Shresth Prasad
[not found] <z2ewk44rjutv24i6lqau3adrmlprj524ulqtqbncvfaj44dwcg@2dnnbm75abbp>
2024-03-31 2:19 ` Shresth Prasad
[not found] ` <qnljnwccqvqzilxuoat2s6md2zwcuhfruzbpepxebk65k34t3g@cyl67lk5lsoe>
2024-04-02 7:15 ` Dan Carpenter
2024-04-02 13:59 ` eretmochelys imbricata
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).