From: Randy Dunlap <rdunlap@infradead.org>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>, mchehab@kernel.org
Cc: r.verdejo@samsung.com, linux-kernel@vger.kernel.org,
nicolas@ndufresne.ca, geert@linux-m68k.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] media: vidtv: fix build on 32bit architectures
Date: Tue, 15 Sep 2020 12:25:53 -0700 [thread overview]
Message-ID: <2280c5d7-7362-6760-fe70-54845c427bc5@infradead.org> (raw)
In-Reply-To: <20200915180509.2661572-1-dwlsalmeida@gmail.com>
On 9/15/20 11:05 AM, Daniel W. S. Almeida wrote:
> From: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
>
> Fix the following error for builds on 32bit architectures:
>
> ERROR: modpost: "__udivdi3"
> [drivers/media/test-drivers/vidtv/dvb-vidtv-bridge.ko] undefined!
>
> Which is due to 64bit divisions that did not go through the helpers
> in linux/math64.h
>
> As vidtv_mux_check_mux_rate was not operational in its current form,
> drop the entire function while it is not fixed properly.
>
> For now, call vidtv_mux_pad_with_nulls with a constant number of packets
> to avoid warnings due to unused functions when building this driver.
>
> Fixes: f90cf6079bf67988 ("media: vidtv: add a bridge driver")
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> ---
> drivers/media/test-drivers/vidtv/vidtv_mux.c | 34 +------------------
> .../media/test-drivers/vidtv/vidtv_s302m.c | 4 +--
> 2 files changed, 3 insertions(+), 35 deletions(-)
>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
--
~Randy
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-15 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:05 [Linux-kernel-mentees] [PATCH] media: vidtv: fix build on 32bit architectures Daniel W. S. Almeida
2020-09-15 19:25 ` Randy Dunlap [this message]
2020-09-16 6:40 ` Mauro Carvalho Chehab
2020-09-16 7:06 ` Geert Uytterhoeven
2020-09-16 13:43 ` Daniel W. S. Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2280c5d7-7362-6760-fe70-54845c427bc5@infradead.org \
--to=rdunlap@infradead.org \
--cc=dwlsalmeida@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=r.verdejo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).