From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Randy Dunlap" <rdunlap@infradead.org>,
"r.verdejo@samsung.com" <r.verdejo@samsung.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"nicolas@ndufresne.ca" <nicolas@ndufresne.ca>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH] media: vidtv: fix build on 32bit architectures
Date: Wed, 16 Sep 2020 10:43:42 -0300 [thread overview]
Message-ID: <BAE73C66-D2B7-44A5-8CD9-72D0430BEED7@getmailspring.com> (raw)
In-Reply-To: <CAMuHMdXjA7q-v-mYY9DChC0XQbv9vfW6c3Vfn07-H-FgBr+izA@mail.gmail.com>
Hi Mauro, Geert,
> That doesn't seem to be the right thing to do here.
>
> Assuming that sampling rate is 48 kHz, you'll
> have duration = 1.875, which would be rounded to 1.
>
> In other words, the above is identical to:
>
> au->pts = count
>
> Now, I don't know from where that CLOCK_UNIT_90KHZ came from.
>
Mauro, here's my current understanding:
The values for PTS have to be defined in terms of a 90khz clock.
So for 30fps video, the values for PTS per frame would be:
frame_num/30 * 90000
so 0, 3000, 6000, 9000...etc
The same math is being used here for audio, but instead we have the
total audio sample count and a 48000 samples/sec
I did miss this rounding error though, I'm sorry.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-09-16 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:05 [Linux-kernel-mentees] [PATCH] media: vidtv: fix build on 32bit architectures Daniel W. S. Almeida
2020-09-15 19:25 ` Randy Dunlap
2020-09-16 6:40 ` Mauro Carvalho Chehab
2020-09-16 7:06 ` Geert Uytterhoeven
2020-09-16 13:43 ` Daniel W. S. Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAE73C66-D2B7-44A5-8CD9-72D0430BEED7@getmailspring.com \
--to=dwlsalmeida@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=r.verdejo@samsung.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).