* [PATCH] selftests:proc: Resolve 'Unused Result' Warning from proc-empty-vm.c
@ 2023-11-29 3:45 angquan yu
2023-11-30 20:25 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: angquan yu @ 2023-11-29 3:45 UTC (permalink / raw)
To: skhan
Cc: shuah, linux-kselftest, linux-kernel, linux-kernel-mentees, angquan yu
From: angquan yu <angquan21@gmail.com>
In tools/testing/selftests/proc/proc-empty->because the return value
of a write call was being ignored. This call was partof a conditional
debugging block (if (0) { ... }), which meant it would neveractually
execute.
This patch removes the unused debug write call. This cleanup resolves
the compi>warning about ignoring the result of write declared with
the warn_unused_resultattribute.
Removing this code also improves the clarity and maintainability of
the function, as it eliminates a non-functional block of code.
This is original warning: proc-empty-vm.c: In function
‘test_proc_pid_statm’ :proc-empty-vm.c:385:17:
warning: ignoring return value of ‘write’
declared with>385 | write(1, buf, rv);|
Signed-off-by: angquan yu <angquan21@gmail.com>
---
tools/testing/selftests/proc/proc-empty-vm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/proc/proc-empty-vm.c b/tools/testing/selftests/proc/proc-empty-vm.c
index 5e7020630..d231e61e4 100644
--- a/tools/testing/selftests/proc/proc-empty-vm.c
+++ b/tools/testing/selftests/proc/proc-empty-vm.c
@@ -383,8 +383,10 @@ static int test_proc_pid_statm(pid_t pid)
assert(rv <= sizeof(buf));
if (0) {
ssize_t written = write(1, buf, rv);
+
if (written == -1) {
perror("write failed to /proc/${pid}");
+ return EXIT_FAILURE;
}
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests:proc: Resolve 'Unused Result' Warning from proc-empty-vm.c
2023-11-29 3:45 [PATCH] selftests:proc: Resolve 'Unused Result' Warning from proc-empty-vm.c angquan yu
@ 2023-11-30 20:25 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2023-11-30 20:25 UTC (permalink / raw)
To: angquan yu
Cc: shuah, linux-kselftest, linux-kernel, linux-kernel-mentees, Shuah Khan
On 11/28/23 20:45, angquan yu wrote:
> From: angquan yu <angquan21@gmail.com>
>
> In tools/testing/selftests/proc/proc-empty->because the return value
> of a write call was being ignored. This call was partof a conditional
> debugging block (if (0) { ... }), which meant it would neveractually
> execute.
>
> This patch removes the unused debug write call. This cleanup resolves
> the compi>warning about ignoring the result of write declared with
> the warn_unused_resultattribute.
>
> Removing this code also improves the clarity and maintainability of
> the function, as it eliminates a non-functional block of code.
>
> This is original warning: proc-empty-vm.c: In function
> ‘test_proc_pid_statm’ :proc-empty-vm.c:385:17:
> warning: ignoring return value of ‘write’
> declared with>385 | write(1, buf, rv);|
>
> Signed-off-by: angquan yu <angquan21@gmail.com>
> ---
> tools/testing/selftests/proc/proc-empty-vm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/proc/proc-empty-vm.c b/tools/testing/selftests/proc/proc-empty-vm.c
> index 5e7020630..d231e61e4 100644
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> @@ -383,8 +383,10 @@ static int test_proc_pid_statm(pid_t pid)
> assert(rv <= sizeof(buf));
> if (0) {
> ssize_t written = write(1, buf, rv);
> +
> if (written == -1) {
> perror("write failed to /proc/${pid}");
> + return EXIT_FAILURE;
> }
> }
>
Hmm. Is this patch based on Linux 6.7-rc3? The code doesn't
match?
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-30 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-29 3:45 [PATCH] selftests:proc: Resolve 'Unused Result' Warning from proc-empty-vm.c angquan yu
2023-11-30 20:25 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).