From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v3] checkpatch: add new warnings to author signoff checks.
Date: Tue, 6 Oct 2020 18:45:00 +0530 [thread overview]
Message-ID: <CABJPP5AkdKekb2mRuiDm1-GOuqZ1vL=eNt=OJZN2iAPH1yNytQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2010060635000.10609@felia>
> > > Except for comments and quotes like:
> > >
> > > From: J. Random Developer (BigCorp) <jrd@bigcorp.com>
> > > Signed-off-by: "J. Random Developer" <jrd@bigcorp.com>
> > >
> > > I think any time there's a mismatch, there
> > > should be a warning emitted.
> > >
> > > That includes any subaddress detail difference.
> > >
> > >
> > Hi,
> > Yeah these cases are being handled.
> >
> > Comments and quotes don't generate any warning message but
> > all the other mismatches do.
> >
> > Only the check for subaddress generates a --strict check message.
> > others are all WARN messages. It was followed from our discussion at
> > https://lore.kernel.org/linux-kernel-mentees/7b52e085f0b69ad1742966f8eacd02deb9299b96.camel@perches.com/
> >
> > So does it need to be changed to a WARN or is it fine like that?
> >
>
> I will repeat what I suggested before:
>
> I think the complete mismatch where we cannot even find a name or an email
> match the author deserves to be reported as ERROR.
>
> Dwaipayan, if Joe does not disagree, could you change that in your PATCH v4?
>
Yes sure I hope to do that after Joe gives his affirmation.
To summarize it, two changes that could be made are
the CHK for subaddress extension could be converted to
a WARN, and the WARN in case of a missing author signoff
could be converted to an ERROR.
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-06 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 19:24 [Linux-kernel-mentees] [PATCH v3] checkpatch: add new warnings to author signoff checks Dwaipayan Ray
2020-10-05 19:37 ` Joe Perches
2020-10-05 20:07 ` Dwaipayan Ray
2020-10-05 21:09 ` Joe Perches
2020-10-06 4:23 ` Dwaipayan Ray
2020-10-06 4:38 ` Lukas Bulwahn
2020-10-06 13:15 ` Dwaipayan Ray [this message]
2020-10-06 18:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABJPP5AkdKekb2mRuiDm1-GOuqZ1vL=eNt=OJZN2iAPH1yNytQ@mail.gmail.com' \
--to=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).