From: Abhinav Singh <singhabhinav9051571833@gmail.com>
To: oliver@neukum.org, aliakc@web.de, lenehan@twibble.org,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] driver: scsi: Fix warning using plain integer as NULL
Date: Sun, 26 Nov 2023 01:06:48 +0530 [thread overview]
Message-ID: <aaf69d6b-55ea-44de-b6c4-0eddd2b0aa0c@gmail.com> (raw)
In-Reply-To: <20231109215049.1466431-1-singhabhinav9051571833@gmail.com>
On 11/10/23 03:20, Abhinav Singh wrote:
> Sparse static analysis tools generate a warning with this message
> "Using plain integer as NULL pointer". In this case this warning is
> being shown because we are trying to initialize pointer to NULL using
> integer value 0.
>
> Signed-off-by: Abhinav Singh <singhabhinav9051571833@gmail.com>
> ---
> drivers/scsi/dc395x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index c8e86f8a631e..d108a86e196e 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -1366,7 +1366,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb,
> "command while another command (0x%p) is active.",
> srb->cmd,
> acb->active_dcb->active_srb ?
> - acb->active_dcb->active_srb->cmd : 0);
> + acb->active_dcb->active_srb->cmd : NULL);
> return 1;
> }
> if (DC395x_read16(acb, TRM_S1040_SCSI_STATUS) & SCSIINTERRUPT) {
Hello maintainers, any reviews or comments on this.
Thank You,
Abhinav Singh
next prev parent reply other threads:[~2023-11-25 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 21:50 [PATCH] driver: scsi: Fix warning using plain integer as NULL Abhinav Singh
2023-11-25 19:36 ` Abhinav Singh [this message]
2023-12-06 3:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaf69d6b-55ea-44de-b6c4-0eddd2b0aa0c@gmail.com \
--to=singhabhinav9051571833@gmail.com \
--cc=aliakc@web.de \
--cc=jejb@linux.ibm.com \
--cc=lenehan@twibble.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).