From: Hans Verkuil <hverkuil@xs4all.nl>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
bjorn@helgaas.com, Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH v1 2/6] [media] cx23885: use generic power management
Date: Mon, 13 Jul 2020 12:01:51 +0200 [thread overview]
Message-ID: <c4a46846-208f-c834-56d7-02543c395795@xs4all.nl> (raw)
In-Reply-To: <20200629073604.205478-3-vaibhavgupta40@gmail.com>
On 29/06/2020 09:36, Vaibhav Gupta wrote:
> The .suspend() and .resume() callbacks are not defined for this driver.
> Still, their power managemgement stucture can be easily upgraded to
management structure
> gemeric, without affecting its normal behaviour.
generic
>
> Hence, define them NULL and use struct dev_pm_ops type to bind them.
>
> Compile-tested only.
>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> ---
> drivers/media/pci/cx23885/cx23885-core.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/pci/cx23885/cx23885-core.c b/drivers/media/pci/cx23885/cx23885-core.c
> index 7e0b0b7cc2a3..da9ee7270dfd 100644
> --- a/drivers/media/pci/cx23885/cx23885-core.c
> +++ b/drivers/media/pci/cx23885/cx23885-core.c
> @@ -2230,14 +2230,18 @@ static const struct pci_device_id cx23885_pci_tbl[] = {
> };
> MODULE_DEVICE_TABLE(pci, cx23885_pci_tbl);
>
> +#define cx23885_suspend NULL
> +#define cx23885_resume NULL
> +
> +static SIMPLE_DEV_PM_OPS(cx23885_pm_ops, cx23885_suspend, cx23885_resume);
> +
> static struct pci_driver cx23885_pci_driver = {
> - .name = "cx23885",
> - .id_table = cx23885_pci_tbl,
> - .probe = cx23885_initdev,
> - .remove = cx23885_finidev,
> + .name = "cx23885",
> + .id_table = cx23885_pci_tbl,
> + .probe = cx23885_initdev,
> + .remove = cx23885_finidev,
> /* TODO */
> - .suspend = NULL,
> - .resume = NULL,
> + .driver.pm = &cx23885_pm_ops,
I don't entirely understand this. Wouldn't it be sufficient to just
drop the .suspend/.resume assignments here? It is now required for
driver.pm to be non-NULL?
I'm not up to speed on the changes, but normally you can leave things
NULL if you don't support a feature (PM in this case).
Regards,
Hans
> };
>
> static int __init cx23885_init(void)
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-13 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 7:35 [Linux-kernel-mentees] [PATCH v1 0/6] [media] pci: use generic power management Vaibhav Gupta
2020-06-29 7:35 ` [Linux-kernel-mentees] [PATCH v1 1/6] [media] sta2x11: " Vaibhav Gupta
2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 2/6] [media] cx23885: " Vaibhav Gupta
2020-07-13 10:01 ` Hans Verkuil [this message]
2020-07-14 0:38 ` Bjorn Helgaas
2020-07-14 10:52 ` Vaibhav Gupta
2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 3/6] [media] cx25821: " Vaibhav Gupta
2020-07-13 10:03 ` Hans Verkuil
2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 4/6] [media] cx88: " Vaibhav Gupta
2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 5/6] [media] meye: " Vaibhav Gupta
2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 6/6] [media] tw68: " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4a46846-208f-c834-56d7-02543c395795@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=bhelgaas@google.com \
--cc=bjorn@helgaas.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).