From: Michal Rostecki <mrostecki@opensuse.org>
To: Daniel Borkmann <daniel@iogearbox.net>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
Quentin Monnet <quentin.monnet@netronome.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 5/5] selftests/bpf: Add test for "bpftool feature" command
Date: Wed, 26 Feb 2020 16:42:13 +0100 [thread overview]
Message-ID: <04df2984-808b-4c69-9bdc-e65815d9e64e@opensuse.org> (raw)
In-Reply-To: <d0c40cd0-f9db-c6cb-5b46-79145311050d@iogearbox.net>
On 2/26/20 4:34 PM, Daniel Borkmann wrote:
> Ptal, when running the test I'm getting the following error:
>
> root@tank:~/bpf-next/tools/testing/selftests/bpf# ./test_bpftool.sh
> test_feature_dev_json (test_bpftool.TestBpftool) ... ERROR
> test_feature_kernel (test_bpftool.TestBpftool) ... ERROR
> test_feature_kernel_full (test_bpftool.TestBpftool) ... ERROR
> test_feature_kernel_full_vs_not_full (test_bpftool.TestBpftool) ... ERROR
> test_feature_macros (test_bpftool.TestBpftool) ... ERROR
>
> ======================================================================
> ERROR: test_feature_dev_json (test_bpftool.TestBpftool)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 58, in wrapper
> return f(*args, iface, **kwargs)
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 83, in test_feature_dev_json
> res = bpftool_json(["feature", "probe", "dev", iface])
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 43, in bpftool_json
> res = _bpftool(args)
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 34, in _bpftool
> res = subprocess.run(_args, capture_output=True)
> File "/usr/lib/python3.6/subprocess.py", line 423, in run
> with Popen(*popenargs, **kwargs) as process:
> TypeError: __init__() got an unexpected keyword argument 'capture_output'
Seems like that kwarg in Popen was added in Python 3.7. I will drop it
and use the older way of getting combined output. Thanks for pointing
that out!
next prev parent reply other threads:[~2020-02-26 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 19:44 [PATCH bpf-next v3 0/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 1/5] bpftool: Move out sections to separate functions Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 2/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-26 15:35 ` Daniel Borkmann
2020-02-25 19:44 ` [PATCH bpf-next v3 3/5] bpftool: Update documentation of "bpftool feature" command Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 4/5] bpftool: Update bash completion for " Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 5/5] selftests/bpf: Add test " Michal Rostecki
2020-02-26 15:34 ` Daniel Borkmann
2020-02-26 15:42 ` Michal Rostecki [this message]
2020-02-26 15:43 ` Quentin Monnet
2020-02-26 11:17 ` [PATCH bpf-next v3 0/5] bpftool: Make probes which emit dmesg warnings optional Quentin Monnet
2020-02-26 12:17 ` Michal Rostecki
2020-02-26 12:33 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04df2984-808b-4c69-9bdc-e65815d9e64e@opensuse.org \
--to=mrostecki@opensuse.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).