From: Quentin Monnet <quentin@isovalent.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Michal Rostecki <mrostecki@opensuse.org>,
bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 5/5] selftests/bpf: Add test for "bpftool feature" command
Date: Wed, 26 Feb 2020 15:43:25 +0000 [thread overview]
Message-ID: <3e485c13-e478-c0b3-39e4-595dbd968ea2@isovalent.com> (raw)
In-Reply-To: <d0c40cd0-f9db-c6cb-5b46-79145311050d@iogearbox.net>
2020-02-26 16:34 UTC+0100 ~ Daniel Borkmann <daniel@iogearbox.net>
> On 2/25/20 8:44 PM, Michal Rostecki wrote:
>> Add Python module with tests for "bpftool feature" command, which mainly
>> wheck whether the "full" option is working properly.
>
> nit, typo: wheck
>
>>
>> Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
>
> Ptal, when running the test I'm getting the following error:
>
> root@tank:~/bpf-next/tools/testing/selftests/bpf# ./test_bpftool.sh
> test_feature_dev_json (test_bpftool.TestBpftool) ... ERROR
> test_feature_kernel (test_bpftool.TestBpftool) ... ERROR
> test_feature_kernel_full (test_bpftool.TestBpftool) ... ERROR
> test_feature_kernel_full_vs_not_full (test_bpftool.TestBpftool) ... ERROR
> test_feature_macros (test_bpftool.TestBpftool) ... ERROR
>
> ======================================================================
> ERROR: test_feature_dev_json (test_bpftool.TestBpftool)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 58, in wrapper
> return f(*args, iface, **kwargs)
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 83, in test_feature_dev_json
> res = bpftool_json(["feature", "probe", "dev", iface])
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 43, in bpftool_json
> res = _bpftool(args)
> File "/root/bpf-next/tools/testing/selftests/bpf/test_bpftool.py",
> line 34, in _bpftool
> res = subprocess.run(_args, capture_output=True)
> File "/usr/lib/python3.6/subprocess.py", line 423, in run
> with Popen(*popenargs, **kwargs) as process:
> TypeError: __init__() got an unexpected keyword argument 'capture_output'
Apparently the “capture_output” option for subprocess was added to
python 3.7 [0]. It worked on my system (python 3.7.5) but didn't pass on
yours with 3.6.
Michal, can you change it to something less recent please, so that
people don't have to upgrade python to test?
Quentin
[0] https://docs.python.org/3/whatsnew/3.7.html#subprocess
next prev parent reply other threads:[~2020-02-26 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 19:44 [PATCH bpf-next v3 0/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 1/5] bpftool: Move out sections to separate functions Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 2/5] bpftool: Make probes which emit dmesg warnings optional Michal Rostecki
2020-02-26 15:35 ` Daniel Borkmann
2020-02-25 19:44 ` [PATCH bpf-next v3 3/5] bpftool: Update documentation of "bpftool feature" command Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 4/5] bpftool: Update bash completion for " Michal Rostecki
2020-02-25 19:44 ` [PATCH bpf-next v3 5/5] selftests/bpf: Add test " Michal Rostecki
2020-02-26 15:34 ` Daniel Borkmann
2020-02-26 15:42 ` Michal Rostecki
2020-02-26 15:43 ` Quentin Monnet [this message]
2020-02-26 11:17 ` [PATCH bpf-next v3 0/5] bpftool: Make probes which emit dmesg warnings optional Quentin Monnet
2020-02-26 12:17 ` Michal Rostecki
2020-02-26 12:33 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e485c13-e478-c0b3-39e4-595dbd968ea2@isovalent.com \
--to=quentin@isovalent.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mrostecki@opensuse.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).