From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH v6 10/21] tracing: probeevent: Return consumed bytes of dynamic area
Date: Tue, 3 Apr 2018 23:41:53 +0900 [thread overview]
Message-ID: <20180403234153.7bd44567305ca11cead0e35b@kernel.org> (raw)
Message-ID: <20180403144153.ktlDm-mCDSHd33p4aEtVAd7R_hlL_QZjcftEYqZplQ8@z> (raw)
In-Reply-To: <20180402160207.23c96309@gandalf.local.home>
On Mon, 2 Apr 2018 16:02:07 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 17 Mar 2018 21:44:52 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > -static nokprobe_inline void
> > -fetch_store_string(unsigned long addr, void *dest)
> > +static nokprobe_inline int
> > +fetch_store_string(unsigned long addr, void *dest, void *base)
> > {
> > - int maxlen = get_rloc_len(*(u32 *)dest);
> > - u8 *dst = get_rloc_data(dest);
> > + int maxlen = get_loc_len(*(u32 *)dest);
> > + u8 *dst = get_loc_data(dest, base);
> > long ret;
> >
> > if (!maxlen)
> > - return;
> > + return -ENOMEM;
> >
> > /*
> > * Try to get string again, since the string can be changed while
> > @@ -854,19 +851,19 @@ fetch_store_string(unsigned long addr, void *dest)
> >
> > if (ret < 0) { /* Failed to fetch string */
> > dst[0] = '\0';
> > - *(u32 *)dest = make_data_rloc(0, get_rloc_offs(*(u32 *)dest));
> > - } else {
> > - *(u32 *)dest = make_data_rloc(ret, get_rloc_offs(*(u32 *)dest));
> > + ret = 0;
>
> Why do you return 0 here and not the error value? You return -ENOMEM
> above if maxlen is zero.
Good catch! it should clear dst[0] and return 0 even if no buffer remains...
OK, I'll fix it.
Thank you!
>
> -- Steve
>
> > }
> > + *(u32 *)dest = make_data_loc(ret, (void *)dst - base);
> > + return ret;
> > }
--
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-03 14:41 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 12:37 [PATCH v6 00/21] tracing: probeevent: Improve fetcharg features mhiramat
2018-03-17 12:37 ` Masami Hiramatsu
2018-03-17 12:38 ` [PATCH v6 01/21] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol mhiramat
2018-03-17 12:38 ` Masami Hiramatsu
2018-03-17 12:38 ` [PATCH v6 02/21] selftests: ftrace: Add probe event argument syntax testcase mhiramat
2018-03-17 12:38 ` Masami Hiramatsu
2018-03-17 12:39 ` [PATCH v6 03/21] selftests: ftrace: Add a testcase for string type with kprobe_event mhiramat
2018-03-17 12:39 ` Masami Hiramatsu
2018-03-17 12:40 ` [PATCH v6 04/21] selftests: ftrace: Add a testcase for probepoint mhiramat
2018-03-17 12:40 ` Masami Hiramatsu
2018-03-23 16:19 ` rostedt
2018-03-23 16:19 ` Steven Rostedt
2018-03-17 12:41 ` [PATCH v6 05/21] tracing: probeevent: Cleanup print argument functions mhiramat
2018-03-17 12:41 ` Masami Hiramatsu
2018-03-23 16:36 ` rostedt
2018-03-23 16:36 ` Steven Rostedt
2018-03-26 4:17 ` mhiramat
2018-03-26 4:17 ` Masami Hiramatsu
2018-03-26 17:28 ` rostedt
2018-03-26 17:28 ` Steven Rostedt
2018-03-28 4:21 ` mhiramat
2018-03-28 4:21 ` Masami Hiramatsu
2018-03-17 12:41 ` [PATCH v6 06/21] tracing: probeevent: Cleanup argument field definition mhiramat
2018-03-17 12:41 ` Masami Hiramatsu
2018-03-17 12:42 ` [PATCH v6 07/21] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions mhiramat
2018-03-17 12:42 ` Masami Hiramatsu
2018-03-17 12:43 ` [PATCH v6 08/21] tracing: probeevent: Introduce new argument fetching code mhiramat
2018-03-17 12:43 ` Masami Hiramatsu
2018-03-17 12:44 ` [PATCH v6 09/21] tracing: probeevent: Unify fetch type tables mhiramat
2018-03-17 12:44 ` Masami Hiramatsu
2018-03-17 12:44 ` [PATCH v6 10/21] tracing: probeevent: Return consumed bytes of dynamic area mhiramat
2018-03-17 12:44 ` Masami Hiramatsu
2018-04-02 20:02 ` rostedt
2018-04-02 20:02 ` Steven Rostedt
2018-04-03 14:41 ` mhiramat [this message]
2018-04-03 14:41 ` Masami Hiramatsu
2018-03-17 12:45 ` [PATCH v6 11/21] tracing: probeevent: Append traceprobe_ for exported function mhiramat
2018-03-17 12:45 ` Masami Hiramatsu
2018-03-17 12:46 ` [PATCH v6 12/21] tracing: probeevent: Unify fetch_insn processing common part mhiramat
2018-03-17 12:46 ` Masami Hiramatsu
2018-03-17 12:47 ` [PATCH v6 13/21] tracing: probeevent: Add symbol type mhiramat
2018-03-17 12:47 ` Masami Hiramatsu
2018-03-17 12:47 ` [PATCH v6 14/21] x86: ptrace: Add function argument access API mhiramat
2018-03-17 12:47 ` Masami Hiramatsu
2018-03-17 12:48 ` [PATCH v6 15/21] tracing: probeevent: Add $argN for accessing function args mhiramat
2018-03-17 12:48 ` Masami Hiramatsu
2018-03-17 12:49 ` [PATCH v6 16/21] tracing: probeevent: Add array type support mhiramat
2018-03-17 12:49 ` Masami Hiramatsu
2018-03-17 12:50 ` [PATCH v6 17/21] selftests: ftrace: Add a testcase for symbol type mhiramat
2018-03-17 12:50 ` Masami Hiramatsu
2018-03-17 12:50 ` [PATCH v6 18/21] selftests: ftrace: Add a testcase for $argN with kprobe_event mhiramat
2018-03-17 12:50 ` Masami Hiramatsu
2018-03-17 12:51 ` [PATCH v6 19/21] selftests: ftrace: Add a testcase for array type " mhiramat
2018-03-17 12:51 ` Masami Hiramatsu
2018-03-17 12:52 ` [PATCH v6 20/21] [RESEND] perf-probe: Fix to convert array type collectly mhiramat
2018-03-17 12:52 ` Masami Hiramatsu
2018-03-17 12:53 ` [PATCH v6 21/21] perf-probe: Add array argument support mhiramat
2018-03-17 12:53 ` Masami Hiramatsu
2018-03-19 7:59 ` ravi.bangoria
2018-03-19 7:59 ` Ravi Bangoria
2018-03-22 10:23 ` mhiramat
2018-03-22 10:23 ` Masami Hiramatsu
2018-03-22 10:49 ` ravi.bangoria
2018-03-22 10:49 ` Ravi Bangoria
2018-03-26 3:53 ` mhiramat
2018-03-26 3:53 ` Masami Hiramatsu
2018-03-17 14:06 ` [PATCH v6 00/21] tracing: probeevent: Improve fetcharg features mhiramat
2018-03-17 14:06 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403234153.7bd44567305ca11cead0e35b@kernel.org \
--to=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).