From: bhole_prashant_q7 at lab.ntt.co.jp (Prashant Bhole) Subject: [PATCH bpf-next v4 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Date: Thu, 31 May 2018 13:42:37 +0900 [thread overview] Message-ID: <20180531044240.796-3-bhole_prashant_q7@lab.ntt.co.jp> (raw) In-Reply-To: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp> In case of selftest mode, temporary cgroup environment is created but cgroup is not joined. It causes test failures. Fixed by joining the cgroup Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Acked-by: John Fastabend <john.fastabend at gmail.com> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp> --- tools/testing/selftests/bpf/test_sockmap.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 7b2008a144cb..7f9ca79aadbc 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -1344,6 +1344,11 @@ static int __test_suite(char *bpf_file) return cg_fd; } + if (join_cgroup(CG_PATH)) { + fprintf(stderr, "ERROR: failed to join cgroup\n"); + return -EINVAL; + } + /* Tests basic commands and APIs with range of iov values */ txmsg_start = txmsg_end = 0; err = test_txmsg(cg_fd); -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: bhole_prashant_q7@lab.ntt.co.jp (Prashant Bhole) Subject: [PATCH bpf-next v4 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Date: Thu, 31 May 2018 13:42:37 +0900 [thread overview] Message-ID: <20180531044240.796-3-bhole_prashant_q7@lab.ntt.co.jp> (raw) Message-ID: <20180531044237.3iDDQVMhCWi1nMjcH2m0F5swANimunySSr6hFAn2V1w@z> (raw) In-Reply-To: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp> In case of selftest mode, temporary cgroup environment is created but cgroup is not joined. It causes test failures. Fixed by joining the cgroup Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Acked-by: John Fastabend <john.fastabend at gmail.com> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp> --- tools/testing/selftests/bpf/test_sockmap.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 7b2008a144cb..7f9ca79aadbc 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -1344,6 +1344,11 @@ static int __test_suite(char *bpf_file) return cg_fd; } + if (join_cgroup(CG_PATH)) { + fprintf(stderr, "ERROR: failed to join cgroup\n"); + return -EINVAL; + } + /* Tests basic commands and APIs with range of iov values */ txmsg_start = txmsg_end = 0; err = test_txmsg(cg_fd); -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-31 4:42 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-31 4:42 [PATCH bpf-next v4 0/5] fix test_sockmap bhole_prashant_q7 2018-05-31 4:42 ` Prashant Bhole 2018-05-31 4:42 ` [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure bhole_prashant_q7 2018-05-31 4:42 ` Prashant Bhole 2018-06-01 14:04 ` john.fastabend 2018-06-01 14:04 ` John Fastabend 2018-05-31 4:42 ` bhole_prashant_q7 [this message] 2018-05-31 4:42 ` [PATCH bpf-next v4 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole 2018-05-31 4:42 ` [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements bhole_prashant_q7 2018-05-31 4:42 ` Prashant Bhole 2018-06-01 14:11 ` john.fastabend 2018-06-01 14:11 ` John Fastabend 2018-05-31 4:42 ` [PATCH bpf-next v4 4/5] selftests/bpf: test_sockmap, fix data verification bhole_prashant_q7 2018-05-31 4:42 ` Prashant Bhole 2018-05-31 4:42 ` [PATCH bpf-next v4 5/5] selftests/bpf: test_sockmap, print additional test options bhole_prashant_q7 2018-05-31 4:42 ` Prashant Bhole 2018-06-02 4:16 ` [PATCH bpf-next v4 0/5] fix test_sockmap daniel 2018-06-02 4:16 ` Daniel Borkmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180531044240.796-3-bhole_prashant_q7@lab.ntt.co.jp \ --to=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).