[PATCH v1] lib/test_list: Follow existing pattern for a file name

[PATCH v1] lib/test_list: Follow existing pattern for a file name

[Andy Shevchenko]

Test in lib/ either KUnit or not are named in the same pattern,
i.e. test_*.c, except few ones. Rename list-test.c to test_list.c
to follow this pattern.

Note, current documentation doesn't specify any file name conventions,
and we glad to stick with a current one in the subsystem.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/Makefile                     | 4 ++--
 lib/{list-test.c => test_list.c} | 0
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename lib/{list-test.c => test_list.c} (100%)

diff --git a/lib/Makefile b/lib/Makefile
index 5ca03ba6ee45..e71abeea4a3e 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
-obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
-obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
 obj-$(CONFIG_BITS_TEST) += test_bits.o
+obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
+obj-$(CONFIG_LIST_KUNIT_TEST) += test_list.o
diff --git a/lib/list-test.c b/lib/test_list.c
similarity index 100%
rename from lib/list-test.c
rename to lib/test_list.c
-- 
2.28.0

Re: [PATCH v1] lib/test_list: Follow existing pattern for a file name

[Andy Shevchenko]

On Thu, Oct 15, 2020 at 04:59:08PM +0300, Andy Shevchenko wrote:
> Test in lib/ either KUnit or not are named in the same pattern,
> i.e. test_*.c, except few ones. Rename list-test.c to test_list.c
> to follow this pattern.
> 
> Note, current documentation doesn't specify any file name conventions,
> and we glad to stick with a current one in the subsystem.

Okay, according to new convention it should be either _test or _kunit. Still
not clear where to put it. New convention tell about nearby to the module it
tests, but this is header file!

Please, update documentation accordingly.

-- 
With Best Regards,
Andy Shevchenko