From: Veronika Kabatova <vkabatov@redhat.com>
To: shuah <shuah@kernel.org>
Cc: sbrivio@redhat.com, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target
Date: Tue, 19 May 2020 15:50:54 -0400 (EDT) [thread overview]
Message-ID: <45315971.23643916.1589917854550.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <cb18f49a-02aa-4a85-a80d-e991254cd6b9@kernel.org>
----- Original Message -----
> From: "shuah" <shuah@kernel.org>
> To: "Veronika Kabatova" <vkabatov@redhat.com>
> Cc: "Veronika Kabatova" <veronicca114@gmail.com>, sbrivio@redhat.com, linux-kselftest@vger.kernel.org, "shuah"
> <shuah@kernel.org>
> Sent: Tuesday, May 19, 2020 8:39:23 PM
> Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target
>
> Hi Veronika,
>
> On 5/6/20 8:56 AM, shuah wrote:
> > On 5/4/20 5:50 AM, Veronika Kabatova wrote:
> >>
> >>
> >> ----- Original Message -----
> >>> From: "shuah" <shuah@kernel.org>
> >>> To: "Veronika Kabatova" <veronicca114@gmail.com>
> >>> Cc: sbrivio@redhat.com, linux-kselftest@vger.kernel.org, "Veronika
> >>> Kabatova" <vkabatov@redhat.com>, "shuah"
> >>> <shuah@kernel.org>
> >>> Sent: Friday, May 1, 2020 4:49:34 PM
> >>> Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target
> >>>
> >>> Hi Veronica,
> >>>
> >>
> >> Hi,
> >>
> >>> On 4/28/20 6:38 AM, Veronika Kabatova wrote:
> >>>> The gen_kselftest_tar.sh always packages *all* selftests and doesn't
> >>>> pass along any variables to `make install` to influence what should be
> >>>> built. This can result in an early error on the command line ("Unknown
> >>>> tarball format TARGETS=XXX"), or unexpected test failures as the
> >>>> tarball contains tests people wanted to skip on purpose.
> >>>>
> >>>> Since the makefile already contains all the logic, we can add a target
> >>>> for packaging. Keep the default .gz target the script uses, and
> >>>> actually
> >>>> extend the supported formats by using tar's autodetection.
> >>>>
> >>>
> >>> Thanks for working on this. gen_kselftest_tar.sh a while back before a
> >>> lot of the install features went in and Makefile supports it fully. It
> >>> makes perfect sense to use Makefile drive this.
> >>>
> >>>> To not break current workflows, keep the gen_kselftest_tar.sh script as
> >>>> it is, with an added suggestion to use the makefile target instead.
> >>>>
> >>>
> >>> Not sure how many people use this. It is a good idea keeping it around
> >>> for now.
> >>>
> >>>> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
>
> There is a mispatch between your from email address and signed-off line.
> Please make sure they match.
>
> Also there is a spelling error in the document.
>
>
> WARNING: 'overriden' may be misspelled - perhaps 'overridden'?
> #125: FILE: Documentation/dev-tools/kselftest.rst:163:
> +default, `.gz` format is used. The tar format can be overriden by
> specifying
>
Thanks for pointing it out.
> WARNING: Missing Signed-off-by: line by nominal patch author 'Veronika
> Kabatova <veronicca114@gmail.com>'
>
Yes, that's because the work email decided to drop some public addresses
and the original patch didn't make it to you or the list. We got it fixed
so I'll send a v2 from there in a minute, sorry for the trouble.
Veronika
> Please fix them and sen me v2.
>
> thanks,
> -- Shuah
>
>
next prev parent reply other threads:[~2020-05-19 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 12:38 [PATCH] selftests: introduce gen_tar Makefile target Veronika Kabatova
2020-05-01 14:49 ` shuah
2020-05-04 11:50 ` Veronika Kabatova
2020-05-06 14:56 ` shuah
2020-05-19 18:39 ` shuah
2020-05-19 19:50 ` Veronika Kabatova [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-28 12:34 Veronika Kabatova
[not found] <20200427192141.2926018-1-vkabatov@redhat.com>
2020-04-27 19:24 ` Stefano Brivio
2020-04-28 0:17 ` shuah
2020-04-28 7:07 ` Stefano Brivio
2020-04-28 12:46 ` Veronika Kabatova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45315971.23643916.1589917854550.JavaMail.zimbra@redhat.com \
--to=vkabatov@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).