Re: [PATCH] selftests: introduce gen_tar Makefile target

[shuah <shuah@kernel.org>]

Hi Veronika,

On 5/6/20 8:56 AM, shuah wrote:
> On 5/4/20 5:50 AM, Veronika Kabatova wrote:
>>
>>
>> ----- Original Message -----
>>> From: "shuah" <shuah@kernel.org>
>>> To: "Veronika Kabatova" <veronicca114@gmail.com>
>>> Cc: sbrivio@redhat.com, linux-kselftest@vger.kernel.org, "Veronika 
>>> Kabatova" <vkabatov@redhat.com>, "shuah"
>>> <shuah@kernel.org>
>>> Sent: Friday, May 1, 2020 4:49:34 PM
>>> Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target
>>>
>>> Hi Veronica,
>>>
>>
>> Hi,
>>
>>> On 4/28/20 6:38 AM, Veronika Kabatova wrote:
>>>> The gen_kselftest_tar.sh always packages *all* selftests and doesn't
>>>> pass along any variables to `make install` to influence what should be
>>>> built. This can result in an early error on the command line ("Unknown
>>>> tarball format TARGETS=XXX"), or unexpected test failures as the
>>>> tarball contains tests people wanted to skip on purpose.
>>>>
>>>> Since the makefile already contains all the logic, we can add a target
>>>> for packaging. Keep the default .gz target the script uses, and 
>>>> actually
>>>> extend the supported formats by using tar's autodetection.
>>>>
>>>
>>> Thanks for working on this. gen_kselftest_tar.sh  a while back before a
>>> lot of the install features went in and Makefile supports it fully. It
>>> makes perfect sense to use Makefile drive this.
>>>
>>>> To not break current workflows, keep the gen_kselftest_tar.sh script as
>>>> it is, with an added suggestion to use the makefile target instead.
>>>>
>>>
>>> Not sure how many people use this. It is a good idea keeping it around
>>> for now.
>>>
>>>> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>

There is a mispatch between your from email address and signed-off line.
Please make sure they match.

Also there is a spelling error in the document.


WARNING: 'overriden' may be misspelled - perhaps 'overridden'?
#125: FILE: Documentation/dev-tools/kselftest.rst:163:
+default, `.gz` format is used. The tar format can be overriden by 
specifying

WARNING: Missing Signed-off-by: line by nominal patch author 'Veronika 
Kabatova <veronicca114@gmail.com>'

Please fix them and sen me v2.

thanks,
-- Shuah