* Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments
2022-06-14 22:41 [PATCH] KVM: selftests: Remove the mismatched parameter comments shaoqin.huang
@ 2022-06-14 7:48 ` Andrew Jones
2022-06-14 8:28 ` Andrew Jones
2022-06-14 17:08 ` Paolo Bonzini
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Jones @ 2022-06-14 7:48 UTC (permalink / raw)
To: shaoqin.huang
Cc: pbonzini, Shuah Khan, Sean Christopherson, David Matlack,
Marc Zyngier, Oliver Upton, Ricardo Koller, Wei Wang,
Peter Gonda, David Dunn, kvm, linux-kselftest, linux-kernel
On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@intel.com wrote:
> From: Shaoqin Huang <shaoqin.huang@intel.com>
>
> There are some parameter being removed in function but the parameter
> comments still exist, so remove them.
>
> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1665a220abcb..58fdc82b20f4 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
> * vm - Virtual Machine
> * sz - Size in bytes
> * vaddr_min - Minimum starting virtual address
> - * data_memslot - Memory region slot for data pages
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
> * vaddr - Virtuall address to map
> * paddr - VM Physical Address
> * npages - The number of pages to map
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
> --
> 2.30.2
>
Hi Shaoqin,
Please check kvm/queue, the extra parameter comments have already been
removed.
Thanks,
drew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments
2022-06-14 7:48 ` Andrew Jones
@ 2022-06-14 8:28 ` Andrew Jones
2022-06-14 8:57 ` Huang, Shaoqin
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Jones @ 2022-06-14 8:28 UTC (permalink / raw)
To: shaoqin.huang
Cc: pbonzini, Shuah Khan, Sean Christopherson, David Matlack,
Marc Zyngier, Oliver Upton, Ricardo Koller, Wei Wang,
Peter Gonda, David Dunn, kvm, linux-kselftest, linux-kernel
On Tue, Jun 14, 2022 at 09:48:35AM +0200, Andrew Jones wrote:
> On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@intel.com wrote:
> > From: Shaoqin Huang <shaoqin.huang@intel.com>
> >
> > There are some parameter being removed in function but the parameter
> > comments still exist, so remove them.
> >
> > Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
> > ---
> > tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> > index 1665a220abcb..58fdc82b20f4 100644
> > --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> > @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
> > * vm - Virtual Machine
> > * sz - Size in bytes
> > * vaddr_min - Minimum starting virtual address
> > - * data_memslot - Memory region slot for data pages
> > - * pgd_memslot - Memory region slot for new virtual translation tables
> > *
> > * Output Args: None
> > *
> > @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
> > * vaddr - Virtuall address to map
> > * paddr - VM Physical Address
> > * npages - The number of pages to map
> > - * pgd_memslot - Memory region slot for new virtual translation tables
> > *
> > * Output Args: None
> > *
> > --
> > 2.30.2
> >
>
> Hi Shaoqin,
>
> Please check kvm/queue, the extra parameter comments have already been
> removed.
>
Eh, never mind, I looked at the wrong functions. Your patch does indeed
apply to kvm/queue and is indeed necessary. Sorry for the noise.
Thanks,
drew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments
2022-06-14 8:28 ` Andrew Jones
@ 2022-06-14 8:57 ` Huang, Shaoqin
0 siblings, 0 replies; 5+ messages in thread
From: Huang, Shaoqin @ 2022-06-14 8:57 UTC (permalink / raw)
To: Andrew Jones
Cc: pbonzini, Shuah Khan, Sean Christopherson, David Matlack,
Marc Zyngier, Oliver Upton, Ricardo Koller, Wei Wang,
Peter Gonda, David Dunn, kvm, linux-kselftest, linux-kernel
Thanks drew's review.
On 6/14/2022 4:28 PM, Andrew Jones wrote:
> On Tue, Jun 14, 2022 at 09:48:35AM +0200, Andrew Jones wrote:
>> On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@intel.com wrote:
>>> From: Shaoqin Huang <shaoqin.huang@intel.com>
>>>
>>> There are some parameter being removed in function but the parameter
>>> comments still exist, so remove them.
>>>
>>> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
>>> ---
>>> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
>>> index 1665a220abcb..58fdc82b20f4 100644
>>> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
>>> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
>>> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
>>> * vm - Virtual Machine
>>> * sz - Size in bytes
>>> * vaddr_min - Minimum starting virtual address
>>> - * data_memslot - Memory region slot for data pages
>>> - * pgd_memslot - Memory region slot for new virtual translation tables
>>> *
>>> * Output Args: None
>>> *
>>> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
>>> * vaddr - Virtuall address to map
>>> * paddr - VM Physical Address
>>> * npages - The number of pages to map
>>> - * pgd_memslot - Memory region slot for new virtual translation tables
>>> *
>>> * Output Args: None
>>> *
>>> --
>>> 2.30.2
>>>
>>
>> Hi Shaoqin,
>>
>> Please check kvm/queue, the extra parameter comments have already been
>> removed.
>>
>
> Eh, never mind, I looked at the wrong functions. Your patch does indeed
> apply to kvm/queue and is indeed necessary. Sorry for the noise.
>
> Thanks,
> drew
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments
2022-06-14 22:41 [PATCH] KVM: selftests: Remove the mismatched parameter comments shaoqin.huang
2022-06-14 7:48 ` Andrew Jones
@ 2022-06-14 17:08 ` Paolo Bonzini
1 sibling, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2022-06-14 17:08 UTC (permalink / raw)
To: shaoqin.huang
Cc: Shuah Khan, Sean Christopherson, Andrew Jones, David Matlack,
Marc Zyngier, Oliver Upton, Ricardo Koller, Wei Wang,
Peter Gonda, David Dunn, kvm, linux-kselftest, linux-kernel
On 6/15/22 00:41, shaoqin.huang@intel.com wrote:
> From: Shaoqin Huang <shaoqin.huang@intel.com>
>
> There are some parameter being removed in function but the parameter
> comments still exist, so remove them.
>
> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1665a220abcb..58fdc82b20f4 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
> * vm - Virtual Machine
> * sz - Size in bytes
> * vaddr_min - Minimum starting virtual address
> - * data_memslot - Memory region slot for data pages
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
> * vaddr - Virtuall address to map
> * paddr - VM Physical Address
> * npages - The number of pages to map
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
Queued, thanks!
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] KVM: selftests: Remove the mismatched parameter comments
@ 2022-06-14 22:41 shaoqin.huang
2022-06-14 7:48 ` Andrew Jones
2022-06-14 17:08 ` Paolo Bonzini
0 siblings, 2 replies; 5+ messages in thread
From: shaoqin.huang @ 2022-06-14 22:41 UTC (permalink / raw)
To: pbonzini
Cc: Shaoqin Huang, Shuah Khan, Sean Christopherson, Andrew Jones,
David Matlack, Marc Zyngier, Oliver Upton, Ricardo Koller,
Wei Wang, Peter Gonda, David Dunn, kvm, linux-kselftest,
linux-kernel
From: Shaoqin Huang <shaoqin.huang@intel.com>
There are some parameter being removed in function but the parameter
comments still exist, so remove them.
Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
---
tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
index 1665a220abcb..58fdc82b20f4 100644
--- a/tools/testing/selftests/kvm/lib/kvm_util.c
+++ b/tools/testing/selftests/kvm/lib/kvm_util.c
@@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
* vm - Virtual Machine
* sz - Size in bytes
* vaddr_min - Minimum starting virtual address
- * data_memslot - Memory region slot for data pages
- * pgd_memslot - Memory region slot for new virtual translation tables
*
* Output Args: None
*
@@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
* vaddr - Virtuall address to map
* paddr - VM Physical Address
* npages - The number of pages to map
- * pgd_memslot - Memory region slot for new virtual translation tables
*
* Output Args: None
*
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-14 17:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 22:41 [PATCH] KVM: selftests: Remove the mismatched parameter comments shaoqin.huang
2022-06-14 7:48 ` Andrew Jones
2022-06-14 8:28 ` Andrew Jones
2022-06-14 8:57 ` Huang, Shaoqin
2022-06-14 17:08 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).