* Re: [PATCH v3 3/7] kunit: tests for stats_fs API
[not found] ` <20200526110318.69006-4-eesposit@redhat.com>
@ 2020-05-27 10:05 ` Alan Maguire
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
0 siblings, 1 reply; 2+ messages in thread
From: Alan Maguire @ 2020-05-27 10:05 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito
Cc: kvm, Christian Borntraeger, Paolo Bonzini, Jim Mattson,
Alexander Viro, Emanuele Giuseppe Esposito, David Rientjes,
Jonathan Adams, linux-doc, linux-kernel, linux-arm-kernel,
linux-mips, kvm-ppc, linuxppc-dev, linux-s390, linux-fsdevel,
netdev, brendanhiggins, linux-kselftest, kunit-dev
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote:
> Add kunit tests to extensively test the stats_fs API functionality.
>
I've added in the kunit-related folks.
> In order to run them, the kernel .config must set CONFIG_KUNIT=y
> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
> and CONFIG_STATS_FS_TEST=y
>
It looks like CONFIG_STATS_FS is built-in, but it exports
much of the functionality you are testing. However could the
tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
a tristate variable)? To test this you'd need to specify
CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
simply be a case of "modprobe"ing the stats fs module and collecting
results in /sys/kernel/debug/kunit/<module_name> (rather
than running kunit.py). Are you relying on unexported internals in
the the tests that would prevent building them as a module?
Thanks!
Alan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 3/7] kunit: tests for stats_fs API
2020-05-27 10:05 ` [PATCH v3 3/7] kunit: tests for stats_fs API Alan Maguire
@ 2020-05-27 13:26 ` Emanuele Giuseppe Esposito
0 siblings, 0 replies; 2+ messages in thread
From: Emanuele Giuseppe Esposito @ 2020-05-27 13:26 UTC (permalink / raw)
To: Alan Maguire
Cc: kvm, Christian Borntraeger, Paolo Bonzini, Jim Mattson,
Alexander Viro, Emanuele Giuseppe Esposito, David Rientjes,
Jonathan Adams, linux-doc, linux-kernel, linux-arm-kernel,
linux-mips, kvm-ppc, linuxppc-dev, linux-s390, linux-fsdevel,
netdev, brendanhiggins, linux-kselftest, kunit-dev
>> In order to run them, the kernel .config must set CONFIG_KUNIT=y
>> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y
>> and CONFIG_STATS_FS_TEST=y
>>
>
> It looks like CONFIG_STATS_FS is built-in, but it exports
> much of the functionality you are testing. However could the
> tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST
> a tristate variable)? To test this you'd need to specify
> CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would
> simply be a case of "modprobe"ing the stats fs module and collecting
> results in /sys/kernel/debug/kunit/<module_name> (rather
> than running kunit.py). Are you relying on unexported internals in
> the the tests that would prevent building them as a module?
>
I haven't checked it yet, but tests should work as separate module.
I will look into it, thanks.
Emanuele
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-27 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200526110318.69006-1-eesposit@redhat.com>
[not found] ` <20200526110318.69006-4-eesposit@redhat.com>
2020-05-27 10:05 ` [PATCH v3 3/7] kunit: tests for stats_fs API Alan Maguire
2020-05-27 13:26 ` Emanuele Giuseppe Esposito
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).