From: Jean-Jacques Hiblot <jjhiblot@ti.com> To: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, dmurphy@ti.com, Jean-Jacques Hiblot <jjhiblot@ti.com>, linux-leds@vger.kernel.org Subject: [PATCH v2 2/4] leds: Add managed API to get a LED from a device driver Date: Mon, 8 Jul 2019 12:26:58 +0200 [thread overview] Message-ID: <20190708102700.23138-3-jjhiblot@ti.com> (raw) In-Reply-To: <20190708102700.23138-1-jjhiblot@ti.com> If the LED is acquired by a consumer device with devm_led_get(), it is automatically release when the device is detach. Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com> --- drivers/leds/led-class.c | 42 ++++++++++++++++++++++++++++++++++++++++ include/linux/leds.h | 2 ++ 2 files changed, 44 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 0f67b13b0f1f..521cb76fbaf7 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -264,6 +264,48 @@ void led_put(struct led_classdev *led_cdev) } EXPORT_SYMBOL_GPL(led_put); +static void devm_led_release(struct device *dev, void *res) +{ + struct led_classdev **p = res; + + led_put(*p); +} + +/** + * devm_led_get - Resource-managed request of a LED device + * @dev: LED consumer + * @idx: index of the LED to obtain in the consumer + * + * The device node of the device is parse to find the request LED device. + * The LED device returned from this function is automatically released + * on driver detach. + * + * @return a pointer to a LED device or ERR_PTR(errno) on failure. + */ +struct led_classdev *__must_check devm_led_get(struct device *dev, + int index) +{ + struct led_classdev *led; + struct led_classdev **dr; + + led = of_led_get(dev->of_node, index); + if (IS_ERR(led)) + return led; + + dr = devres_alloc(devm_led_release, sizeof(struct led_classdev *), + GFP_KERNEL); + if (!dr) { + led_put(led); + return ERR_PTR(-ENOMEM); + } + + *dr = led; + devres_add(dev, dr); + + return led; +} +EXPORT_SYMBOL_GPL(devm_led_get); + static int match_name(struct device *dev, const void *data) { if (!dev_name(dev)) diff --git a/include/linux/leds.h b/include/linux/leds.h index 0a71c7cdd191..7fcec566d774 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -148,6 +148,8 @@ extern void led_classdev_resume(struct led_classdev *led_cdev); extern struct led_classdev *of_led_get(struct device_node *np, int index); extern void led_put(struct led_classdev *led_cdev); +struct led_classdev *__must_check devm_led_get(struct device *dev, + int index); /** * led_blink_set - set blinking with software fallback -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Jacques Hiblot <jjhiblot@ti.com> To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <lee.jones@linaro.org>, <daniel.thompson@linaro.org>, <jingoohan1@gmail.com> Cc: <dmurphy@ti.com>, <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, <tomi.valkeinen@ti.com>, Jean-Jacques Hiblot <jjhiblot@ti.com> Subject: [PATCH v2 2/4] leds: Add managed API to get a LED from a device driver Date: Mon, 8 Jul 2019 12:26:58 +0200 [thread overview] Message-ID: <20190708102700.23138-3-jjhiblot@ti.com> (raw) Message-ID: <20190708102658.yVfhTe2efPHyrxDAJkSmL-peeykk5QdlNCJ-HQGiKxE@z> (raw) In-Reply-To: <20190708102700.23138-1-jjhiblot@ti.com> If the LED is acquired by a consumer device with devm_led_get(), it is automatically release when the device is detach. Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com> --- drivers/leds/led-class.c | 42 ++++++++++++++++++++++++++++++++++++++++ include/linux/leds.h | 2 ++ 2 files changed, 44 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 0f67b13b0f1f..521cb76fbaf7 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -264,6 +264,48 @@ void led_put(struct led_classdev *led_cdev) } EXPORT_SYMBOL_GPL(led_put); +static void devm_led_release(struct device *dev, void *res) +{ + struct led_classdev **p = res; + + led_put(*p); +} + +/** + * devm_led_get - Resource-managed request of a LED device + * @dev: LED consumer + * @idx: index of the LED to obtain in the consumer + * + * The device node of the device is parse to find the request LED device. + * The LED device returned from this function is automatically released + * on driver detach. + * + * @return a pointer to a LED device or ERR_PTR(errno) on failure. + */ +struct led_classdev *__must_check devm_led_get(struct device *dev, + int index) +{ + struct led_classdev *led; + struct led_classdev **dr; + + led = of_led_get(dev->of_node, index); + if (IS_ERR(led)) + return led; + + dr = devres_alloc(devm_led_release, sizeof(struct led_classdev *), + GFP_KERNEL); + if (!dr) { + led_put(led); + return ERR_PTR(-ENOMEM); + } + + *dr = led; + devres_add(dev, dr); + + return led; +} +EXPORT_SYMBOL_GPL(devm_led_get); + static int match_name(struct device *dev, const void *data) { if (!dev_name(dev)) diff --git a/include/linux/leds.h b/include/linux/leds.h index 0a71c7cdd191..7fcec566d774 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -148,6 +148,8 @@ extern void led_classdev_resume(struct led_classdev *led_cdev); extern struct led_classdev *of_led_get(struct device_node *np, int index); extern void led_put(struct led_classdev *led_cdev); +struct led_classdev *__must_check devm_led_get(struct device *dev, + int index); /** * led_blink_set - set blinking with software fallback -- 2.17.1
next prev parent reply other threads:[~2019-07-08 10:26 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-08 10:26 [PATCH v2 0/4] Add a generic driver for LED-based backlight Jean-Jacques Hiblot 2019-07-08 10:26 ` Jean-Jacques Hiblot 2019-07-08 10:26 ` [PATCH v2 1/4] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot 2019-07-08 10:26 ` Jean-Jacques Hiblot 2019-07-08 10:26 ` Jean-Jacques Hiblot [this message] 2019-07-08 10:26 ` [PATCH v2 2/4] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot 2019-07-08 10:26 ` [PATCH v2 3/4] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot 2019-07-08 10:26 ` Jean-Jacques Hiblot 2019-07-08 10:50 ` Daniel Thompson 2019-07-08 10:50 ` Daniel Thompson 2019-07-08 10:27 ` [PATCH v2 4/4] backlight: add led-backlight driver Jean-Jacques Hiblot 2019-07-08 10:27 ` Jean-Jacques Hiblot 2019-07-09 9:31 ` Daniel Thompson 2019-07-09 9:31 ` Daniel Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190708102700.23138-3-jjhiblot@ti.com \ --to=jjhiblot@ti.com \ --cc=daniel.thompson@linaro.org \ --cc=dmurphy@ti.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacek.anaszewski@gmail.com \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).