* [PATCH] leds: gpio: Fix semantic error
@ 2020-07-03 18:13 Linus Walleij
2020-07-12 8:14 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2020-07-03 18:13 UTC (permalink / raw)
To: Jacek Anaszewski, Pavel Machek, Dan Murphy; +Cc: linux-leds, Linus Walleij
The leds-gpio driver mixes up the legacy GPIO flags with the
GPIO descriptor flags and passes a legacy flag to
devm_gpiod_get_index().
Fix this by replacing the flags variable with the strict
descriptor flag.
Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/leds/leds-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 2bf74595610f..200688c602cd 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -220,7 +220,7 @@ static struct gpio_desc *gpio_led_get_gpiod(struct device *dev, int idx,
* device, this will hit the board file, if any and get
* the GPIO from there.
*/
- gpiod = devm_gpiod_get_index(dev, NULL, idx, flags);
+ gpiod = devm_gpiod_get_index(dev, NULL, idx, GPIOD_OUT_LOW);
if (!IS_ERR(gpiod)) {
gpiod_set_consumer_name(gpiod, template->name);
return gpiod;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: gpio: Fix semantic error
2020-07-03 18:13 [PATCH] leds: gpio: Fix semantic error Linus Walleij
@ 2020-07-12 8:14 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2020-07-12 8:14 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jacek Anaszewski, Dan Murphy, linux-leds
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Fri 2020-07-03 20:13:38, Linus Walleij wrote:
> The leds-gpio driver mixes up the legacy GPIO flags with the
> GPIO descriptor flags and passes a legacy flag to
> devm_gpiod_get_index().
>
> Fix this by replacing the flags variable with the strict
> descriptor flag.
>
> Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, applied.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-12 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 18:13 [PATCH] leds: gpio: Fix semantic error Linus Walleij
2020-07-12 8:14 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).