linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Enrico Weigelt, metux IT consult" <info@metux.net>
To: Andreas Eberlein <foodeas@aeberlein.de>,
	Pavel Machek <pavel@ucw.cz>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	post@lespocky.de
Subject: Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware
Date: Thu, 18 Mar 2021 20:51:49 +0100	[thread overview]
Message-ID: <798a0265-7f06-4894-7f84-64db6f236bcd@metux.net> (raw)
In-Reply-To: <20210306165101.fnv6ytqofbolpf6s@falbala.internal.home.lespocky.de>

On 06.03.21 17:51, Alexander Dahl wrote:

Hi,

> If you give me a hint, which tree or patchset should be tested, and
> some hints what should be tested, I can try.

haven't written anything for apu1 yet (as I dont have one), but I wrote
the drivers for apu2/3/4.

My idea (which I never actually started on) was writing a separate gpio
driver (not LED) for the old Soc in apu1 and add instantiation w/ 
leds-gpio, keys, etc, into the pcengines-apu2 driver.

> Thanks for that work.  I have to admit someone from the fli4l linux
> router distribution team also wrote LED and button drivers for the APU
> boards, but never managed to upstream those. :-/
> 
> If someone is interested, those are spread in our Subversion
> repository, but the apu drivers are here:
> 
> https://repo.nettworks.org/svn/fli4l/branches/4.0/trunk/src/packages/src/src/fli4l/hwsupp/pcengines-apu/

hmm, maybe I could pick up pieces for the FCH functionality that's
not supported yet (eg. wdt) ... not sure how much they differ between
different SoC versions.

> Personally, I'd rather have mainline drivers for all that boards.
> Don't know if it still makes sense for the older wrap or alix boards,
> though.  I also have those lying around. ;-)

Well, somebody has to make his hands dirty, write those drivers, bring
them to mainline, and maintain them.


--mtx

-- 
-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

      reply	other threads:[~2021-03-18 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 13:30 [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware Andreas Eberlein
2021-02-17 11:02 ` Enrico Weigelt, metux IT consult
2021-02-19 11:21   ` Pavel Machek
2021-02-19 14:37   ` Petr Štetiar
2021-02-19 20:51     ` Zbyněk Kocur
2021-02-23 20:02       ` Enrico Weigelt, metux IT consult
2021-02-23 21:13         ` Zbyněk Kocur
2021-02-19 20:59     ` Zbyněk Kocur
2021-03-06 16:51   ` Alexander Dahl
2021-03-18 19:51     ` Enrico Weigelt, metux IT consult [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=798a0265-7f06-4894-7f84-64db6f236bcd@metux.net \
    --to=info@metux.net \
    --cc=foodeas@aeberlein.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=post@lespocky.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).