From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Andreas Eberlein <foodeas@aeberlein.de>, Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware
Date: Wed, 17 Feb 2021 12:02:47 +0100 [thread overview]
Message-ID: <c7eebbb6-df0c-51df-7701-ecb8f6543466@metux.net> (raw)
In-Reply-To: <20210216133028.4025-1-foodeas@aeberlein.de>
On 16.02.21 14:30, Andreas Eberlein wrote:
Hi,
> The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed
> from "APU" to "apu1"
>
> This modification adds the missing DMI data and thereby the LED support for
> the PC Engines APU1 with firmware versions >= 4.6.8.
Do you have a device for more intensive testing ?
In that case I'd like to suggest splitting the driver into gpio and
gpio-based LED (using leds-gpio) - just like already I did for apu2/3/4.
Maybe this even could also be moveed into the apu2 driver. This probably
just makes sense if there're more gpio-connected devices than just LED)
Personally, I don't have access to the old apu1 board (IIRC not even
produced anymore for several years), so I didn't dare to touch anything
here.
Note that apu1 vs. apu2/3/4 have completely different SOC with different
gpio logic - that was one of the reasons for writing a completely new
driver for apu2+ from scrath, rather than extending the old one.
> --- a/drivers/leds/leds-apu.c
> +++ b/drivers/leds/leds-apu.c
> @@ -83,6 +83,7 @@ static const struct apu_led_profile apu1_led_profile[] = {
> };
>
> static const struct dmi_system_id apu_led_dmi_table[] __initconst = {
> + /* PC Engines APU with factory bios "SageBios_PCEngines_APU-45" */
> {
> .ident = "apu",
> .matches = {
> @@ -90,6 +91,14 @@ static const struct dmi_system_id apu_led_dmi_table[] __initconst = {
> DMI_MATCH(DMI_PRODUCT_NAME, "APU")
> }
> },
> + /* PC Engines APU with "Mainline" bios >= 4.6.8 */
> + {
> + .ident = "apu",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "apu1")
> + }
> + },
> {}
> };
> MODULE_DEVICE_TABLE(dmi, apu_led_dmi_table);
> @@ -173,7 +182,7 @@ static int __init apu_led_init(void)
> int err;
>
> if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
> - dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> + (dmi_match(DMI_PRODUCT_NAME, "APU") || dmi_match(DMI_PRODUCT_NAME, "apu1")))) {
> pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable CONFIG_PCENGINES_APU2\n");
> return -ENODEV;
> }
>
Looks good to me. But don't dare giving official ack, since I don't
have an apu1 board for testing.
Is Alan Mizrahi (original author) still here ?
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2021-02-17 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 13:30 [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware Andreas Eberlein
2021-02-17 11:02 ` Enrico Weigelt, metux IT consult [this message]
2021-02-19 11:21 ` Pavel Machek
2021-02-19 14:37 ` Petr Štetiar
2021-02-19 20:51 ` Zbyněk Kocur
2021-02-23 20:02 ` Enrico Weigelt, metux IT consult
2021-02-23 21:13 ` Zbyněk Kocur
2021-02-19 20:59 ` Zbyněk Kocur
2021-03-06 16:51 ` Alexander Dahl
2021-03-18 19:51 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7eebbb6-df0c-51df-7701-ecb8f6543466@metux.net \
--to=lkml@metux.net \
--cc=foodeas@aeberlein.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).