linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] m68k: amiga: Use str_plural() to fix Coccinelle warning
@ 2024-03-30 17:57 Thorsten Blum
  2024-04-12 21:57 ` [RESEND PATCH] " Thorsten Blum
  2024-04-29 14:42 ` [PATCH] " Geert Uytterhoeven
  0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2024-03-30 17:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Lukas Bulwahn, Javier Martinez Canillas
  Cc: linux-m68k, linux-kernel, Thorsten Blum

Fixes the following Coccinelle/coccicheck warning reported by
string_choices.cocci:

	opportunity for str_plural(zorro_num_autocon)

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 arch/m68k/amiga/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
index 99718f3dc686..d4b170c861bf 100644
--- a/arch/m68k/amiga/config.c
+++ b/arch/m68k/amiga/config.c
@@ -836,7 +836,7 @@ static void amiga_get_hardware_list(struct seq_file *m)
 		seq_printf(m, "\tZorro II%s AutoConfig: %d Expansion "
 				"Device%s\n",
 				AMIGAHW_PRESENT(ZORRO3) ? "I" : "",
-				zorro_num_autocon, zorro_num_autocon == 1 ? "" : "s");
+				zorro_num_autocon, str_plural(zorro_num_autocon));
 #endif /* CONFIG_ZORRO */
 
 #undef AMIGAHW_ANNOUNCE
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [RESEND PATCH] m68k: amiga: Use str_plural() to fix Coccinelle warning
  2024-03-30 17:57 [PATCH] m68k: amiga: Use str_plural() to fix Coccinelle warning Thorsten Blum
@ 2024-04-12 21:57 ` Thorsten Blum
  2024-04-29 14:42 ` [PATCH] " Geert Uytterhoeven
  1 sibling, 0 replies; 3+ messages in thread
From: Thorsten Blum @ 2024-04-12 21:57 UTC (permalink / raw)
  To: thorsten.blum; +Cc: gregkh, javierm, linux-kernel, linux-m68k, lukas.bulwahn

Fixes the following Coccinelle/coccicheck warning reported by
string_choices.cocci:

	opportunity for str_plural(zorro_num_autocon)

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 arch/m68k/amiga/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
index 99718f3dc686..d4b170c861bf 100644
--- a/arch/m68k/amiga/config.c
+++ b/arch/m68k/amiga/config.c
@@ -836,7 +836,7 @@ static void amiga_get_hardware_list(struct seq_file *m)
 		seq_printf(m, "\tZorro II%s AutoConfig: %d Expansion "
 				"Device%s\n",
 				AMIGAHW_PRESENT(ZORRO3) ? "I" : "",
-				zorro_num_autocon, zorro_num_autocon == 1 ? "" : "s");
+				zorro_num_autocon, str_plural(zorro_num_autocon));
 #endif /* CONFIG_ZORRO */
 
 #undef AMIGAHW_ANNOUNCE
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] m68k: amiga: Use str_plural() to fix Coccinelle warning
  2024-03-30 17:57 [PATCH] m68k: amiga: Use str_plural() to fix Coccinelle warning Thorsten Blum
  2024-04-12 21:57 ` [RESEND PATCH] " Thorsten Blum
@ 2024-04-29 14:42 ` Geert Uytterhoeven
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-04-29 14:42 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: Greg Kroah-Hartman, Lukas Bulwahn, Javier Martinez Canillas,
	linux-m68k, linux-kernel

On Sat, Mar 30, 2024 at 6:58 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
> Fixes the following Coccinelle/coccicheck warning reported by
> string_choices.cocci:
>
>         opportunity for str_plural(zorro_num_autocon)
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k tree for v6.10.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-29 14:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-30 17:57 [PATCH] m68k: amiga: Use str_plural() to fix Coccinelle warning Thorsten Blum
2024-04-12 21:57 ` [RESEND PATCH] " Thorsten Blum
2024-04-29 14:42 ` [PATCH] " Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).