linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: coda: Use full device name for request_irq()
@ 2014-04-26  9:14 Alexander Shiyan
  2014-04-29 16:40 ` Philipp Zabel
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2014-04-26  9:14 UTC (permalink / raw)
  To: linux-media
  Cc: Mauro Carvalho Chehab, Philipp Zabel, Kamil Debski, Alexander Shiyan

This will help to debug driver, allows us to see the full name of
the device through /proc/interrupts.

           CPU0
...
 69:          0  mxc-avic  53  10023000.coda
...

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/media/platform/coda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index 3e5199e..11023b1 100644
--- a/drivers/media/platform/coda.c
+++ b/drivers/media/platform/coda.c
@@ -3235,7 +3235,7 @@ static int coda_probe(struct platform_device *pdev)
 	}
 
 	if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
-		IRQF_ONESHOT, CODA_NAME, dev) < 0) {
+		IRQF_ONESHOT, dev_name(&pdev->dev), dev) < 0) {
 		dev_err(&pdev->dev, "failed to request irq\n");
 		return -ENOENT;
 	}
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: coda: Use full device name for request_irq()
  2014-04-26  9:14 [PATCH] media: coda: Use full device name for request_irq() Alexander Shiyan
@ 2014-04-29 16:40 ` Philipp Zabel
  0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2014-04-29 16:40 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: linux-media, Mauro Carvalho Chehab, Kamil Debski

Am Samstag, den 26.04.2014, 13:14 +0400 schrieb Alexander Shiyan:
> This will help to debug driver, allows us to see the full name of
> the device through /proc/interrupts.
> 
>            CPU0
> ...
>  69:          0  mxc-avic  53  10023000.coda
> ...
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

> ---
>  drivers/media/platform/coda.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> index 3e5199e..11023b1 100644
> --- a/drivers/media/platform/coda.c
> +++ b/drivers/media/platform/coda.c
> @@ -3235,7 +3235,7 @@ static int coda_probe(struct platform_device *pdev)
>  	}
>  
>  	if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
> -		IRQF_ONESHOT, CODA_NAME, dev) < 0) {
> +		IRQF_ONESHOT, dev_name(&pdev->dev), dev) < 0) {
>  		dev_err(&pdev->dev, "failed to request irq\n");
>  		return -ENOENT;
>  	}

regards
Philipp


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-29 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-26  9:14 [PATCH] media: coda: Use full device name for request_irq() Alexander Shiyan
2014-04-29 16:40 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).