linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: media: lirc: fix coding style error
@ 2015-06-17 12:31 Sunil Shahu
  2015-06-19  8:02 ` Dan Carpenter
  0 siblings, 1 reply; 6+ messages in thread
From: Sunil Shahu @ 2015-06-17 12:31 UTC (permalink / raw)
  To: mchehab
  Cc: jarod, gregkh, hamohammed.sa, tapaswenipathak, arnd, gulsah.1004,
	aybuke.147, dan.carpenter, mahfouz.saif.elyazal,
	amber.rose.thrall, linux-media, devel, linux-kernel

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/media/lirc/lirc_sasem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..12aae72 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
 		       __func__, retval);
 	else
 		dev_info(&context->dev->dev,
-		         "Deregistered Sasem driver (minor:%d)\n", minor);
+			"Deregistered Sasem driver (minor:%d)\n", minor);
 
 }
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: media: lirc: fix coding style error
  2015-06-17 12:31 [PATCH] staging: media: lirc: fix coding style error Sunil Shahu
@ 2015-06-19  8:02 ` Dan Carpenter
  2015-06-19  8:42   ` Sunil Shahu
  2015-06-19  8:52   ` Sunil Shahu
  0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-06-19  8:02 UTC (permalink / raw)
  To: Sunil Shahu
  Cc: mchehab, devel, hamohammed.sa, arnd, tapaswenipathak, gregkh,
	jarod, gulsah.1004, amber.rose.thrall, linux-kernel, linux-media

On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
> 
> Signed-off-by: Sunil Shahu <shshahu@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_sasem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
> index 8ebee96..12aae72 100644
> --- a/drivers/staging/media/lirc/lirc_sasem.c
> +++ b/drivers/staging/media/lirc/lirc_sasem.c
> @@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
>  		       __func__, retval);
>  	else
>  		dev_info(&context->dev->dev,
> -		         "Deregistered Sasem driver (minor:%d)\n", minor);
> +			"Deregistered Sasem driver (minor:%d)\n", minor);

Not quite.  The original is:

[tab][tab][space][space][space][space][space][space][space][space][space]"Dere...

You have:

[tab][tab][tab]"Deregistered Sasem driver ...

It should be:

[tab][tab][tab][space]"Deregistered Sasem driver (minor:%d)\n", minor);

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] staging: media: lirc: fix coding style error
  2015-06-19  8:02 ` Dan Carpenter
@ 2015-06-19  8:42   ` Sunil Shahu
  2015-06-19  8:52   ` Sunil Shahu
  1 sibling, 0 replies; 6+ messages in thread
From: Sunil Shahu @ 2015-06-19  8:42 UTC (permalink / raw)
  To: mchehab
  Cc: jarod, gregkh, hamohammed.sa, tapaswenipathak, arnd, gulsah.1004,
	aybuke.147, dan.carpenter, mahfouz.saif.elyazal,
	amber.rose.thrall, linux-media, devel, linux-kernel

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/media/lirc/lirc_sasem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..12aae72 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
 		       __func__, retval);
 	else
 		dev_info(&context->dev->dev,
-		         "Deregistered Sasem driver (minor:%d)\n", minor);
+			"Deregistered Sasem driver (minor:%d)\n", minor);
 
 }
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] staging: media: lirc: fix coding style error
  2015-06-19  8:02 ` Dan Carpenter
  2015-06-19  8:42   ` Sunil Shahu
@ 2015-06-19  8:52   ` Sunil Shahu
  2015-06-19 14:05     ` Sudip Mukherjee
  1 sibling, 1 reply; 6+ messages in thread
From: Sunil Shahu @ 2015-06-19  8:52 UTC (permalink / raw)
  To: mchehab
  Cc: jarod, gregkh, hamohammed.sa, tapaswenipathak, arnd, gulsah.1004,
	aybuke.147, dan.carpenter, mahfouz.saif.elyazal,
	amber.rose.thrall, linux-media, devel, linux-kernel

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/media/lirc/lirc_sasem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..c14ca7e 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
 		       __func__, retval);
 	else
 		dev_info(&context->dev->dev,
-		         "Deregistered Sasem driver (minor:%d)\n", minor);
+			 "Deregistered Sasem driver (minor:%d)\n", minor);
 
 }
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] staging: media: lirc: fix coding style error
  2015-06-19  8:52   ` Sunil Shahu
@ 2015-06-19 14:05     ` Sudip Mukherjee
  2015-06-20  8:53       ` [PATCH v2] " Sunil Shahu
  0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-06-19 14:05 UTC (permalink / raw)
  To: Sunil Shahu
  Cc: mchehab, devel, hamohammed.sa, arnd, tapaswenipathak, gregkh,
	jarod, gulsah.1004, amber.rose.thrall, linux-kernel,
	dan.carpenter, linux-media

On Fri, Jun 19, 2015 at 02:22:02PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
> 
> Signed-off-by: Sunil Shahu <shshahu@gmail.com>
when you are sending a modified patch, please mark it as [PATCH v2]
otherwise it becomes confusing.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] staging: media: lirc: fix coding style error
  2015-06-19 14:05     ` Sudip Mukherjee
@ 2015-06-20  8:53       ` Sunil Shahu
  0 siblings, 0 replies; 6+ messages in thread
From: Sunil Shahu @ 2015-06-20  8:53 UTC (permalink / raw)
  To: mchehab
  Cc: jarod, gregkh, hamohammed.sa, tapaswenipathak, arnd, gulsah.1004,
	aybuke.147, dan.carpenter, mahfouz.saif.elyazal,
	amber.rose.thrall, linux-media, devel, linux-kernel

Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/media/lirc/lirc_sasem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..c14ca7e 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
 		       __func__, retval);
 	else
 		dev_info(&context->dev->dev,
-		         "Deregistered Sasem driver (minor:%d)\n", minor);
+			 "Deregistered Sasem driver (minor:%d)\n", minor);
 
 }
 
-- 
1.7.9.5


---
This email has been checked for viruses by Avast antivirus software.
http://www.avast.com

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-06-20  8:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-17 12:31 [PATCH] staging: media: lirc: fix coding style error Sunil Shahu
2015-06-19  8:02 ` Dan Carpenter
2015-06-19  8:42   ` Sunil Shahu
2015-06-19  8:52   ` Sunil Shahu
2015-06-19 14:05     ` Sudip Mukherjee
2015-06-20  8:53       ` [PATCH v2] " Sunil Shahu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).