* [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon
@ 2015-08-05 5:17 Pradheep Shrinivasan
0 siblings, 0 replies; 5+ messages in thread
From: Pradheep Shrinivasan @ 2015-08-05 5:17 UTC (permalink / raw)
To: Jarod Wilson, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, devel, pradheep
From: pradheep <pradheep.sh@gmail.com>
This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan <pradheep.sh@gmail.com>
---
drivers/staging/media/lirc/lirc_imon.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 62ec9f7..05d47dc 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -785,13 +785,13 @@ static int imon_probe(struct usb_interface *interface,
}
driver = kzalloc(sizeof(struct lirc_driver), GFP_KERNEL);
- if (!driver) {
+ if (!driver)
goto free_context;
- }
+
rbuf = kmalloc(sizeof(struct lirc_buffer), GFP_KERNEL);
- if (!rbuf) {
+ if (!rbuf)
goto free_driver;
- }
+
if (lirc_buffer_init(rbuf, BUF_CHUNK_SIZE, BUF_SIZE)) {
dev_err(dev, "%s: lirc_buffer_init failed\n", __func__);
goto free_rbuf;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon
2015-08-05 5:14 Pradheep Shrinivasan
@ 2015-08-05 5:45 ` Sudip Mukherjee
0 siblings, 0 replies; 5+ messages in thread
From: Sudip Mukherjee @ 2015-08-05 5:45 UTC (permalink / raw)
To: Pradheep Shrinivasan
Cc: Jarod Wilson, Mauro Carvalho Chehab, Greg Kroah-Hartman, devel,
linux-media
On Wed, Aug 05, 2015 at 12:14:55AM -0500, Pradheep Shrinivasan wrote:
> From: pradheep <pradheep.sh@gmail.com>
Dan had previously told you that it is wrong.
Here From: line is only required if you are not able to configure the
email From: header while using some corporate server. But your email
From: header is ok.
regards
sudip
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon
@ 2015-08-05 5:14 Pradheep Shrinivasan
2015-08-05 5:45 ` Sudip Mukherjee
0 siblings, 1 reply; 5+ messages in thread
From: Pradheep Shrinivasan @ 2015-08-05 5:14 UTC (permalink / raw)
To: Jarod Wilson, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, devel, pradheep
From: pradheep <pradheep.sh@gmail.com>
This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan <pradheep.sh@gmail.com>
---
drivers/staging/media/lirc/lirc_imon.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 62ec9f7..05d47dc 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -785,13 +785,13 @@ static int imon_probe(struct usb_interface *interface,
}
driver = kzalloc(sizeof(struct lirc_driver), GFP_KERNEL);
- if (!driver) {
+ if (!driver)
goto free_context;
- }
+
rbuf = kmalloc(sizeof(struct lirc_buffer), GFP_KERNEL);
- if (!rbuf) {
+ if (!rbuf)
goto free_driver;
- }
+
if (lirc_buffer_init(rbuf, BUF_CHUNK_SIZE, BUF_SIZE)) {
dev_err(dev, "%s: lirc_buffer_init failed\n", __func__);
goto free_rbuf;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon
2015-08-03 7:56 [PATCH 1/2] staging:media:lirc " Pradheep Shrinivasan
@ 2015-08-03 8:25 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-08-03 8:25 UTC (permalink / raw)
To: Pradheep Shrinivasan
Cc: Jarod Wilson, Greg Kroah-Hartman, devel, Tapasweni Pathak,
linux-media, Mauro Carvalho Chehab
Normally, I wait overnight between writing a patch and sending it.
There is no rush and the delay helps me to be more careful.
The subject is still not perfect. Do:
git log --oneline drivers/staging/media/lirc/lirc_imon.c
On Mon, Aug 03, 2015 at 02:56:31AM -0500, Pradheep Shrinivasan wrote:
> From: pradheep <pradheep.sh@gmail.com>
This is still wrong.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon
@ 2015-08-03 7:56 Pradheep Shrinivasan
2015-08-03 8:25 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Pradheep Shrinivasan @ 2015-08-03 7:56 UTC (permalink / raw)
To: Jarod Wilson, Greg Kroah-Hartman
Cc: Mauro Carvalho Chehab, Tapasweni Pathak, linux-media, devel, pradheep
From: pradheep <pradheep.sh@gmail.com>
This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan <pradheep.sh@gmail.com>
---
drivers/staging/media/lirc/lirc_imon.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 62ec9f7..05d47dc 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -785,13 +785,13 @@ static int imon_probe(struct usb_interface *interface,
}
driver = kzalloc(sizeof(struct lirc_driver), GFP_KERNEL);
- if (!driver) {
+ if (!driver)
goto free_context;
- }
+
rbuf = kmalloc(sizeof(struct lirc_buffer), GFP_KERNEL);
- if (!rbuf) {
+ if (!rbuf)
goto free_driver;
- }
+
if (lirc_buffer_init(rbuf, BUF_CHUNK_SIZE, BUF_SIZE)) {
dev_err(dev, "%s: lirc_buffer_init failed\n", __func__);
goto free_rbuf;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-05 5:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-05 5:17 [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon Pradheep Shrinivasan
-- strict thread matches above, loose matches on Subject: below --
2015-08-05 5:14 Pradheep Shrinivasan
2015-08-05 5:45 ` Sudip Mukherjee
2015-08-03 7:56 [PATCH 1/2] staging:media:lirc " Pradheep Shrinivasan
2015-08-03 8:25 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).