* [PATCH v3 1/2] Staging: ft1000: ft1000-usb: use USB API functions rather than constants
@ 2015-08-06 9:54 Shraddha Barke
2015-08-06 9:54 ` [PATCH v3 2/2] Staging: media: lirc: " Shraddha Barke
0 siblings, 1 reply; 2+ messages in thread
From: Shraddha Barke @ 2015-08-06 9:54 UTC (permalink / raw)
To: Marek Belisko, Greg Kroah-Hartman, Jarod Wilson,
Mauro Carvalho Chehab, Joe Perches, Peter Karlsson,
Tapasweni Pathak, Aya Mahfouz, Tina Johnson, linux-media,
linux-kernel
Cc: Shraddha Barke
This patch introduces the use of the function usb_endpoint_is_bulk_in().
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Changes in v3:
-Change in commit message and add use of function usb_endpoint_is_bulk_in().
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
index fd255c6..d1ba0b8 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
@@ -111,17 +111,13 @@ static int ft1000_probe(struct usb_interface *interface,
pr_debug("endpoint %d\n", i);
pr_debug("bEndpointAddress=%x, bmAttributes=%x\n",
endpoint->bEndpointAddress, endpoint->bmAttributes);
- if ((endpoint->bEndpointAddress & USB_DIR_IN)
- && ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
- USB_ENDPOINT_XFER_BULK)) {
+ if (usb_endpoint_is_bulk_in(endpoint)) {
ft1000dev->bulk_in_endpointAddr =
endpoint->bEndpointAddress;
pr_debug("in: %d\n", endpoint->bEndpointAddress);
}
- if (!(endpoint->bEndpointAddress & USB_DIR_IN)
- && ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) ==
- USB_ENDPOINT_XFER_BULK)) {
+ if (usb_endpoint_is_bulk_in(endpoint)) {
ft1000dev->bulk_out_endpointAddr =
endpoint->bEndpointAddress;
pr_debug("out: %d\n", endpoint->bEndpointAddress);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v3 2/2] Staging: media: lirc: use USB API functions rather than constants
2015-08-06 9:54 [PATCH v3 1/2] Staging: ft1000: ft1000-usb: use USB API functions rather than constants Shraddha Barke
@ 2015-08-06 9:54 ` Shraddha Barke
0 siblings, 0 replies; 2+ messages in thread
From: Shraddha Barke @ 2015-08-06 9:54 UTC (permalink / raw)
To: Marek Belisko, Greg Kroah-Hartman, Jarod Wilson,
Mauro Carvalho Chehab, Joe Perches, Peter Karlsson,
Tapasweni Pathak, Aya Mahfouz, Tina Johnson, linux-media,
linux-kernel
Cc: Shraddha Barke
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Changes in v3:
-No changes.
drivers/staging/media/lirc/lirc_imon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 62ec9f7..cbeec83 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -739,7 +739,7 @@ static int imon_probe(struct usb_interface *interface,
ep = &iface_desc->endpoint[i].desc;
ep_dir = ep->bEndpointAddress & USB_ENDPOINT_DIR_MASK;
- ep_type = ep->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK;
+ ep_type = usb_endpoint_type(ep);
if (!ir_ep_found &&
ep_dir == USB_DIR_IN &&
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-06 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-06 9:54 [PATCH v3 1/2] Staging: ft1000: ft1000-usb: use USB API functions rather than constants Shraddha Barke
2015-08-06 9:54 ` [PATCH v3 2/2] Staging: media: lirc: " Shraddha Barke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).