* [PATCH 1/1] x86: Fix reading the current exposure value of UVC
@ 2015-10-18 21:01 Anton V. Shokurov
2015-10-20 20:44 ` Шокуров Антон
2015-10-26 3:25 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Anton V. Shokurov @ 2015-10-18 21:01 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, linux-media
Cc: linux-kernel, Anton V . Shokurov
V4L2_CID_EXPOSURE_ABSOLUTE property does not return an updated value when
autoexposure (V4L2_CID_EXPOSURE_AUTO) is turned on. This patch fixes this
issue by adding the UVC_CTRL_FLAG_AUTO_UPDATE flag.
Tested on a C920 camera.
Signed-off-by: Anton V. Shokurov <shokurov.anton.v@yandex.ru>
---
drivers/media/usb/uvc/uvc_ctrl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index 3e59b28..c2ee6e3 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -227,7 +227,8 @@ static struct uvc_control_info uvc_ctrls[] = {
.size = 4,
.flags = UVC_CTRL_FLAG_SET_CUR
| UVC_CTRL_FLAG_GET_RANGE
- | UVC_CTRL_FLAG_RESTORE,
+ | UVC_CTRL_FLAG_RESTORE
+ | UVC_CTRL_FLAG_AUTO_UPDATE,
},
{
.entity = UVC_GUID_UVC_CAMERA,
--
2.6.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] x86: Fix reading the current exposure value of UVC
2015-10-18 21:01 [PATCH 1/1] x86: Fix reading the current exposure value of UVC Anton V. Shokurov
@ 2015-10-20 20:44 ` Шокуров Антон
2015-10-26 3:25 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Шокуров Антон @ 2015-10-20 20:44 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, linux-media; +Cc: linux-kernel
Hello!
Have you received my patch? When will it be included in the kernel?
Thanks!
19.10.2015, 00:02, "Anton V. Shokurov" <shokurov.anton.v@yandex.ru>:
> V4L2_CID_EXPOSURE_ABSOLUTE property does not return an updated value when
> autoexposure (V4L2_CID_EXPOSURE_AUTO) is turned on. This patch fixes this
> issue by adding the UVC_CTRL_FLAG_AUTO_UPDATE flag.
>
> Tested on a C920 camera.
>
> Signed-off-by: Anton V. Shokurov <shokurov.anton.v@yandex.ru>
> ---
> drivers/media/usb/uvc/uvc_ctrl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> index 3e59b28..c2ee6e3 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -227,7 +227,8 @@ static struct uvc_control_info uvc_ctrls[] = {
> .size = 4,
> .flags = UVC_CTRL_FLAG_SET_CUR
> | UVC_CTRL_FLAG_GET_RANGE
> - | UVC_CTRL_FLAG_RESTORE,
> + | UVC_CTRL_FLAG_RESTORE
> + | UVC_CTRL_FLAG_AUTO_UPDATE,
> },
> {
> .entity = UVC_GUID_UVC_CAMERA,
> --
> 2.6.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] x86: Fix reading the current exposure value of UVC
2015-10-18 21:01 [PATCH 1/1] x86: Fix reading the current exposure value of UVC Anton V. Shokurov
2015-10-20 20:44 ` Шокуров Антон
@ 2015-10-26 3:25 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2015-10-26 3:25 UTC (permalink / raw)
To: Anton V. Shokurov; +Cc: Mauro Carvalho Chehab, linux-media, linux-kernel
Hi Anton,
Thank you for the patch.
On Sunday 18 October 2015 17:01:26 Anton V. Shokurov wrote:
> V4L2_CID_EXPOSURE_ABSOLUTE property does not return an updated value when
> autoexposure (V4L2_CID_EXPOSURE_AUTO) is turned on. This patch fixes this
> issue by adding the UVC_CTRL_FLAG_AUTO_UPDATE flag.
>
> Tested on a C920 camera.
This looks good to me and I've successfully tested the patch.
> Signed-off-by: Anton V. Shokurov <shokurov.anton.v@yandex.ru>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to my tree, I'll push it upstream for v4.5 (the merge window for v4.4
will open in a week only and with the Kernel Summit going on this week pushing
patches for v4.4 is difficult).
> ---
> drivers/media/usb/uvc/uvc_ctrl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c
> b/drivers/media/usb/uvc/uvc_ctrl.c index 3e59b28..c2ee6e3 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -227,7 +227,8 @@ static struct uvc_control_info uvc_ctrls[] = {
> .size = 4,
> .flags = UVC_CTRL_FLAG_SET_CUR
>
> | UVC_CTRL_FLAG_GET_RANGE
>
> - | UVC_CTRL_FLAG_RESTORE,
> + | UVC_CTRL_FLAG_RESTORE
> + | UVC_CTRL_FLAG_AUTO_UPDATE,
> },
> {
> .entity = UVC_GUID_UVC_CAMERA,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-26 3:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-18 21:01 [PATCH 1/1] x86: Fix reading the current exposure value of UVC Anton V. Shokurov
2015-10-20 20:44 ` Шокуров Антон
2015-10-26 3:25 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).