linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] adv7604: fix SPA register location for ADV7612
@ 2016-02-17 14:57 Ulrich Hecht
  0 siblings, 0 replies; only message in thread
From: Ulrich Hecht @ 2016-02-17 14:57 UTC (permalink / raw)
  To: linux-media
  Cc: linux-renesas-soc, magnus.damm, laurent.pinchart, hans.verkuil,
	ian.molton, lars, william.towle, Ulrich Hecht

SPA location LSB register is at 0x70.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
As suggested by Lars-Peter, this applies the change to the ADV7611 case as
well.

 drivers/media/i2c/adv7604.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 2097c48..1680c0e 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -2110,7 +2110,8 @@ static int adv76xx_set_edid(struct v4l2_subdev *sd, struct v4l2_edid *edid)
 		rep_write(sd, 0x76, spa_loc & 0xff);
 		rep_write_clr_set(sd, 0x77, 0x40, (spa_loc & 0x100) >> 2);
 	} else {
-		/* FIXME: Where is the SPA location LSB register ? */
+		/* ADV7612 Software Manual Rev. A, p. 15 */
+		rep_write(sd, 0x70, spa_loc & 0xff);
 		rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
 	}
 
-- 
2.6.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-17 14:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 14:57 [PATCH v2] adv7604: fix SPA register location for ADV7612 Ulrich Hecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).