* [PATCH] m5mols: Replace missing header
@ 2014-05-25 19:54 Laurent Pinchart
2014-05-26 9:04 ` Sylwester Nawrocki
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-25 19:54 UTC (permalink / raw)
To: linux-media
The include/media/s5p_fimc.h header has been removed in commit
49b2f4c56fbf70ca693d6df1c491f0566d516aea ("exynos4-is: Remove support
for non-dt platforms"). This broke compilation of the m5mols driver.
Include the include/media/exynos-fimc.h header instead, which contains
the S5P_FIMC_TX_END_NOTIFY definition required by the driver.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/m5mols/m5mols_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(Resending to linux-media has the original patch seems not to have made it to
the list for an unknown reason.)
This is a regression in Mauro's latest master branch.
diff --git a/drivers/media/i2c/m5mols/m5mols_capture.c b/drivers/media/i2c/m5mols/m5mols_capture.c
index ab34cce..1a03d02 100644
--- a/drivers/media/i2c/m5mols/m5mols_capture.c
+++ b/drivers/media/i2c/m5mols/m5mols_capture.c
@@ -26,7 +26,7 @@
#include <media/v4l2-device.h>
#include <media/v4l2-subdev.h>
#include <media/m5mols.h>
-#include <media/s5p_fimc.h>
+#include <media/exynos-fimc.h>
#include "m5mols.h"
#include "m5mols_reg.h"
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] m5mols: Replace missing header
2014-05-25 19:54 [PATCH] m5mols: Replace missing header Laurent Pinchart
@ 2014-05-26 9:04 ` Sylwester Nawrocki
2014-05-26 9:29 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Sylwester Nawrocki @ 2014-05-26 9:04 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, Hans Verkuil
Hi Laurent,
On 25/05/14 21:54, Laurent Pinchart wrote:
> The include/media/s5p_fimc.h header has been removed in commit
> 49b2f4c56fbf70ca693d6df1c491f0566d516aea ("exynos4-is: Remove support
> for non-dt platforms"). This broke compilation of the m5mols driver.
>
> Include the include/media/exynos-fimc.h header instead, which contains
> the S5P_FIMC_TX_END_NOTIFY definition required by the driver.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks for the fix. I though about adding to this patch:
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
But it seems the patch is already in Mauro's tree.
> ---
> drivers/media/i2c/m5mols/m5mols_capture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> (Resending to linux-media has the original patch seems not to have made it to
> the list for an unknown reason.)
>
> This is a regression in Mauro's latest master branch.
>
> diff --git a/drivers/media/i2c/m5mols/m5mols_capture.c b/drivers/media/i2c/m5mols/m5mols_capture.c
> index ab34cce..1a03d02 100644
> --- a/drivers/media/i2c/m5mols/m5mols_capture.c
> +++ b/drivers/media/i2c/m5mols/m5mols_capture.c
> @@ -26,7 +26,7 @@
> #include <media/v4l2-device.h>
> #include <media/v4l2-subdev.h>
> #include <media/m5mols.h>
> -#include <media/s5p_fimc.h>
> +#include <media/exynos-fimc.h>
>
> #include "m5mols.h"
> #include "m5mols_reg.h"
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] m5mols: Replace missing header
2014-05-26 9:04 ` Sylwester Nawrocki
@ 2014-05-26 9:29 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-26 9:29 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: linux-media, Hans Verkuil
Hi Sylwester,
On Monday 26 May 2014 11:04:12 Sylwester Nawrocki wrote:
> On 25/05/14 21:54, Laurent Pinchart wrote:
> > The include/media/s5p_fimc.h header has been removed in commit
> > 49b2f4c56fbf70ca693d6df1c491f0566d516aea ("exynos4-is: Remove support
> > for non-dt platforms"). This broke compilation of the m5mols driver.
> >
> > Include the include/media/exynos-fimc.h header instead, which contains
> > the S5P_FIMC_TX_END_NOTIFY definition required by the driver.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks for the fix.
You're welcome. I just happened to run across the problem while compiling my
tree, it didn't take long to fix it :-)
> I though about adding to this patch:
>
> Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> But it seems the patch is already in Mauro's tree.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-26 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-25 19:54 [PATCH] m5mols: Replace missing header Laurent Pinchart
2014-05-26 9:04 ` Sylwester Nawrocki
2014-05-26 9:29 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).