linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT FIXES FOR v3.19] smiapp compile fix for non-OF configuration
@ 2015-01-27 10:36 Sakari Ailus
  2015-01-29 20:00 ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2015-01-27 10:36 UTC (permalink / raw)
  To: linux-media; +Cc: hverkuil

Hi Mauro,

The recent smiapp OF support patches contained a small issue related to
reading 64-bit numbers from the device tree, such that the compilation fails
if CONFIG_OF is undefined.

This patch provides a temporary fix to the matter. The proper one is to use
of_property_read_u64_array(), but that's currently not exported. I've
submitted a patch for that.

Please pull.


The following changes since commit e32b31ae45c18679c186e67aa41d0e2318cae487:

  [media] mb86a20s: remove unused debug modprobe parameter (2015-01-26 10:08:29 -0200)

are available in the git repository at:

  ssh://linuxtv.org/git/sailus/media_tree.git smiapp-of-compile

for you to fetch changes up to 45fe24236dd638b170a7ca91a3aa0e9b2b153889:

  smiapp: Don't compile of_read_number() if CONFIG_OF isn't defined (2015-01-27 12:18:49 +0200)

----------------------------------------------------------------
Sakari Ailus (1):
      smiapp: Don't compile of_read_number() if CONFIG_OF isn't defined

 drivers/media/i2c/smiapp/smiapp-core.c |    4 ++++
 1 file changed, 4 insertions(+)

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT FIXES FOR v3.19] smiapp compile fix for non-OF configuration
  2015-01-27 10:36 [GIT FIXES FOR v3.19] smiapp compile fix for non-OF configuration Sakari Ailus
@ 2015-01-29 20:00 ` Mauro Carvalho Chehab
  2015-02-03 12:00   ` Sakari Ailus
  0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2015-01-29 20:00 UTC (permalink / raw)
  To: Sakari Ailus; +Cc: linux-media, hverkuil

Em Tue, 27 Jan 2015 12:36:49 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:

> Hi Mauro,
> 
> The recent smiapp OF support patches contained a small issue related to
> reading 64-bit numbers from the device tree, such that the compilation fails
> if CONFIG_OF is undefined.
> 
> This patch provides a temporary fix to the matter. The proper one is to use
> of_property_read_u64_array(), but that's currently not exported. I've
> submitted a patch for that.

Didn't apply at fixes, so I applied it at the master development branch.

If this is really needed for 3.19, please backport against 3.19-rc6.

Regards,
Mauro

> 
> Please pull.
> 
> 
> The following changes since commit e32b31ae45c18679c186e67aa41d0e2318cae487:
> 
>   [media] mb86a20s: remove unused debug modprobe parameter (2015-01-26 10:08:29 -0200)
> 
> are available in the git repository at:
> 
>   ssh://linuxtv.org/git/sailus/media_tree.git smiapp-of-compile
> 
> for you to fetch changes up to 45fe24236dd638b170a7ca91a3aa0e9b2b153889:
> 
>   smiapp: Don't compile of_read_number() if CONFIG_OF isn't defined (2015-01-27 12:18:49 +0200)
> 
> ----------------------------------------------------------------
> Sakari Ailus (1):
>       smiapp: Don't compile of_read_number() if CONFIG_OF isn't defined
> 
>  drivers/media/i2c/smiapp/smiapp-core.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT FIXES FOR v3.19] smiapp compile fix for non-OF configuration
  2015-01-29 20:00 ` Mauro Carvalho Chehab
@ 2015-02-03 12:00   ` Sakari Ailus
  0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2015-02-03 12:00 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media, hverkuil

Hi Mauro,

On Thu, Jan 29, 2015 at 06:00:55PM -0200, Mauro Carvalho Chehab wrote:
> Em Tue, 27 Jan 2015 12:36:49 +0200
> Sakari Ailus <sakari.ailus@iki.fi> escreveu:
> 
> > Hi Mauro,
> > 
> > The recent smiapp OF support patches contained a small issue related to
> > reading 64-bit numbers from the device tree, such that the compilation fails
> > if CONFIG_OF is undefined.
> > 
> > This patch provides a temporary fix to the matter. The proper one is to use
> > of_property_read_u64_array(), but that's currently not exported. I've
> > submitted a patch for that.
> 
> Didn't apply at fixes, so I applied it at the master development branch.
> 
> If this is really needed for 3.19, please backport against 3.19-rc6.

Indeed; the master branch is where it belongs to. Thanks!

v3.19 will not have OF support yet so it's fine.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-03 12:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 10:36 [GIT FIXES FOR v3.19] smiapp compile fix for non-OF configuration Sakari Ailus
2015-01-29 20:00 ` Mauro Carvalho Chehab
2015-02-03 12:00   ` Sakari Ailus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).