linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
@ 2018-07-10 16:18 Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 1/5] media: cx231xx: " Sebastian Andrzej Siewior
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-10 16:18 UTC (permalink / raw)
  To: linux-media; +Cc: tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman

This is the second repost of the "please use _irqsave() primitives in the
completion callback in order to get rid of local_irq_save() in
__usb_hcd_giveback_urb()" series for the media subsystem. I saw no
feedback from Mauro so far.

The other patches were successfully routed through their subsystems so
far and pop up in linux-next (except for the ath9k but it is merged in
its ath9k tree so it is okay).

Sebastian

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 2nd REPOST 1/5] media: cx231xx: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
@ 2018-07-10 16:18 ` Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 2/5] media: em28xx-audio: " Sebastian Andrzej Siewior
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-10 16:18 UTC (permalink / raw)
  To: linux-media
  Cc: tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman,
	Sebastian Andrzej Siewior

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/media/usb/cx231xx/cx231xx-audio.c | 10 ++++++----
 drivers/media/usb/cx231xx/cx231xx-core.c  | 10 ++++++----
 drivers/media/usb/cx231xx/cx231xx-vbi.c   |  5 +++--
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-audio.c b/drivers/media/usb/cx231xx/cx231xx-audio.c
index c4a84fb930b6..0025187c28e3 100644
--- a/drivers/media/usb/cx231xx/cx231xx-audio.c
+++ b/drivers/media/usb/cx231xx/cx231xx-audio.c
@@ -126,6 +126,7 @@ static void cx231xx_audio_isocirq(struct urb *urb)
 		stride = runtime->frame_bits >> 3;
 
 		for (i = 0; i < urb->number_of_packets; i++) {
+			unsigned long flags;
 			int length = urb->iso_frame_desc[i].actual_length /
 				     stride;
 			cp = (unsigned char *)urb->transfer_buffer +
@@ -148,7 +149,7 @@ static void cx231xx_audio_isocirq(struct urb *urb)
 				       length * stride);
 			}
 
-			snd_pcm_stream_lock(substream);
+			snd_pcm_stream_lock_irqsave(substream, flags);
 
 			dev->adev.hwptr_done_capture += length;
 			if (dev->adev.hwptr_done_capture >=
@@ -163,7 +164,7 @@ static void cx231xx_audio_isocirq(struct urb *urb)
 						runtime->period_size;
 				period_elapsed = 1;
 			}
-			snd_pcm_stream_unlock(substream);
+			snd_pcm_stream_unlock_irqrestore(substream, flags);
 		}
 		if (period_elapsed)
 			snd_pcm_period_elapsed(substream);
@@ -216,6 +217,7 @@ static void cx231xx_audio_bulkirq(struct urb *urb)
 		stride = runtime->frame_bits >> 3;
 
 		if (1) {
+			unsigned long flags;
 			int length = urb->actual_length /
 				     stride;
 			cp = (unsigned char *)urb->transfer_buffer;
@@ -234,7 +236,7 @@ static void cx231xx_audio_bulkirq(struct urb *urb)
 				       length * stride);
 			}
 
-			snd_pcm_stream_lock(substream);
+			snd_pcm_stream_lock_irqsave(substream, flags);
 
 			dev->adev.hwptr_done_capture += length;
 			if (dev->adev.hwptr_done_capture >=
@@ -249,7 +251,7 @@ static void cx231xx_audio_bulkirq(struct urb *urb)
 						runtime->period_size;
 				period_elapsed = 1;
 			}
-			snd_pcm_stream_unlock(substream);
+			snd_pcm_stream_unlock_irqrestore(substream, flags);
 		}
 		if (period_elapsed)
 			snd_pcm_period_elapsed(substream);
diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c
index 53d846dea3d2..493c2dca6244 100644
--- a/drivers/media/usb/cx231xx/cx231xx-core.c
+++ b/drivers/media/usb/cx231xx/cx231xx-core.c
@@ -799,6 +799,7 @@ static void cx231xx_isoc_irq_callback(struct urb *urb)
 	struct cx231xx_video_mode *vmode =
 	    container_of(dma_q, struct cx231xx_video_mode, vidq);
 	struct cx231xx *dev = container_of(vmode, struct cx231xx, video_mode);
+	unsigned long flags;
 	int i;
 
 	switch (urb->status) {
@@ -815,9 +816,9 @@ static void cx231xx_isoc_irq_callback(struct urb *urb)
 	}
 
 	/* Copy data from URB */
-	spin_lock(&dev->video_mode.slock);
+	spin_lock_irqsave(&dev->video_mode.slock, flags);
 	dev->video_mode.isoc_ctl.isoc_copy(dev, urb);
-	spin_unlock(&dev->video_mode.slock);
+	spin_unlock_irqrestore(&dev->video_mode.slock, flags);
 
 	/* Reset urb buffers */
 	for (i = 0; i < urb->number_of_packets; i++) {
@@ -844,6 +845,7 @@ static void cx231xx_bulk_irq_callback(struct urb *urb)
 	struct cx231xx_video_mode *vmode =
 	    container_of(dma_q, struct cx231xx_video_mode, vidq);
 	struct cx231xx *dev = container_of(vmode, struct cx231xx, video_mode);
+	unsigned long flags;
 
 	switch (urb->status) {
 	case 0:		/* success */
@@ -862,9 +864,9 @@ static void cx231xx_bulk_irq_callback(struct urb *urb)
 	}
 
 	/* Copy data from URB */
-	spin_lock(&dev->video_mode.slock);
+	spin_lock_irqsave(&dev->video_mode.slock, flags);
 	dev->video_mode.bulk_ctl.bulk_copy(dev, urb);
-	spin_unlock(&dev->video_mode.slock);
+	spin_unlock_irqrestore(&dev->video_mode.slock, flags);
 
 	/* Reset urb buffers */
 	urb->status = usb_submit_urb(urb, GFP_ATOMIC);
diff --git a/drivers/media/usb/cx231xx/cx231xx-vbi.c b/drivers/media/usb/cx231xx/cx231xx-vbi.c
index b621cf1aa96b..920417baf893 100644
--- a/drivers/media/usb/cx231xx/cx231xx-vbi.c
+++ b/drivers/media/usb/cx231xx/cx231xx-vbi.c
@@ -305,6 +305,7 @@ static void cx231xx_irq_vbi_callback(struct urb *urb)
 	struct cx231xx_video_mode *vmode =
 	    container_of(dma_q, struct cx231xx_video_mode, vidq);
 	struct cx231xx *dev = container_of(vmode, struct cx231xx, vbi_mode);
+	unsigned long flags;
 
 	switch (urb->status) {
 	case 0:		/* success */
@@ -321,9 +322,9 @@ static void cx231xx_irq_vbi_callback(struct urb *urb)
 	}
 
 	/* Copy data from URB */
-	spin_lock(&dev->vbi_mode.slock);
+	spin_lock_irqsave(&dev->vbi_mode.slock, flags);
 	dev->vbi_mode.bulk_ctl.bulk_copy(dev, urb);
-	spin_unlock(&dev->vbi_mode.slock);
+	spin_unlock_irqrestore(&dev->vbi_mode.slock, flags);
 
 	/* Reset status */
 	urb->status = 0;
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2nd REPOST 2/5] media: em28xx-audio: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 1/5] media: cx231xx: " Sebastian Andrzej Siewior
@ 2018-07-10 16:18 ` Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 3/5] media: go7007: " Sebastian Andrzej Siewior
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-10 16:18 UTC (permalink / raw)
  To: linux-media
  Cc: tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman,
	Sebastian Andrzej Siewior

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/media/usb/em28xx/em28xx-audio.c | 5 +++--
 drivers/media/usb/em28xx/em28xx-core.c  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c
index 8e799ae1df69..67481fc82445 100644
--- a/drivers/media/usb/em28xx/em28xx-audio.c
+++ b/drivers/media/usb/em28xx/em28xx-audio.c
@@ -116,6 +116,7 @@ static void em28xx_audio_isocirq(struct urb *urb)
 		stride = runtime->frame_bits >> 3;
 
 		for (i = 0; i < urb->number_of_packets; i++) {
+			unsigned long flags;
 			int length =
 			    urb->iso_frame_desc[i].actual_length / stride;
 			cp = (unsigned char *)urb->transfer_buffer +
@@ -137,7 +138,7 @@ static void em28xx_audio_isocirq(struct urb *urb)
 				       length * stride);
 			}
 
-			snd_pcm_stream_lock(substream);
+			snd_pcm_stream_lock_irqsave(substream, flags);
 
 			dev->adev.hwptr_done_capture += length;
 			if (dev->adev.hwptr_done_capture >=
@@ -153,7 +154,7 @@ static void em28xx_audio_isocirq(struct urb *urb)
 				period_elapsed = 1;
 			}
 
-			snd_pcm_stream_unlock(substream);
+			snd_pcm_stream_unlock_irqrestore(substream, flags);
 		}
 		if (period_elapsed)
 			snd_pcm_period_elapsed(substream);
diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c
index f70845e7d8c6..ec6e5152afd9 100644
--- a/drivers/media/usb/em28xx/em28xx-core.c
+++ b/drivers/media/usb/em28xx/em28xx-core.c
@@ -777,6 +777,7 @@ EXPORT_SYMBOL_GPL(em28xx_set_mode);
 static void em28xx_irq_callback(struct urb *urb)
 {
 	struct em28xx *dev = urb->context;
+	unsigned long flags;
 	int i;
 
 	switch (urb->status) {
@@ -793,9 +794,9 @@ static void em28xx_irq_callback(struct urb *urb)
 	}
 
 	/* Copy data from URB */
-	spin_lock(&dev->slock);
+	spin_lock_irqsave(&dev->slock, flags);
 	dev->usb_ctl.urb_data_copy(dev, urb);
-	spin_unlock(&dev->slock);
+	spin_unlock_irqrestore(&dev->slock, flags);
 
 	/* Reset urb buffers */
 	for (i = 0; i < urb->number_of_packets; i++) {
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2nd REPOST 3/5] media: go7007: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 1/5] media: cx231xx: " Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 2/5] media: em28xx-audio: " Sebastian Andrzej Siewior
@ 2018-07-10 16:18 ` Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 4/5] media: tm6000: " Sebastian Andrzej Siewior
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-10 16:18 UTC (permalink / raw)
  To: linux-media
  Cc: tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman,
	Sebastian Andrzej Siewior, Hans Verkuil

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/media/usb/go7007/go7007-driver.c |  9 +++++----
 drivers/media/usb/go7007/snd-go7007.c    | 11 ++++++-----
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/drivers/media/usb/go7007/go7007-driver.c b/drivers/media/usb/go7007/go7007-driver.c
index 05b1126f263e..62aeebcdd7f7 100644
--- a/drivers/media/usb/go7007/go7007-driver.c
+++ b/drivers/media/usb/go7007/go7007-driver.c
@@ -448,13 +448,14 @@ static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buf
 {
 	u32 *bytesused;
 	struct go7007_buffer *vb_tmp = NULL;
+	unsigned long flags;
 
 	if (vb == NULL) {
-		spin_lock(&go->spinlock);
+		spin_lock_irqsave(&go->spinlock, flags);
 		if (!list_empty(&go->vidq_active))
 			vb = go->active_buf =
 				list_first_entry(&go->vidq_active, struct go7007_buffer, list);
-		spin_unlock(&go->spinlock);
+		spin_unlock_irqrestore(&go->spinlock, flags);
 		go->next_seq++;
 		return vb;
 	}
@@ -468,7 +469,7 @@ static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buf
 
 	vb->vb.vb2_buf.timestamp = ktime_get_ns();
 	vb_tmp = vb;
-	spin_lock(&go->spinlock);
+	spin_lock_irqsave(&go->spinlock, flags);
 	list_del(&vb->list);
 	if (list_empty(&go->vidq_active))
 		vb = NULL;
@@ -476,7 +477,7 @@ static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buf
 		vb = list_first_entry(&go->vidq_active,
 				struct go7007_buffer, list);
 	go->active_buf = vb;
-	spin_unlock(&go->spinlock);
+	spin_unlock_irqrestore(&go->spinlock, flags);
 	vb2_buffer_done(&vb_tmp->vb.vb2_buf, VB2_BUF_STATE_DONE);
 	return vb;
 }
diff --git a/drivers/media/usb/go7007/snd-go7007.c b/drivers/media/usb/go7007/snd-go7007.c
index f84a2130f033..137fc253b122 100644
--- a/drivers/media/usb/go7007/snd-go7007.c
+++ b/drivers/media/usb/go7007/snd-go7007.c
@@ -75,13 +75,14 @@ static void parse_audio_stream_data(struct go7007 *go, u8 *buf, int length)
 	struct go7007_snd *gosnd = go->snd_context;
 	struct snd_pcm_runtime *runtime = gosnd->substream->runtime;
 	int frames = bytes_to_frames(runtime, length);
+	unsigned long flags;
 
-	spin_lock(&gosnd->lock);
+	spin_lock_irqsave(&gosnd->lock, flags);
 	gosnd->hw_ptr += frames;
 	if (gosnd->hw_ptr >= runtime->buffer_size)
 		gosnd->hw_ptr -= runtime->buffer_size;
 	gosnd->avail += frames;
-	spin_unlock(&gosnd->lock);
+	spin_unlock_irqrestore(&gosnd->lock, flags);
 	if (gosnd->w_idx + length > runtime->dma_bytes) {
 		int cpy = runtime->dma_bytes - gosnd->w_idx;
 
@@ -92,13 +93,13 @@ static void parse_audio_stream_data(struct go7007 *go, u8 *buf, int length)
 	}
 	memcpy(runtime->dma_area + gosnd->w_idx, buf, length);
 	gosnd->w_idx += length;
-	spin_lock(&gosnd->lock);
+	spin_lock_irqsave(&gosnd->lock, flags);
 	if (gosnd->avail < runtime->period_size) {
-		spin_unlock(&gosnd->lock);
+		spin_unlock_irqrestore(&gosnd->lock, flags);
 		return;
 	}
 	gosnd->avail -= runtime->period_size;
-	spin_unlock(&gosnd->lock);
+	spin_unlock_irqrestore(&gosnd->lock, flags);
 	if (gosnd->capturing)
 		snd_pcm_period_elapsed(gosnd->substream);
 }
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2nd REPOST 4/5] media: tm6000: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
                   ` (2 preceding siblings ...)
  2018-07-10 16:18 ` [PATCH 2nd REPOST 3/5] media: go7007: " Sebastian Andrzej Siewior
@ 2018-07-10 16:18 ` Sebastian Andrzej Siewior
  2018-07-10 16:18 ` [PATCH 2nd REPOST 5/5] media: usbtv: " Sebastian Andrzej Siewior
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-10 16:18 UTC (permalink / raw)
  To: linux-media
  Cc: tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman,
	Sebastian Andrzej Siewior

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/media/usb/tm6000/tm6000-video.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm6000-video.c
index 96055de6e8ce..7d268f2404e1 100644
--- a/drivers/media/usb/tm6000/tm6000-video.c
+++ b/drivers/media/usb/tm6000/tm6000-video.c
@@ -419,6 +419,7 @@ static void tm6000_irq_callback(struct urb *urb)
 {
 	struct tm6000_dmaqueue  *dma_q = urb->context;
 	struct tm6000_core *dev = container_of(dma_q, struct tm6000_core, vidq);
+	unsigned long flags;
 	int i;
 
 	switch (urb->status) {
@@ -436,9 +437,9 @@ static void tm6000_irq_callback(struct urb *urb)
 		break;
 	}
 
-	spin_lock(&dev->slock);
+	spin_lock_irqsave(&dev->slock, flags);
 	tm6000_isoc_copy(urb);
-	spin_unlock(&dev->slock);
+	spin_unlock_irqrestore(&dev->slock, flags);
 
 	/* Reset urb buffers */
 	for (i = 0; i < urb->number_of_packets; i++) {
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2nd REPOST 5/5] media: usbtv: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
                   ` (3 preceding siblings ...)
  2018-07-10 16:18 ` [PATCH 2nd REPOST 4/5] media: tm6000: " Sebastian Andrzej Siewior
@ 2018-07-10 16:18 ` Sebastian Andrzej Siewior
  2018-07-16 16:30 ` [PATCH 2nd REPOST 0/5] media: " Sebastian Andrzej Siewior
  2018-08-02 17:47 ` Mauro Carvalho Chehab
  6 siblings, 0 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-10 16:18 UTC (permalink / raw)
  To: linux-media
  Cc: tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman,
	Sebastian Andrzej Siewior, Hans Verkuil

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/media/usb/usbtv/usbtv-audio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/usbtv/usbtv-audio.c b/drivers/media/usb/usbtv/usbtv-audio.c
index 2c2ca77fa01f..4ce38246ed64 100644
--- a/drivers/media/usb/usbtv/usbtv-audio.c
+++ b/drivers/media/usb/usbtv/usbtv-audio.c
@@ -126,6 +126,7 @@ static void usbtv_audio_urb_received(struct urb *urb)
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	size_t i, frame_bytes, chunk_length, buffer_pos, period_pos;
 	int period_elapsed;
+	unsigned long flags;
 	void *urb_current;
 
 	switch (urb->status) {
@@ -179,12 +180,12 @@ static void usbtv_audio_urb_received(struct urb *urb)
 		}
 	}
 
-	snd_pcm_stream_lock(substream);
+	snd_pcm_stream_lock_irqsave(substream, flags);
 
 	chip->snd_buffer_pos = buffer_pos;
 	chip->snd_period_pos = period_pos;
 
-	snd_pcm_stream_unlock(substream);
+	snd_pcm_stream_unlock_irqrestore(substream, flags);
 
 	if (period_elapsed)
 		snd_pcm_period_elapsed(substream);
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
                   ` (4 preceding siblings ...)
  2018-07-10 16:18 ` [PATCH 2nd REPOST 5/5] media: usbtv: " Sebastian Andrzej Siewior
@ 2018-07-16 16:30 ` Sebastian Andrzej Siewior
  2018-07-16 16:45   ` Greg Kroah-Hartman
  2018-08-02 17:47 ` Mauro Carvalho Chehab
  6 siblings, 1 reply; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-16 16:30 UTC (permalink / raw)
  To: linux-media, Greg Kroah-Hartman, Mauro Carvalho Chehab; +Cc: tglx, linux-usb

On 2018-07-10 18:18:28 [+0200], To linux-media@vger.kernel.org wrote:
> This is the second repost of the "please use _irqsave() primitives in the
> completion callback in order to get rid of local_irq_save() in
> __usb_hcd_giveback_urb()" series for the media subsystem. I saw no
> feedback from Mauro so far.
> 
> The other patches were successfully routed through their subsystems so
> far and pop up in linux-next (except for the ath9k but it is merged in
> its ath9k tree so it is okay).

I posted this series on 2018-07-01 and reposted it on 2018-07-10 (as
part of this thread). Greg would you mind routing this series through
your tree?  I haven't seen a reply from Mauro and these five patches are
the only missing piece to get rid of local_irq_save() in
__usb_hcd_giveback_urb().

Sebastian

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
  2018-07-16 16:30 ` [PATCH 2nd REPOST 0/5] media: " Sebastian Andrzej Siewior
@ 2018-07-16 16:45   ` Greg Kroah-Hartman
  2018-07-16 16:49     ` Sebastian Andrzej Siewior
  0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-16 16:45 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-media, Mauro Carvalho Chehab, tglx, linux-usb

On Mon, Jul 16, 2018 at 06:30:24PM +0200, Sebastian Andrzej Siewior wrote:
> On 2018-07-10 18:18:28 [+0200], To linux-media@vger.kernel.org wrote:
> > This is the second repost of the "please use _irqsave() primitives in the
> > completion callback in order to get rid of local_irq_save() in
> > __usb_hcd_giveback_urb()" series for the media subsystem. I saw no
> > feedback from Mauro so far.
> > 
> > The other patches were successfully routed through their subsystems so
> > far and pop up in linux-next (except for the ath9k but it is merged in
> > its ath9k tree so it is okay).
> 
> I posted this series on 2018-07-01 and reposted it on 2018-07-10 (as
> part of this thread). Greg would you mind routing this series through
> your tree?  I haven't seen a reply from Mauro and these five patches are
> the only missing piece to get rid of local_irq_save() in
> __usb_hcd_giveback_urb().

I don't have them anymore, and these really should go through the media
tree, not mine.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
  2018-07-16 16:45   ` Greg Kroah-Hartman
@ 2018-07-16 16:49     ` Sebastian Andrzej Siewior
  0 siblings, 0 replies; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-07-16 16:49 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Mauro Carvalho Chehab
  Cc: linux-media, Mauro Carvalho Chehab, tglx, linux-usb

On 2018-07-16 18:45:34 [+0200], Greg Kroah-Hartman wrote:
> On Mon, Jul 16, 2018 at 06:30:24PM +0200, Sebastian Andrzej Siewior wrote:
> > On 2018-07-10 18:18:28 [+0200], To linux-media@vger.kernel.org wrote:
> > > This is the second repost of the "please use _irqsave() primitives in the
> > > completion callback in order to get rid of local_irq_save() in
> > > __usb_hcd_giveback_urb()" series for the media subsystem. I saw no
> > > feedback from Mauro so far.
> > > 
> > > The other patches were successfully routed through their subsystems so
> > > far and pop up in linux-next (except for the ath9k but it is merged in
> > > its ath9k tree so it is okay).
> > 
> > I posted this series on 2018-07-01 and reposted it on 2018-07-10 (as
> > part of this thread). Greg would you mind routing this series through
> > your tree?  I haven't seen a reply from Mauro and these five patches are
> > the only missing piece to get rid of local_irq_save() in
> > __usb_hcd_giveback_urb().
> 
> I don't have them anymore, and these really should go through the media
> tree, not mine.

fair enough.
Mauro, could you please reply?

> thanks,
> 
> greg k-h

Sebastian

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
  2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
                   ` (5 preceding siblings ...)
  2018-07-16 16:30 ` [PATCH 2nd REPOST 0/5] media: " Sebastian Andrzej Siewior
@ 2018-08-02 17:47 ` Mauro Carvalho Chehab
  2018-08-02 20:39   ` Sebastian Andrzej Siewior
  6 siblings, 1 reply; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2018-08-02 17:47 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-media, tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman

Em Tue, 10 Jul 2018 18:18:28 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> escreveu:

> This is the second repost of the "please use _irqsave() primitives in the
> completion callback in order to get rid of local_irq_save() in
> __usb_hcd_giveback_urb()" series for the media subsystem. I saw no
> feedback from Mauro so far.
> 
> The other patches were successfully routed through their subsystems so
> far and pop up in linux-next (except for the ath9k but it is merged in
> its ath9k tree so it is okay).

Sorry for the long wait... has been busy those days with two international
trips to the opposite side of the world.

I'm handling those today.

Thanks,
Mauro

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
  2018-08-02 17:47 ` Mauro Carvalho Chehab
@ 2018-08-02 20:39   ` Sebastian Andrzej Siewior
  2018-08-02 21:22     ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 12+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-08-02 20:39 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: linux-media, tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman

On 2018-08-02 14:47:43 [-0300], Mauro Carvalho Chehab wrote:
> Sorry for the long wait... has been busy those days with two international
> trips to the opposite side of the world.

No worries. At some point I wasn't if you are receiving my emails.

> I'm handling those today.

Thank you.

> Thanks,
> Mauro

Sebastian

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback
  2018-08-02 20:39   ` Sebastian Andrzej Siewior
@ 2018-08-02 21:22     ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2018-08-02 21:22 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-media, tglx, Mauro Carvalho Chehab, linux-usb, Greg Kroah-Hartman

Em Thu, 2 Aug 2018 22:39:49 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> escreveu:

> On 2018-08-02 14:47:43 [-0300], Mauro Carvalho Chehab wrote:
> > Sorry for the long wait... has been busy those days with two international
> > trips to the opposite side of the world.  
> 
> No worries. At some point I wasn't if you are receiving my emails.

The risk of losing patches is now... media workflow is based on
patchwork:
	https://patchwork.linuxtv.org/project/linux-media/list/

If the patch sent to linux-media@vger.kernel.org is stored there,
we should be handling it sooner or later ;-)

Regards,
Mauro

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-08-02 23:15 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-10 16:18 [PATCH 2nd REPOST 0/5] media: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-07-10 16:18 ` [PATCH 2nd REPOST 1/5] media: cx231xx: " Sebastian Andrzej Siewior
2018-07-10 16:18 ` [PATCH 2nd REPOST 2/5] media: em28xx-audio: " Sebastian Andrzej Siewior
2018-07-10 16:18 ` [PATCH 2nd REPOST 3/5] media: go7007: " Sebastian Andrzej Siewior
2018-07-10 16:18 ` [PATCH 2nd REPOST 4/5] media: tm6000: " Sebastian Andrzej Siewior
2018-07-10 16:18 ` [PATCH 2nd REPOST 5/5] media: usbtv: " Sebastian Andrzej Siewior
2018-07-16 16:30 ` [PATCH 2nd REPOST 0/5] media: " Sebastian Andrzej Siewior
2018-07-16 16:45   ` Greg Kroah-Hartman
2018-07-16 16:49     ` Sebastian Andrzej Siewior
2018-08-02 17:47 ` Mauro Carvalho Chehab
2018-08-02 20:39   ` Sebastian Andrzej Siewior
2018-08-02 21:22     ` Mauro Carvalho Chehab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).