* [PATCH v2] media: dt-bindings: adv748x: Fix decimal unit addresses
@ 2018-09-05 13:24 Geert Uytterhoeven
2018-09-10 12:38 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-09-05 13:24 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Rob Herring, Mark Rutland, Kieran Bingham, linux-media,
devicetree, linux-renesas-soc, Geert Uytterhoeven
With recent dtc and W=1:
Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
Unit addresses are always hexadecimal (without prefix), while the bases
of reg property values depend on their prefixes.
Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
v2:
- Add Reviewed-by,
- Drop RFC state.
---
Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
index 21ffb5ed818302ff..54d1d3bc186949fa 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt
+++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
@@ -73,7 +73,7 @@ Example:
};
};
- port@10 {
+ port@a {
reg = <10>;
adv7482_txa: endpoint {
@@ -83,7 +83,7 @@ Example:
};
};
- port@11 {
+ port@b {
reg = <11>;
adv7482_txb: endpoint {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] media: dt-bindings: adv748x: Fix decimal unit addresses
2018-09-05 13:24 [PATCH v2] media: dt-bindings: adv748x: Fix decimal unit addresses Geert Uytterhoeven
@ 2018-09-10 12:38 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2018-09-10 12:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, Kieran Bingham,
linux-media, devicetree, linux-renesas-soc
On Wed, Sep 05, 2018 at 03:24:09PM +0200, Geert Uytterhoeven wrote:
> With recent dtc and W=1:
>
> Warning (graph_port): video-receiver@70/port@10: graph node unit address error, expected "a"
> Warning (graph_port): video-receiver@70/port@11: graph node unit address error, expected "b"
>
> Unit addresses are always hexadecimal (without prefix), while the bases
> of reg property values depend on their prefixes.
>
> Fixes: e69595170b1cad85 ("media: adv748x: Add adv7481, adv7482 bindings")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-10 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 13:24 [PATCH v2] media: dt-bindings: adv748x: Fix decimal unit addresses Geert Uytterhoeven
2018-09-10 12:38 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).