From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: sakari.ailus@linux.intel.com,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: [PATCH 2/6] vim2m: fix smatch warning
Date: Thu, 7 Feb 2019 10:13:34 +0100 [thread overview]
Message-ID: <20190207091338.55705-3-hverkuil-cisco@xs4all.nl> (raw)
In-Reply-To: <20190207091338.55705-1-hverkuil-cisco@xs4all.nl>
drivers/media/platform/vim2m.c: drivers/media/platform/vim2m.c:525 device_work() warn: variable dereferenced before check 'curr_ctx' (see line 523)
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/platform/vim2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
index e31c14c7d37f..910727982230 100644
--- a/drivers/media/platform/vim2m.c
+++ b/drivers/media/platform/vim2m.c
@@ -520,13 +520,13 @@ static void device_work(struct work_struct *w)
unsigned long flags;
curr_ctx = container_of(w, struct vim2m_ctx, work_run.work);
- vim2m_dev = curr_ctx->dev;
if (NULL == curr_ctx) {
pr_err("Instance released before the end of transaction\n");
return;
}
+ vim2m_dev = curr_ctx->dev;
src_vb = v4l2_m2m_src_buf_remove(curr_ctx->fh.m2m_ctx);
dst_vb = v4l2_m2m_dst_buf_remove(curr_ctx->fh.m2m_ctx);
--
2.20.1
next prev parent reply other threads:[~2019-02-07 9:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 9:13 [PATCH 0/6] sparse/smatch fixes Hans Verkuil
2019-02-07 9:13 ` [PATCH 1/6] hdpvr: fix smatch warning Hans Verkuil
2019-02-07 9:13 ` Hans Verkuil [this message]
2019-02-07 9:13 ` [PATCH 3/6] uvc: " Hans Verkuil
2019-02-07 14:57 ` Kieran Bingham
2019-02-07 15:41 ` Laurent Pinchart
2019-02-07 16:35 ` Hans Verkuil
2019-02-07 9:13 ` [PATCH 4/6] vsp1: " Hans Verkuil
2019-02-12 13:48 ` Kieran Bingham
2019-02-12 16:31 ` Laurent Pinchart
2019-02-07 9:13 ` [PATCH 5/6] omap3isp: fix sparse warning Hans Verkuil
2019-02-07 9:18 ` Hans Verkuil
2019-02-07 14:23 ` Sakari Ailus
2019-02-07 15:45 ` Laurent Pinchart
2019-02-07 9:13 ` [PATCH 6/6] pxa_camera: fix smatch warning Hans Verkuil
2019-02-07 14:11 ` Sakari Ailus
2019-02-07 14:38 ` [PATCH 7/6] omap4iss: fix sparse warning Hans Verkuil
2019-02-07 14:51 ` Sakari Ailus
2019-02-07 15:47 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207091338.55705-3-hverkuil-cisco@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).